You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/03/03 09:15:49 UTC

Review Request 57271: RANGER-1420:Some error log information in ranger policy module

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57271/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1420
    https://issues.apache.org/jira/browse/RANGER-1420


Repository: ranger


Description
-------

Path:\ranger\agents-common\src\main\java\org\apache\ranger\plugin\policyengine\RangerPolicyEngineImpl.java 
It should be 'RangerMutableResource' rather than 'RangerMutableResource'. 
if (resource.getServiceDef() == null) {
if (resource instanceof RangerMutableResource)
{ RangerMutableResource mutable = (RangerMutableResource) resource; mutable.setServiceDef(getServiceDef()); }
else
{ LOG.debug("RangerPolicyEngineImpl.setResourceServiceDef(): Cannot set ServiceDef in RangerTagResourceMap."); }
}


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java 93c29af 


Diff: https://reviews.apache.org/r/57271/diff/1/


Testing
-------


Thanks,

Qiang Zhang


Re: Review Request 57271: RANGER-1420:Some error log information in ranger policy module

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57271/#review167802
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On March 3, 2017, 9:15 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57271/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 9:15 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1420
>     https://issues.apache.org/jira/browse/RANGER-1420
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Path:\ranger\agents-common\src\main\java\org\apache\ranger\plugin\policyengine\RangerPolicyEngineImpl.java 
> It should be 'RangerMutableResource' rather than 'RangerMutableResource'. 
> if (resource.getServiceDef() == null) {
> if (resource instanceof RangerMutableResource)
> { RangerMutableResource mutable = (RangerMutableResource) resource; mutable.setServiceDef(getServiceDef()); }
> else
> { LOG.debug("RangerPolicyEngineImpl.setResourceServiceDef(): Cannot set ServiceDef in RangerTagResourceMap."); }
> }
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java 93c29af 
> 
> 
> Diff: https://reviews.apache.org/r/57271/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>