[jira] [Commented] (TINKERPOP-2082) g:Set type is not be validated in some variant tests

["Jorge Bay (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775229#comment-16775229 ] 

Jorge Bay commented on TINKERPOP-2082:
--------------------------------------

[Gremlin-JavaScript maps TinkerPop's {{Set}} to {{Array}}|https://github.com/apache/tinkerpop/blob/3.4.0/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/io/type-serializers.js#L430-L440], do to the fact that hash can't be provided for custom types in JavaScript. JavaScript {{Set}} type is only usable for built-in types {{String}}, {{Boolean}}, {{Number}} and {{BigInteger}}.


> g:Set type is not be validated in some variant tests
> ----------------------------------------------------
>
>                 Key: TINKERPOP-2082
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2082
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet, javascript
>    Affects Versions: 3.3.4
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>
> {{g:Set}} as a type is not being validated by .NET or javascript as noticed here with this change:
> https://github.com/apache/tinkerpop/pull/964/files#diff-bc849673baf1f7ed925db681d0cc112c
> Javascript test harness for cucumber tests just coerces both {{s[]}} and {{l[]}} with {{toArray}} and .NET coerces both to a list and then if a {{s[]}} to a {{Set}} but doesn't bother to assert that the type is legit. 
> If javascript can't support set/list semantics for some reason, [~jorgebg] please remove the "javascript" from the "component" field and we won't bother to worry about it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)