You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2018/10/28 21:19:03 UTC

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails 

Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11813


Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................

IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Before this patch, Jenkins builds do not fail or warn if UBSAN
produces an error. This patch introduces two new failure modes,
"error" and "death".

In "error", a junit error is generated, which causes a build to be
labeled "unstable".

In "death", a forked process constantly monitors the test logs and
kills the test run if a UBSAN error is found.

Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
---
M bin/jenkins/all-tests.sh
M bin/jenkins/finalize.sh
2 files changed, 36 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/11813/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1274/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 03 Nov 2018 22:43:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1273/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 03 Nov 2018 22:36:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 5: Code-Review+2

carry


-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 5
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sun, 11 Nov 2018 01:01:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Todd Lipcon, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11813

to look at the new patch set (#2).

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................

IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Before this patch, Jenkins builds do not fail or warn if UBSAN
produces an error. This patch introduces two new failure modes,
"error" and "death".

In "error", a junit error is generated, which causes a build to be
labeled "unstable".

In "death", a forked process constantly monitors the test logs and
kills the test run if a UBSAN error is found.

Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
---
M bin/jenkins/all-tests.sh
M bin/jenkins/finalize.sh
2 files changed, 37 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/11813/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Todd Lipcon, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11813

to look at the new patch set (#3).

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................

IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Before this patch, Jenkins builds do not fail or warn if UBSAN
produces an error. This patch introduces two new failure modes,
"error" and "death".

In "error", a junit error is generated, which causes a build to be
labeled "unstable".

In "death", a forked process constantly monitors the test logs and
kills the test run if a UBSAN error is found.

Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
---
M bin/jenkins/all-tests.sh
M bin/jenkins/finalize.sh
2 files changed, 37 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/11813/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................

IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Before this patch, Jenkins builds do not fail or warn if UBSAN
produces an error. This patch introduces two new failure modes,
"error" and "death".

In "error", a junit error is generated, which causes a build to be
labeled "unstable".

In "death", a forked process constantly monitors the test logs and
kills the test run if a UBSAN error is found.

Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Reviewed-on: http://gerrit.cloudera.org:8080/11813
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/jenkins/all-tests.sh
M bin/jenkins/finalize.sh
2 files changed, 43 insertions(+), 0 deletions(-)

Approvals:
  Jim Apple: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 6
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh
File bin/jenkins/all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh@53
PS1, Line 53:   disown
> What kills the killer? i.e., I think it doesn't get killed based on experim
Good question! done.



-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 09 Nov 2018 16:28:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3449/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 5
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sun, 11 Nov 2018 01:01:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 1:

(2 comments)

The finalize.sh change looks great. I mentioned some concerns about the killer process looking through a lot of logs every second. We could maybe tighten it, or maybe it doesn't matter. Do you find the tests run in a similar amount of time with and without the killer?

http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh
File bin/jenkins/all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh@45
PS1, Line 45:     while ! grep -rI ": runtime error: " "${IMPALA_HOME}/logs"
There could be a log of logs here, no? We're actually only interested, I think, in impalad/catalogd/statestored logs, which could be more tightly matched.

You could also investigate https://reviews.llvm.org/D9006 which suggests there's a "log_path" option for UBSAN (but I don't know if we have it) or use -fno-sanitize-recover... (see https://releases.llvm.org/6.0.0/tools/clang/docs/UndefinedBehaviorSanitizer.html#usage) to have impalad die when these are encountered, which tends to fail the remaining tests.


http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh@49
PS1, Line 49:     kill -9 $PID_TO_KILL
Could you add a logging echo before the kill? It may catch someone by surprise.



-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 03 Nov 2018 21:04:06 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 2:

(2 comments)

> (2 comments)
 > 
 > The finalize.sh change looks great. I mentioned some concerns about
 > the killer process looking through a lot of logs every second. We
 > could maybe tighten it, or maybe it doesn't matter. Do you find the
 > tests run in a similar amount of time with and without the killer?

Yes, they do run in a similar amount of time.

http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh
File bin/jenkins/all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh@45
PS1, Line 45:     while ! grep -rI ": runtime error: " "${IMPALA_HOME}/logs"
> There could be a log of logs here, no? We're actually only interested, I th
There could, but I'm not 100% sure of all that we want to search. For instance, we appear to want to search the BE log be_tests/LastTest.log.

Thank you for educating me about log_path. It appears that this has a couple of disadvantages. First, it separates the UBSAN logs from the BE test logs, which makes tracking down which test tickled which UBSAN error more difficult. Second, it writes to $LOG_PATH.$PID and doesn't clobber the old $LOG_PATH.$LAST_PID. This makes it hard to grep without accidentally grepping the earlier logs.

Unfortunately, the no-recover option doesn't work with our suppressions. The dynamic suppressions don't work with no-recover, and the static ones don't work with distcc, since they have to be in a file and distcc doesn't know how to propagate that file.


http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh@49
PS1, Line 49:     >2 echo "Killing process $PID_TO_KILL because it invoked undefined behavior"
> Could you add a logging echo before the kill? It may catch someone by surpr
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 03 Nov 2018 22:01:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 5
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sun, 11 Nov 2018 05:02:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 4
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sun, 11 Nov 2018 00:22:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 3: Code-Review+2

I think this is localized enough that it's fine. Do take a look to see if killer gets killed and needs to be killed explicitly.

Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 18:45:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1344/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 4
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 09 Nov 2018 17:06:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 4:

I wanted to give you a chance to see the killer killer before carrying your +2.


-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 4
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 09 Nov 2018 16:59:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1192/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sun, 28 Oct 2018 21:51:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh
File bin/jenkins/all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh@45
PS1, Line 45:     while ! grep -rI ": runtime error: " "${IMPALA_HOME}/logs"
> There could, but I'm not 100% sure of all that we want to search. For insta
Ok. If it's not slowing things down, no need to be clever. (We could also use find and mtime to find updated logs, but, again, no need to be clever.)


http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh@53
PS1, Line 53:   disown
What kills the killer? i.e., I think it doesn't get killed based on experimenting with the script below. You could add an exit based on "test -e /proc/$PID_TO_KILL" inside of killer to let killer die if the parent process is gone.


$cat t.sh
function t {
  while true; do
    sleep 2
  done
}

t &
disown

echo done



-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 18:44:22 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Todd Lipcon, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11813

to look at the new patch set (#4).

Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails
......................................................................

IMPALA-5031: Jenkins jobs should fail when UBSAN fails

Before this patch, Jenkins builds do not fail or warn if UBSAN
produces an error. This patch introduces two new failure modes,
"error" and "death".

In "error", a junit error is generated, which causes a build to be
labeled "unstable".

In "death", a forked process constantly monitors the test logs and
kills the test run if a UBSAN error is found.

Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
---
M bin/jenkins/all-tests.sh
M bin/jenkins/finalize.sh
2 files changed, 43 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/11813/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b
Gerrit-Change-Number: 11813
Gerrit-PatchSet: 4
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>