You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/03 17:42:55 UTC
[GitHub] [accumulo] Manno15 opened a new issue #1902: Manager specific max message size
Manno15 opened a new issue #1902:
URL: https://github.com/apache/accumulo/issues/1902
In relation to [ACCUMULO-2352](https://issues.apache.org/jira/browse/ACCUMULO-2352). Issue proposes implementing a specific manager max message size over defaulting the use to `general_max_message_size`. Similar to the specific Tserver one. Before I implement it, I want to see if this is still a desired feature or not considering the age of the original ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on issue #1902: Manager specific max message size
Posted by GitBox <gi...@apache.org>.
Manno15 commented on issue #1902:
URL: https://github.com/apache/accumulo/issues/1902#issuecomment-772871953
I am open to closing both. I will leave this open until tomorrow in case anyone else wants to add in their feedback and opinions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 closed issue #1902: Manager specific max message size
Posted by GitBox <gi...@apache.org>.
Manno15 closed issue #1902:
URL: https://github.com/apache/accumulo/issues/1902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 closed issue #1902: Manager specific max message size
Posted by GitBox <gi...@apache.org>.
Manno15 closed issue #1902:
URL: https://github.com/apache/accumulo/issues/1902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on issue #1902: Manager specific max message size
Posted by GitBox <gi...@apache.org>.
Manno15 commented on issue #1902:
URL: https://github.com/apache/accumulo/issues/1902#issuecomment-773362822
Closing as per the discussion above. If anyone has additional comments or feedback, they can still comment on this issue thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #1902: Manager specific max message size
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1902:
URL: https://github.com/apache/accumulo/issues/1902#issuecomment-772829931
> ACCUMULO-2367 suggests that each service should have its own configurable thrift buffer pools.
I don't think this has really been a problem. The 2367 was pretty speculative about the possible benefits from this.
> If the answer to #1 is "none" or something similar then I would suggest that we don't implement this change for several reasons.
I think the downside is probably small to none. If this hasn't been a problem since 2014 when the issue was created, I'm inclined to recommend closing this and ACCUMULO-2367 as "not a problem".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on issue #1902: Manager specific max message size
Posted by GitBox <gi...@apache.org>.
Manno15 commented on issue #1902:
URL: https://github.com/apache/accumulo/issues/1902#issuecomment-773362822
Closing as per the discussion above. If anyone has additional comments or feedback, they can still comment on this issue thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on issue #1902: Manager specific max message size
Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #1902:
URL: https://github.com/apache/accumulo/issues/1902#issuecomment-772741980
So, https://issues.apache.org/jira/browse/ACCUMULO-2360 implemented a fix for large messages so that an OOME does not occur. https://issues.apache.org/jira/browse/ACCUMULO-2367 suggests that each service should have its own configurable thrift buffer pools. https://issues.apache.org/jira/browse/ACCUMULO-2352 is for adding one to the master specifically. I have the following questions:
1. What's the downside to the Manager using a larger than needed buffer?
2. What's the optimal size for the buffer for the Manager?
3. What's the side effect if a user makes it too small?
If the answer to #1 is "none" or something similar then I would suggest that we don't implement this change for several reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on issue #1902: Manager specific max message size
Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #1902:
URL: https://github.com/apache/accumulo/issues/1902#issuecomment-772831083
+1 to closing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org