You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/05 20:11:45 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #8350: ARROW-10179: [Rust] Fixed error in labeler
jorgecarleitao opened a new pull request #8350:
URL: https://github.com/apache/arrow/pull/8350
@kszucs, It seems that I used a notation in the labeler that [is only supported in the master version of it](https://github.com/actions/labeler/issues/73#issuecomment-639034278). This PR fixes that. I verified it on my own fork: https://github.com/jorgecarleitao/arrow/pull/12
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8350:
URL: https://github.com/apache/arrow/pull/8350#discussion_r499934569
##########
File path: .github/workflows/dev_labeler/labeler.yml
##########
@@ -16,7 +16,9 @@
# under the License.
rust-lang:
-- any: ['rust/*']
+ - rust/*
Review comment:
Do we need this?
Could you confirm that `rust/**/*` covers `rust/*`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8350: ARROW-10179: [Rust] Fixed error in labeler
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8350:
URL: https://github.com/apache/arrow/pull/8350#issuecomment-703869134
https://issues.apache.org/jira/browse/ARROW-10179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #8350:
URL: https://github.com/apache/arrow/pull/8350#discussion_r500038618
##########
File path: .github/workflows/dev_labeler/labeler.yml
##########
@@ -16,7 +16,7 @@
# under the License.
rust-lang:
Review comment:
I am now ready to retire to a temple and never touch a computer again 😞
Thanks a lot for saving this, @kou . 💯
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #8350:
URL: https://github.com/apache/arrow/pull/8350#discussion_r499979599
##########
File path: .github/workflows/dev_labeler/labeler.yml
##########
@@ -16,7 +16,9 @@
# under the License.
rust-lang:
-- any: ['rust/*']
+ - rust/*
Review comment:
I confirmed during testing on my fork that both are required. This is also a [common example](https://github.com/marketplace/actions/labeler#common-examples), the `@domain/core` example, on the README.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8350: ARROW-10179: [Rust] Fixed error in labeler
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8350:
URL: https://github.com/apache/arrow/pull/8350#issuecomment-703868313
fyi @andygrove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #8350: ARROW-10179: [Rust] Fixed error in labeler
Posted by GitBox <gi...@apache.org>.
kou closed pull request #8350:
URL: https://github.com/apache/arrow/pull/8350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8350:
URL: https://github.com/apache/arrow/pull/8350#discussion_r500022517
##########
File path: .github/workflows/dev_labeler/labeler.yml
##########
@@ -16,7 +16,7 @@
# under the License.
rust-lang:
Review comment:
We use `lang-rust` not `rust-lang`: https://github.com/apache/arrow/pulls?q=is%3Apr+is%3Aopen+label%3Alang-rust
Should we rename this to `lang-rust`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8350:
URL: https://github.com/apache/arrow/pull/8350#discussion_r500011422
##########
File path: .github/workflows/dev_labeler/labeler.yml
##########
@@ -16,7 +16,9 @@
# under the License.
rust-lang:
-- any: ['rust/*']
+ - rust/*
Review comment:
Thanks.
I also confirmed it with:
* https://github.com/kou/arrow/commit/7f37e3566d9fb61287777c0e5fa83c0fd13f0b64
* https://github.com/kou/arrow/pull/7
The `rust-lang` tag was assigned for `rust/README.md` change without `rust/*`.
It seems that `rust/*` is needless.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #8350:
URL: https://github.com/apache/arrow/pull/8350#discussion_r500016659
##########
File path: .github/workflows/dev_labeler/labeler.yml
##########
@@ -16,7 +16,9 @@
# under the License.
rust-lang:
-- any: ['rust/*']
+ - rust/*
Review comment:
Thanks @kou . I probably made a mistake during testing in my repo, then. If it works, it works 👍 I removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org