You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "findepi (via GitHub)" <gi...@apache.org> on 2025/01/29 10:20:27 UTC
[PR] Restore ability to run single SLT file [datafusion]
findepi opened a new pull request, #14355:
URL: https://github.com/apache/datafusion/pull/14355
Make it possible again to run single SLT file, even if it's name is a substring of other file(s).
For example, after the change, this command:
cargo test --test sqllogictests -- test_files/union.slt
runs `union.slt` file, but does not run `pg_compat_union.slt`.
The functionality was probably accidentally lost probably in https://github.com/apache/datafusion/pull/13936
cc @Omega359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Restore ability to run single SLT file [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #14355:
URL: https://github.com/apache/datafusion/pull/14355#issuecomment-2622167347
thank you @Omega359 @alamb !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Restore ability to run single SLT file [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14355:
URL: https://github.com/apache/datafusion/pull/14355#issuecomment-2622078034
Thanks again @findepi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Restore ability to run single SLT file [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on PR #14355:
URL: https://github.com/apache/datafusion/pull/14355#issuecomment-2621782574
I made a small PR to your branch to show the # of files tested, verifying that
`cargo test --test sqllogictests -- union.slt`
runs 2 files whereas
`cargo test --test sqllogictests -- test_files/union.slt`
runs 1 file.
I also verified that the sqlite tests ran without issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Restore ability to run single SLT file [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #14355:
URL: https://github.com/apache/datafusion/pull/14355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Restore ability to run single SLT file [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14355:
URL: https://github.com/apache/datafusion/pull/14355#issuecomment-2621874234
> The functionality was probably accidentally lost probably in #13936
BTW I think it is currently possible to run a single file. For example this will run both `union.slt` and `pg_compat_union.slt`.
```shell
cargo test --test sqllogictests -- union.slt
```
However, it only matches on the file name (not the entire path) so using `test_files/union.slt` does not work as you observe
> I made a small PR to your branch to show the # of files tested, verifying that
LOL we did the same thing @Omega359
- https://github.com/apache/datafusion/pull/14359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org