You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "caicancai (via GitHub)" <gi...@apache.org> on 2024/10/14 16:13:22 UTC

[PR] [CALCITE-6625] Support NOT EQUALS operator in Cassandra adapter [calcite]

caicancai opened a new pull request, #4004:
URL: https://github.com/apache/calcite/pull/4004

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-6625] Support NOT EQUALS operator in Cassandra adapter [calcite]

Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #4004:
URL: https://github.com/apache/calcite/pull/4004#discussion_r1801326324


##########
cassandra/src/test/java/org/apache/calcite/test/CassandraAdapterTest.java:
##########
@@ -154,4 +154,16 @@ static void load(CqlSession session) {
         .enableMaterializations(true)
         .explainContains("CassandraTableScan(table=[[twissandra, Tweets_By_User]])");
   }
+
+  @Test void testNotEquals() {
+    CalciteAssert.that()
+        .with(TWISSANDRA)
+        .query("select * from \"tweets\" where \"username\" <> 'JmuhsAaMdw'")
+        .enableMaterializations(false)
+        .explainContains("CassandraFilter(condition=[<>($0, 'JmuhsAaMdw')])\n"
+            + "    CassandraTableScan(table=[[twissandra, tweets]])")
+        .limit(1)
+        .returns("tweet_id=f3c329de-d05b-11e5-b58b-90e2ba530b12; "

Review Comment:
   Sorry, this test was automatically generated by copilot before. I am setting up a Cassandra environment to test it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-6625] Support NOT EQUALS operator in Cassandra adapter [calcite]

Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai closed pull request #4004: [CALCITE-6625] Support NOT EQUALS operator in Cassandra adapter
URL: https://github.com/apache/calcite/pull/4004


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-6625] Support NOT EQUALS operator in Cassandra adapter [calcite]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4004:
URL: https://github.com/apache/calcite/pull/4004#issuecomment-2411766176

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4004) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4004&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4004&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4004&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4004&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4004&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4004)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-6625] Support NOT EQUALS operator in Cassandra adapter [calcite]

Posted by "NobiGo (via GitHub)" <gi...@apache.org>.
NobiGo commented on code in PR #4004:
URL: https://github.com/apache/calcite/pull/4004#discussion_r1801077412


##########
cassandra/src/test/java/org/apache/calcite/test/CassandraAdapterTest.java:
##########
@@ -154,4 +154,16 @@ static void load(CqlSession session) {
         .enableMaterializations(true)
         .explainContains("CassandraTableScan(table=[[twissandra, Tweets_By_User]])");
   }
+
+  @Test void testNotEquals() {
+    CalciteAssert.that()
+        .with(TWISSANDRA)
+        .query("select * from \"tweets\" where \"username\" <> 'JmuhsAaMdw'")
+        .enableMaterializations(false)
+        .explainContains("CassandraFilter(condition=[<>($0, 'JmuhsAaMdw')])\n"
+            + "    CassandraTableScan(table=[[twissandra, tweets]])")
+        .limit(1)
+        .returns("tweet_id=f3c329de-d05b-11e5-b58b-90e2ba530b12; "

Review Comment:
   Is this result reasonable? The result has `username = JmuhsAaMdw`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org