You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Duo Zhang (JIRA)" <ji...@apache.org> on 2018/11/08 06:48:01 UTC
[jira] [Commented] (HBASE-21451) The way we maintain the
lastestPaths in ReplicationSourceManager is broken when sync replication is
used
[ https://issues.apache.org/jira/browse/HBASE-21451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679353#comment-16679353 ]
Duo Zhang commented on HBASE-21451:
-----------------------------------
[~zghaobac] FYI.
> The way we maintain the lastestPaths in ReplicationSourceManager is broken when sync replication is used
> --------------------------------------------------------------------------------------------------------
>
> Key: HBASE-21451
> URL: https://issues.apache.org/jira/browse/HBASE-21451
> Project: HBase
> Issue Type: Sub-task
> Components: Replication
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-21451.patch
>
>
> Here is the problematic code
> {code}
> // Add to latestPaths
> Iterator<Path> iterator = latestPaths.iterator();
> while (iterator.hasNext()) {
> Path path = iterator.next();
> if (path.getName().contains(logPrefix)) {
> iterator.remove();
> break;
> }
> }
> this.latestPaths.add(newLog);
> {code}
> Here we just use contains, but for sync replication wal group, it just adds something after the default prefix for regionserver, so the code will be broken...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)