You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/23 02:50:29 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34046: [SPARK-36804][YARN] Using the verbose parameter in yarn mode would cause application submission failure
HyukjinKwon commented on a change in pull request #34046:
URL: https://github.com/apache/spark/pull/34046#discussion_r714437585
##########
File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala
##########
@@ -66,6 +74,15 @@ private[spark] class ClientArguments(args: Array[String]) {
throw new IllegalArgumentException("Cannot have primary-py-file and primary-r-file" +
" at the same time")
}
+
+ if (verbose) {
+ logInfo("Client arguments for YARN application:")
Review comment:
I remember we already have such mode in `SparkSubmit`. Can we follow how it's done there? e.g.) https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala#L86-L88
Printing out all args would be enough I suspect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org