[GitHub] [incubator-devlake] Startrekzky commented on issue #3662: [Bug][DORA Dashboard] Metrics don't honor time-range

[GitBox <gi...@apache.org>]

Startrekzky commented on issue #3662:
URL: https://github.com/apache/incubator-devlake/issues/3662#issuecomment-1306828476

   Hey @keon94 , there're a few cases here.
   
   1. For time-series charts like `Number of Deployments`, I created a series of calendar months for the last six months and use it to join the actual data; if not, the month with no deployment will not be shown in the X-axis. In this case, the X-axis will always display the last six months, so the metrics does not honor time-range by design.
   ![image](https://user-images.githubusercontent.com/14050754/200510650-d7ef9eb9-7fc8-47cd-bdaa-5274f2b8c281.png)
   
      #### Improvements 
      Instead of adding time-range filter here, how about rename `Number of Deployments` to `Number of Deployments [Last six months]`?
   
   2. For text charts like `Deployment Frequency`, the SQL takes the FROM date to create calendar dates to calculate if Deployment Frequency falls into `daily`, `weekly` or `monthly`. In this case, the deployments being calculated are filtered by the generated calendar dates.
   ![image](https://user-images.githubusercontent.com/14050754/200513614-194c5f28-1986-4d9d-9d09-739db313d18c.png)
      #### Improvements 
      Any suggestions? @keon94 
   
   3. For text charts like `Lead Time for Changes`, `Median Time to Restore Service` and `Change Failure Rate`, the SQL takes the time-range.
   ![image](https://user-images.githubusercontent.com/14050754/200514397-406cc28d-42a6-495c-8fe3-afe15223afc6.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org