You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/04 09:43:16 UTC
[GitHub] [maven] cstamas opened a new pull request, #732: [MNG-7471] Make Resolver util and connector-basic provided
cstamas opened a new pull request, #732:
URL: https://github.com/apache/maven/pull/732
The util is exportedArtifact AND exportedPackage
The connector-basic is only exportedArtifact.
Reasoning:
* exportedArtifact -- prevents "own" artifact to be added to realm
* exportedPackage -- makes it "visible" in realm
So, this basically prevents bad versions of util and connector-basic
enter the plugin realm (as they will be not added to it), while
util remains "visible" to plugins, as the intent was, most
common due GenericVersions etc.
---
https://issues.apache.org/jira/browse/MNG-7471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1119523830
> What does this logically change and the reasoning?
Did you read PR description fully? :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1119922961
Now I did. Honestly, I have no clue here. I totally trust your judgement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123563671
The CI failed on macOS as for some reason Bootstrap failed, and hence, many unrelated ITs failed as well (as things were not present in local repo)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123503869
Stupid question: Do we need an IT which proves that these changes are required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123656284
Testing again...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1585064801
Service locator is deprecated, will be removed, so stay away from it. See instead this https://github.com/maveniverse/mima
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123596093
> The CI failed on macOS as for some reason Bootstrap failed, and hence, many unrelated ITs failed as well (as things were not present in local repo)
reason:
```
transfer failed for https://repo1.maven.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom: Operation timed out (Read failed)
```
try re-run filed build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rbourbonnavarro commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by "rbourbonnavarro (via GitHub)" <gi...@apache.org>.
rbourbonnavarro commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1584976645
Hi @cstamas, why was the package of `maven-resolver-connector-basic` not exported as the one of `maven-resolver-util` was? I have a use case where I'm setting up the [`RepositorySystem`](https://github.com/apache/maven/blob/ac0bc5541e3d1a19b22c4138c354237c8202e11f/maven-core/src/main/java/org/apache/maven/repository/RepositorySystem.java#L42) with the [`DefaultServiceLocator`](https://github.com/apache/maven-resolver/blob/fa5d6cf96618cca3ea5b8dcba48b315f68586c78/maven-resolver-impl/src/main/java/org/eclipse/aether/impl/DefaultServiceLocator.java#L93) and I can't add the [`BasicRepositoryConnectorFactory`](https://github.com/apache/maven-resolver/blob/fa5d6cf96618cca3ea5b8dcba48b315f68586c78/maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java#L48) as the implementation for [`RepositoryConnectorFactory`](https://github.com/apache/maven-resolver/blob/fa5d6cf96618cca3ea5b8dcba48b315f68586c78/maven-resolver-spi/src/main/j
ava/org/eclipse/aether/spi/connector/RepositoryConnectorFactory.java#L32) because I don't have access to it.
How is the right way to achieve this in `Maven 3.9`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123557648
> Stupid question: Do we need an IT which proves that these changes are required?
https://github.com/apache/maven-integration-testing/pull/158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123600512
> reason:...
Whatever the reason is, it is unrelated to change in this PR, that was my point. Probably some networking issue on GH side...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1119521798
What does this logically change and the reasoning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123820300
Merged manually:
maven-3.9.x 4de39476ff690774ece57637e91653d2ef234fd3
master a83ed86c4850c3fc09e5623eb00869ab3e39c959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #732:
URL: https://github.com/apache/maven/pull/732#issuecomment-1123605541
> Whatever the reason is, it is unrelated to change in this PR, that was my point. Probably some networking issue on GH side...
exactly GH issue ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas closed pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
Posted by GitBox <gi...@apache.org>.
cstamas closed pull request #732: [MNG-7471] 3.9.x Make Resolver util and connector-basic provided
URL: https://github.com/apache/maven/pull/732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org