You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/12/30 01:41:51 UTC

[GitHub] [kylin] kyotoYaho commented on a change in pull request #1524: KYLIN-3392 Fix BufferUnderflowException read DecimalAggregator when it is null

kyotoYaho commented on a change in pull request #1524:
URL: https://github.com/apache/kylin/pull/1524#discussion_r549907811



##########
File path: core-metadata/src/main/java/org/apache/kylin/metadata/datatype/BigDecimalSerializer.java
##########
@@ -47,8 +47,7 @@ public BigDecimalSerializer(DataType type) {
     @Override
     public void serialize(BigDecimal value, ByteBuffer out) {
         if (value == null) {
-            BytesUtil.writeVInt(0, out);

Review comment:
       We cannot change the null check logic for backward compatibility




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org