You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2026/10/19 19:09:13 UTC
[PR] fix(sqllab): keep the results grid header opaque when rows scroll under it [superset]
sadpandajoe opened a new pull request, #45480:
URL: https://github.com/apache/superset/pull/45480
### SUMMARY
Root cause: #41882 (be600f78fc, ag-grid 35.3.1 → 36.0.0) changed how the grid header is laid out. In ag-grid 35, `.ag-header` was its own block above the scrolling body and painted its own `--ag-header-background-color`. In ag-grid 36, the header rows live in a `position: sticky` container (`.ag-grid-pinned-top-rows`) inside the same scroll viewport (`.ag-grid-viewport`) as the data rows. ag-grid paints that container with `--ag-data-background-color`, which derives from the `backgroundColor` theme param. The header color itself is only a tint drawn on `.ag-header-row::after`.
`ThemedAgGridReact` deliberately sets `backgroundColor: 'transparent'` and `headerBackgroundColor: theme.colorFillTertiary` (4% black in the default theme), so on ag-grid 36 the sticky header is almost fully see-through. Rows scrolling beneath it show through the header text in every `GridTable` consumer: SQL Lab results, SQL Lab table preview, and the Explore data/samples panes. The AG Grid Table chart is unaffected because its container already overrides `--ag-background-color`.
Fix: `GridTable` passes an opaque `backgroundColor: theme.colorBgContainer` to `ThemedAgGridReact`, merged under any caller-supplied `themeOverrides`, so callers can still override it. `colorBgContainer` is the background of the SQL Lab editor and the Explore data pane that host the grid, so nothing changes visually except that rows no longer show through. The header keeps its existing grey tint, which now sits on an opaque base. `ThemedAgGridReact`'s shared default is left untouched.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
SQL Lab, `SELECT * FROM birth_names LIMIT 100`, results grid scrolled so row 10/11 sits partly under the header.
**Before (light):** row 10's values overlap the header labels.

**Before (dark):**

**After (light):** the header is opaque and hides the row beneath it.

**After (dark):**

### TESTING INSTRUCTIONS
1. Open SQL Lab and run a query that returns more rows than fit in the results pane, e.g. `SELECT * FROM birth_names LIMIT 100`.
2. Scroll the results grid down slowly and stop midway through a row, so the row sits partly under the column header.
3. Before this change, that row's text (including the row-number column) shows through the header. After it, the header is opaque and hides the row.
4. Repeat in the Explore chart's data pane (Results / Samples tabs), and in dark mode.
5. Scroll horizontally and confirm cells don't show through the pinned row-number column.
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #45465
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
- Notes: the regression test asserts on ag-grid's generated theme CSS via the private `_getParamsCss()` because jsdom cannot paint; an ag-grid upgrade could require updating that assertion.
- Notes: the opaque background uses `colorBgContainer` (the surface of the SQL Lab editor and Explore data pane) rather than `colorBgBase` as the AG Grid Table chart does; on a surface with a different background (e.g. a modal in dark mode) the grid body can be a slightly different shade.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sqllab): keep the results grid header opaque when rows scroll under it [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #45480:
URL: https://github.com/apache/superset/pull/45480#issuecomment-6275146779
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 78740fcf20318ff16a172a02661bc2acd7fcc193 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ad66adaf9122838146b36b4 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-45480--superset-docs-preview.netlify.app](https://deploy-preview-45480--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DYxLDsIwDAXv4jVe9KOocAOO4RCDFyEOdqqqQtwdL0Z6mifNF7rpuw-4AVwgG7WHxN7rMHIe6J9aKaOxh3IUpsKGcTbvZNwGmh6OLnrgENP9JdEp3Kue9xKlRCUF9LxO87wt27SmvKS8wu8P) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-45480--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sqllab): keep the results grid header opaque when rows scroll under it [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #45480:
URL: https://github.com/apache/superset/pull/45480#issuecomment-6275280480
## CodeAnt PR Risk: Low Risk
- The PR appears safe to merge; it makes the grid background opaque so scrolled rows do not show through sticky headers.
- A focused test verifies the grid theme uses the container background color.
**Assessed commit:** `78740fcf2031`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sqllab): keep the results grid header opaque when rows scroll under it [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #45480:
URL: https://github.com/apache/superset/pull/45480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sqllab): keep the results grid header opaque when rows scroll under it [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45480:
URL: https://github.com/apache/superset/pull/45480#issuecomment-6275411371
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45480?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 83.57%. Comparing base ([`f0cfaff`](https://app.codecov.io/gh/apache/superset/commit/f0cfaff78811369431bd146f351782d91269707d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`78740fc`](https://app.codecov.io/gh/apache/superset/commit/78740fcf20318ff16a172a02661bc2acd7fcc193?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #45480 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 3049 3049
Lines 199985 199987 +2
Branches 46650 46650
=======================================
+ Hits 167133 167137 +4
+ Misses 29610 29608 -2
Partials 3242 3242
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/45480/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/45480/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.25% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45480?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org