You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "a2l007 (via GitHub)" <gi...@apache.org> on 2025/05/19 22:57:19 UTC
[PR] Fix class loading issue for AWS Glue catalog in Iceberg extension (druid)
a2l007 opened a new pull request, #18016:
URL: https://github.com/apache/druid/pull/18016
Fixes #18015.
### Description
Fixes an issue where attempting to load iceberg tables from an AWS Glue catalog fails with ClassNotFound exceptions.
AWS Glue catalog internally uses [DynConstructors](https://iceberg.apache.org/javadoc/1.6.1/org/apache/iceberg/common/DynConstructors.html) which uses reflection to locate certain Glue-related classes from the iceberg-aws dependency. This uses the [current thread context classloader](https://github.com/apache/iceberg/blob/apache-iceberg-1.6.1/common/src/main/java/org/apache/iceberg/common/DynConstructors.java#L119) to locate it but these classes are only available on the application classloader.
This PR does a context classloader switch to fix the issue.
#### Release note
Fixes an issue where loading Iceberg tables from the AWS Glue Catalog could fail due to ClassNotFoundException exceptions.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix class loading issue for AWS Glue catalog in Iceberg extension (druid)
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on PR #18016:
URL: https://github.com/apache/druid/pull/18016#issuecomment-2892528366
@a2l007 I think pulling the latest changes from master into your branch should resolve the CodeQL CI errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix class loading issue for AWS Glue catalog in Iceberg extension (druid)
Posted by "a2l007 (via GitHub)" <gi...@apache.org>.
a2l007 commented on PR #18016:
URL: https://github.com/apache/druid/pull/18016#issuecomment-2894641669
> I wonder if there’s something similar we could do with the upstream Iceberg project?
That sounds reasonable, I can follow up with the iceberg project and see if it can be resolved on their end.
> were you able to successfully connect to the AWS Glue catalog with this patch?
Unfortunately, I don't have a glue catalog setup to test this, but I was able to reproduce the error using the ingestion spec from #18015 and this patch resolves it. The follow up errors were access related which makes sense since I don't have access to the catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix class loading issue for AWS Glue catalog in Iceberg extension (druid)
Posted by "a2l007 (via GitHub)" <gi...@apache.org>.
a2l007 commented on PR #18016:
URL: https://github.com/apache/druid/pull/18016#issuecomment-2896038028
> Would it be possible for you to share a compiled version of the patched extension (as a JAR)?
@redson-bc Unfortunately, I run an internal version of JDK and cannot share jars generated from it. @abhishekrb19 Is this something you can help with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix class loading issue for AWS Glue catalog in Iceberg extension (druid)
Posted by "a2l007 (via GitHub)" <gi...@apache.org>.
a2l007 merged PR #18016:
URL: https://github.com/apache/druid/pull/18016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix class loading issue for AWS Glue catalog in Iceberg extension (druid)
Posted by "redson-bc (via GitHub)" <gi...@apache.org>.
redson-bc commented on PR #18016:
URL: https://github.com/apache/druid/pull/18016#issuecomment-2895901498
@a2l007 thanks a lot for providing a fix so quickly!
Would it be possible for you to share a compiled version of the patched extension (as a JAR)? I’d like to upload it into my Druid image and test it directly in my EKS environment before the official release.
Appreciate the support!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org