You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2018/03/19 11:16:08 UTC
Review Request 66132: ATLAS-2505 :- Set client IP to authorization
request call for audit logging.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66132/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2505
https://issues.apache.org/jira/browse/ATLAS-2505
Repository: atlas
Description
-------
This patch inclues changes to set client IP to authorization request ie AtlasAdminRequest, AtlasEntityRequest, AtlasTypeRequest object for audit logging.
Diffs
-----
authorization/pom.xml 92be82ef
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java 8c57946b
server-api/src/main/java/org/apache/atlas/RequestContextV1.java 4f962877
webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 073d7ee8
Diff: https://reviews.apache.org/r/66132/diff/1/
Testing
-------
Tested the clientIp property in AtlasRequest object set correctly with client's remote ip during authz calls.
Thanks,
Nixon Rodrigues
Re: Review Request 66132: ATLAS-2505 :- Set client IP to authorization
request call for audit logging.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66132/#review199929
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 19, 2018, 11:16 a.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66132/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 11:16 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2505
> https://issues.apache.org/jira/browse/ATLAS-2505
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch inclues changes to set client IP to authorization request ie AtlasAdminRequest, AtlasEntityRequest, AtlasTypeRequest object for audit logging.
>
>
> Diffs
> -----
>
> authorization/pom.xml 92be82ef
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java 8c57946b
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 4f962877
> webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 073d7ee8
>
>
> Diff: https://reviews.apache.org/r/66132/diff/1/
>
>
> Testing
> -------
>
> Tested the clientIp property in AtlasRequest object set correctly with client's remote ip during authz calls.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>