You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "17krishna8 (via GitHub)" <gi...@apache.org> on 2026/10/16 15:49:49 UTC
[PR] Ignore a malformed Range header instead of failing the resource request [wicket]
17krishna8 opened a new pull request, #1672:
URL: https://github.com/apache/wicket/pull/1672
A `Range` header that does not survive the parsing made the whole resource request fail instead of the resource being served:
- `Range: bytes=5` (no dash) and `Range: bytes=abc` fail with `ArrayIndexOutOfBoundsException`, because the second part of the range is read without checking that there is one
- `Range: bytes=1-x` and values that do not fit into a long fail with `NumberFormatException`
- `Range: bytes 5-10` (no `=`) feeds the whole header text to the number parser instead
Every request to a Wicket served resource goes through `AbstractResource.setRequestRangeMetaData()`, so any client able to request a resource can turn such a header into a failed request. The header value is client input, it is not under the application's control, which makes this a denial-of-service vector rather than a plain robustness bug.
RFC 9110 requires an origin server to ignore a `Range` header it does not understand, so a malformed value now falls back to serving the whole resource, and the content range meta data is only set for a header of the form `bytes=<start>-<end>` where both parts are numbers that fit into a long. A well-formed range is picked up exactly as before, including the first-of-several rule from WICKET-5995.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore a malformed Range header instead of failing the resource request [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on code in PR #1672:
URL: https://github.com/apache/wicket/pull/1672#discussion_r4300825689
##########
wicket-core-tests/src/test/java/org/apache/wicket/request/resource/AbstractResourceRangeHeaderTest.java:
##########
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.request.resource;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
+import java.nio.charset.StandardCharsets;
+
+import org.apache.wicket.request.Response;
+import org.apache.wicket.request.cycle.RequestCycle;
+import org.apache.wicket.util.tester.WicketTestCase;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Tests that a Range header with a malformed value does not fail the resource request, and that a
+ * well-formed value is still picked up.
+ */
+class AbstractResourceRangeHeaderTest extends WicketTestCase
+{
+ private static final String DATA = "0123456789";
+
+ private Long start;
+
+ private Long end;
+
+ /**
+ * A resource that records the content range meta data seen by the request cycle while its
+ * data is written.
+ */
+ private ByteArrayResource newRecordingResource()
+ {
+ return new ByteArrayResource("application/octet-stream", DATA.getBytes(StandardCharsets.US_ASCII))
Review Comment:
106 columns; the project wraps at 100. Moot if the cases move into `PackageResourceReferenceTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore a Range header whose value is not well-formed [wicket]
Posted by "17krishna8 (via GitHub)" <gi...@apache.org>.
17krishna8 commented on PR #1672:
URL: https://github.com/apache/wicket/pull/1672#issuecomment-6229813139
Thanks for the review and for checking every malformed form on master. I have reworded the description and the commit message: this is hardening, and per RFC 9110 section 14.2 a server *may* ignore a `Range` header with an invalid ranges-specifier.
The test class is gone; the malformed cases now live in `PackageResourceReferenceTest#testContentRange` with `makeRangeRequest()`, so they go through a range-capable resource like the existing cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org