You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/12/23 11:48:28 UTC

[GitHub] [kylin] zhangayqian opened a new pull request #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode

zhangayqian opened a new pull request #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode
URL: https://github.com/apache/kylin/pull/1014
 
 
   Query Node can't get allParticipants because query node no need to run job scheduler, so the jobClient is null.
   Job Node:
   <img width="1123" alt="图片" src="https://user-images.githubusercontent.com/31064237/71354317-8098e200-25b6-11ea-8b5a-e7471cfe2a98.png">
   Query Node:
   <img width="1122" alt="图片" src="https://user-images.githubusercontent.com/31064237/71354344-9a3a2980-25b6-11ea-97d4-5443d6d37aaa.png">
   
   We can add instance of the mode  equals ‘job’ or ‘all’ to job node list in query server, but query server can not find which job node is Leader. In order to avoid instance page display a leader as a follower by mistake, just display the Leader of job node as Job Node (Leader), the others display as Job Node.
   Job Node:
   <img width="1137" alt="图片" src="https://user-images.githubusercontent.com/31064237/71356316-cf497a80-25bc-11ea-8471-6c7b2ff82928.png">
   Query Node:
   <img width="1120" alt="图片" src="https://user-images.githubusercontent.com/31064237/71356426-251e2280-25bd-11ea-8cd7-10f732c0bca2.png">
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode
URL: https://github.com/apache/kylin/pull/1014#issuecomment-568459049
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@8623cae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1014/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1014   +/-   ##
   =========================================
     Coverage          ?   25.13%           
     Complexity        ?     6178           
   =========================================
     Files             ?     1431           
     Lines             ?    87168           
     Branches          ?    12191           
   =========================================
     Hits              ?    21913           
     Misses            ?    63110           
     Partials          ?     2145
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...st/controller/ServiceDiscoveryStateController.java](https://codecov.io/gh/apache/kylin/pull/1014/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TZXJ2aWNlRGlzY292ZXJ5U3RhdGVDb250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=footer). Last update [8623cae...e33d16b](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode
URL: https://github.com/apache/kylin/pull/1014#issuecomment-568459049
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@8623cae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1014/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1014   +/-   ##
   =========================================
     Coverage          ?   25.13%           
     Complexity        ?     6178           
   =========================================
     Files             ?     1431           
     Lines             ?    87168           
     Branches          ?    12191           
   =========================================
     Hits              ?    21913           
     Misses            ?    63110           
     Partials          ?     2145
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...st/controller/ServiceDiscoveryStateController.java](https://codecov.io/gh/apache/kylin/pull/1014/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TZXJ2aWNlRGlzY292ZXJ5U3RhdGVDb250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=footer). Last update [8623cae...e33d16b](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen merged pull request #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode

Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode
URL: https://github.com/apache/kylin/pull/1014
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode
URL: https://github.com/apache/kylin/pull/1014#issuecomment-568459049
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@8623cae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1014/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1014   +/-   ##
   =========================================
     Coverage          ?   25.13%           
     Complexity        ?     6178           
   =========================================
     Files             ?     1431           
     Lines             ?    87168           
     Branches          ?    12191           
   =========================================
     Hits              ?    21913           
     Misses            ?    63110           
     Partials          ?     2145
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...st/controller/ServiceDiscoveryStateController.java](https://codecov.io/gh/apache/kylin/pull/1014/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TZXJ2aWNlRGlzY292ZXJ5U3RhdGVDb250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=footer). Last update [8623cae...e33d16b](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1014: KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode
URL: https://github.com/apache/kylin/pull/1014#issuecomment-568459049
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@8623cae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1014/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1014   +/-   ##
   =========================================
     Coverage          ?   25.13%           
     Complexity        ?     6178           
   =========================================
     Files             ?     1431           
     Lines             ?    87168           
     Branches          ?    12191           
   =========================================
     Hits              ?    21913           
     Misses            ?    63110           
     Partials          ?     2145
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...st/controller/ServiceDiscoveryStateController.java](https://codecov.io/gh/apache/kylin/pull/1014/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TZXJ2aWNlRGlzY292ZXJ5U3RhdGVDb250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=footer). Last update [8623cae...e33d16b](https://codecov.io/gh/apache/kylin/pull/1014?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services