You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/10/11 01:11:09 UTC
Review Request 52724: GEODE-1570: improve rest security framework
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52724/
-----------------------------------------------------------
Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
* use annotations for authorization
* consolidate the test classes
Diffs
-----
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java 7d232ce6332175287c02af46b4b83309f41f66f1
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityEndpointsDUnitTest.java 149a905af9d0ed0fb88b6a23d08d598546cf29a1
geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java a515de5b3a08eff3d78aed31c22b374cd51dbffe
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java d645bbf2f37510378b39576f56239bc1aa5c9a07
geode-core/src/main/java/org/apache/geode/security/ResourcePermission.java d6be5402fbee9d4a18c3e143384fed2e83acbda7
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java ee5d7146011af843c2d403bc67cd3fa5aa836547
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java 54dd9e51f9a44183aea10378e243f96ba9d4b456
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java 232f0345e7db4503500ed03f1b0097ec830e6d6c
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java 8cec1101b355e703d882bae8591c56c52f74d12e
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java c05845ad612d7ad43656af099c5c50dafb3c9bb8
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java 2df95aac231bf947cac7615069a28f65c50dd6fa
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthentication.java c4226f6ab46b42ae3884365804df1d2010cc9de3
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthenticationProvider.java c482047cb49d5d06f726d52e9157bd91c7b8ef72
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthority.java fd216287e663db8e738683784da5461f5f7d8c9c
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityService.java PRE-CREATION
Diff: https://reviews.apache.org/r/52724/diff/
Testing
-------
precheckin running
Thanks,
Jinmei Liao
Re: Review Request 52724: GEODE-1570: improve rest security framework
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52724/#review152154
-----------------------------------------------------------
Ship it!
I like the new annotations! The controllers can be cleaned up a bit by removing unnecessary if statements checking the log level:
```
if (logger.isDebugEnabled()) {
...
}
```
(See https://logging.apache.org/log4j/2.x/performance.html#asyncLoggingWithParams)
- Jared Stewart
On Oct. 11, 2016, 3:56 a.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52724/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2016, 3:56 a.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * use annotations for authorization
> * consolidate the test classes
> * delete unused classes
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java 7d232ce6332175287c02af46b4b83309f41f66f1
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityEndpointsDUnitTest.java 149a905af9d0ed0fb88b6a23d08d598546cf29a1
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java a515de5b3a08eff3d78aed31c22b374cd51dbffe
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java d645bbf2f37510378b39576f56239bc1aa5c9a07
> geode-core/src/main/java/org/apache/geode/security/ResourcePermission.java d6be5402fbee9d4a18c3e143384fed2e83acbda7
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java ee5d7146011af843c2d403bc67cd3fa5aa836547
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java 54dd9e51f9a44183aea10378e243f96ba9d4b456
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java 232f0345e7db4503500ed03f1b0097ec830e6d6c
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java 8cec1101b355e703d882bae8591c56c52f74d12e
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java c05845ad612d7ad43656af099c5c50dafb3c9bb8
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java 2df95aac231bf947cac7615069a28f65c50dd6fa
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthentication.java c4226f6ab46b42ae3884365804df1d2010cc9de3
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthenticationProvider.java c482047cb49d5d06f726d52e9157bd91c7b8ef72
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthority.java fd216287e663db8e738683784da5461f5f7d8c9c
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52724/diff/
>
>
> Testing
> -------
>
> precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52724: GEODE-1570: improve rest security framework
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52724/
-----------------------------------------------------------
(Updated Oct. 11, 2016, 3:56 a.m.)
Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
Repository: geode
Description (updated)
-------
* use annotations for authorization
* consolidate the test classes
* delete unused classes
Diffs (updated)
-----
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java 7d232ce6332175287c02af46b4b83309f41f66f1
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityEndpointsDUnitTest.java 149a905af9d0ed0fb88b6a23d08d598546cf29a1
geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java a515de5b3a08eff3d78aed31c22b374cd51dbffe
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java d645bbf2f37510378b39576f56239bc1aa5c9a07
geode-core/src/main/java/org/apache/geode/security/ResourcePermission.java d6be5402fbee9d4a18c3e143384fed2e83acbda7
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java ee5d7146011af843c2d403bc67cd3fa5aa836547
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java 54dd9e51f9a44183aea10378e243f96ba9d4b456
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java 232f0345e7db4503500ed03f1b0097ec830e6d6c
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java 8cec1101b355e703d882bae8591c56c52f74d12e
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java c05845ad612d7ad43656af099c5c50dafb3c9bb8
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java 2df95aac231bf947cac7615069a28f65c50dd6fa
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthentication.java c4226f6ab46b42ae3884365804df1d2010cc9de3
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthenticationProvider.java c482047cb49d5d06f726d52e9157bd91c7b8ef72
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthority.java fd216287e663db8e738683784da5461f5f7d8c9c
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityService.java PRE-CREATION
Diff: https://reviews.apache.org/r/52724/diff/
Testing
-------
precheckin running
Thanks,
Jinmei Liao
Re: Review Request 52724: GEODE-1570: improve rest security framework
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52724/
-----------------------------------------------------------
(Updated Oct. 11, 2016, 1:31 a.m.)
Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
* use annotations for authorization
* consolidate the test classes
Diffs (updated)
-----
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java 7d232ce6332175287c02af46b4b83309f41f66f1
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityEndpointsDUnitTest.java 149a905af9d0ed0fb88b6a23d08d598546cf29a1
geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java a515de5b3a08eff3d78aed31c22b374cd51dbffe
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java d645bbf2f37510378b39576f56239bc1aa5c9a07
geode-core/src/main/java/org/apache/geode/security/ResourcePermission.java d6be5402fbee9d4a18c3e143384fed2e83acbda7
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java ee5d7146011af843c2d403bc67cd3fa5aa836547
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java 54dd9e51f9a44183aea10378e243f96ba9d4b456
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java 232f0345e7db4503500ed03f1b0097ec830e6d6c
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java 8cec1101b355e703d882bae8591c56c52f74d12e
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java c05845ad612d7ad43656af099c5c50dafb3c9bb8
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java 2df95aac231bf947cac7615069a28f65c50dd6fa
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthentication.java c4226f6ab46b42ae3884365804df1d2010cc9de3
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthenticationProvider.java c482047cb49d5d06f726d52e9157bd91c7b8ef72
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthority.java fd216287e663db8e738683784da5461f5f7d8c9c
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityService.java PRE-CREATION
Diff: https://reviews.apache.org/r/52724/diff/
Testing
-------
precheckin running
Thanks,
Jinmei Liao