[jira] [Comment Edited] (MRESOLVER-29) Move ant tasks into master as new module

["Manfred Moser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRESOLVER-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253841#comment-16253841 ] 

Manfred Moser edited comment on MRESOLVER-29 at 11/15/17 5:47 PM:
------------------------------------------------------------------

The ant tasks are published (installed and deployed) as normal so there is no issue.

The second issue indicated seems more a code and dependency problem than a reason to keep it in a separate branch. Looking at the pom the shade plugin is used to create an uber jar and there is all sorts of funky relocation and stuff happening. I have a feeling we should merge this all into one branch and then work on cleaning this uber jar up more. mavenVersion is already set at 3.5.0 and we should therefore be able to get rid of a lot of this magic since all the relocation work is no longer needed with 3.5.2 and in the ant runtime context it can all be just consistently with newer versions instead of trying be compatible with old maven versions. 

I think if the ant tasks are not releasable at any time the resolver should not be released either and having them all in one multi module project expresses that idea better. 

The main reason I did the change is so that it is easier to see the code all in one place and work with it as well as cleaner for the user and to maintain as an overall project. Wdyt? 

Also if there are specific changes for the ant task I can do to fix the dependency version issues I can attack them after the merge and prior to the next release. 


was (Author: simpligility):
The ant tasks are published (installed and deployed) as normal so there is no issue.

The second issue indicated more a code and dependency problem than a reason to keep it in a separate branch. Looking at the pom the shade plugin is used to create an uber jar and there is all sorts of funky relocation and stuff happening. I have a feeling we should merge this all into one branch and then work on cleaning this uber jar up more. mavenVersion is already set at 3.5.0 and we should therefore be able to get rid of a lot of this magic since all the relocation work is no longer needed with 3.5.2 and in the ant runtime context it can all be just consistently with newer versions instead of trying be compatible with old maven versions. 

I think if the ant tasks are not releasable at any time the resolver should not be released either and having them all in one multi module project expresses that idea better. 

The main reason I did the change is so that it is easier to see the code all in one place and work with it as well as cleaner for the user and to maintain as an overall project. Wdyt? 

Also if there are specific changes for the ant task I can do to fix the dependency version issues I can attack them after the merge and prior to the next release. 

> Move ant tasks into master as new module
> ----------------------------------------
>
>                 Key: MRESOLVER-29
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-29
>             Project: Maven Resolver
>          Issue Type: Task
>          Components: ant tasks
>            Reporter: Manfred Moser
>            Assignee: Manfred Moser
>
> The ant tasks of Maven Resolver are currently in a separate branch. This makes it hard to keep version consistent and is also harder to understand and locate for users in apache git and on github.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)