You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/07 03:44:02 UTC
[GitHub] [skywalking] hanahmily opened a new pull request #5046: Add health checker module
hanahmily opened a new pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046
OAP backend health checker module provides features described in #5034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9c706d632ba4b9a70701b269173de69c32a7ee61&el=desc) will **decrease** coverage by `1.51%`.
> The diff coverage is `43.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 54.53% 53.01% -1.52%
- Complexity 2971 2979 +8
============================================
Files 750 777 +27
Lines 18938 19505 +567
Branches 1869 1918 +49
============================================
+ Hits 10328 10341 +13
- Misses 7751 8305 +554
Partials 859 859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==) | `63.63% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <ø> (-2.23%)` | `3.00 <0.00> (ø)` | |
| [...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `25.69%`.
> The diff coverage is `25.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.06% 27.37% -25.70%
+ Complexity 2968 1564 -1404
=============================================
Files 1410 752 -658
Lines 30611 18662 -11949
Branches 3406 1822 -1584
=============================================
- Hits 16245 5108 -11137
+ Misses 13561 13199 -362
+ Partials 805 355 -450
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-3.00)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `23.52% <0.00%> (-64.71%)` | `2.00 <0.00> (-6.00)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| ... and [1110 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 159 -1251
Lines 30607 3944 -26663
Branches 3404 463 -2941
============================================
- Hits 16267 0 -16267
+ Misses 13538 3944 -9594
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...e90190f](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `1.07%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 52.17% -1.08%
+ Complexity 2981 2940 -41
============================================
Files 774 774
Lines 19425 19399 -26
Branches 1916 1903 -13
============================================
- Hits 10344 10122 -222
- Misses 8222 8435 +213
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 53.00% -0.26%
+ Complexity 2981 2978 -3
============================================
Files 774 780 +6
Lines 19425 19498 +73
Branches 1916 1918 +2
============================================
- Hits 10344 10334 -10
- Misses 8222 8308 +86
+ Partials 859 856 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `16.31%`.
> The diff coverage is `15.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 36.83% -16.32%
+ Complexity 2974 2105 -869
=============================================
Files 1410 774 -636
Lines 30607 19408 -11199
Branches 3404 1902 -1502
=============================================
- Hits 16267 7148 -9119
+ Misses 13538 11712 -1826
+ Partials 802 548 -254
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `43.66% <0.00%> (-6.34%)` | `11.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `10.41% <0.00%> (-84.59%)` | `3.00 <0.00> (-6.00)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1056 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `0.48%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 52.76% -0.49%
+ Complexity 2981 2964 -17
============================================
Files 774 777 +3
Lines 19425 19483 +58
Branches 1916 1918 +2
============================================
- Hits 10344 10281 -63
- Misses 8222 8351 +129
+ Partials 859 851 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [29 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `53.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 0.00% -53.07%
============================================
Files 1410 162 -1248
Lines 30611 4007 -26604
Branches 3406 474 -2932
============================================
- Hits 16245 0 -16245
+ Misses 13561 4007 -9554
+ Partials 805 0 -805
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1375 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 52.98% -0.27%
+ Complexity 2981 2976 -5
============================================
Files 774 779 +5
Lines 19425 19494 +69
Branches 1916 1918 +2
============================================
- Hits 10344 10329 -15
- Misses 8222 8308 +86
+ Partials 859 857 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 159 -1251
Lines 30607 3946 -26661
Branches 3404 466 -2938
============================================
- Hits 16267 0 -16267
+ Misses 13538 3946 -9592
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1376 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#discussion_r450706714
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/HealthStatus.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.query.type;
+
+import lombok.Getter;
+import lombok.Setter;
+
+@Getter
+@Setter
+public class HealthStatus {
+ private int score;
Review comment:
score rule should be added as comments.
##########
File path: oap-server/server-query-plugin/query-graphql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/resolver/HealthQuery.java
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.query.graphql.resolver;
+
+import com.coxautodev.graphql.tools.GraphQLQueryResolver;
+import java.util.Optional;
+import lombok.RequiredArgsConstructor;
+import org.apache.skywalking.oap.server.core.query.type.HealthStatus;
+import org.apache.skywalking.oap.server.health.checker.module.HealthCheckerModule;
+import org.apache.skywalking.oap.server.health.checker.provider.HealthQueryService;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+
+@RequiredArgsConstructor
+public class HealthQuery implements GraphQLQueryResolver {
Review comment:
```suggestion
public class HealthQuery implements GraphQLQueryResolver {
```
##########
File path: docs/en/setup/backend/backend-health-check.md
##########
@@ -0,0 +1,62 @@
+# Health Check
+
+Health check intends to provide a unique approach to check the healthy status of OAP server. It includes the health status
+of modules, GraphQL and gRPC services readiness.
+
+## Health Checker Module.
+
+Health Checker module could solute how to observe the health status of modules. We can active it by below:
+```yaml
+health-checker:
+ selector: ${SW_HEALTH_CHECKER:default}
+ default:
+ checkIntervalSeconds: ${SW_HEALTH_CHECKER_INTERVAL_SECONDS:5}
+```
+Notice, we should enable `prometheus` telemetry at the same time.
Review comment:
I think this is a design issue. **Any module should not depend on another module's implementation**. Otherwise, you are breaking the design principle.
From the codes level, I think you should say, the user needs to activate the `telemetry` module, meaning, the provider should not be `none` or `-`.
##########
File path: oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/H2StorageProvider.java
##########
@@ -131,6 +135,9 @@ public void prepare() throws ServiceNotProvidedException, ModuleStartException {
@Override
public void start() throws ServiceNotProvidedException, ModuleStartException {
+ MetricsCreator metricCreator = getManager().find(TelemetryModule.NAME).provider().getService(MetricsCreator.class);
+ GaugeMetrics healthChecker = metricCreator.createHealthCheckerGauge("storage_h2", MetricsTag.EMPTY_KEY, MetricsTag.EMPTY_VALUE);
+ healthChecker.setValue(1);
Review comment:
Why always `1`? According to your doc, 1 should mean unhealthy? I think you missed some codes.
##########
File path: oap-server/server-telemetry/telemetry-api/src/main/java/org/apache/skywalking/oap/server/telemetry/api/MetricsCreator.java
##########
@@ -42,4 +46,30 @@
*/
HistogramMetrics createHistogramMetric(String name, String tips, MetricsTag.Keys tagKeys,
MetricsTag.Values tagValues, double... buckets);
+
+ /**
+ * Create a Health Check gauge.
+ */
+ default GaugeMetrics createHealthCheckerGauge(String name, MetricsTag.Keys tagKeys, MetricsTag.Values tagValues) {
Review comment:
I don't think health guage requires the tag/value(s).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 168 -1242
Lines 30607 4115 -26492
Branches 3404 482 -2922
============================================
- Hits 16267 0 -16267
+ Misses 13538 4115 -9423
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `49.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 49.26% 0.00% -49.27%
============================================
Files 773 155 -618
Lines 19394 3829 -15565
Branches 1915 448 -1467
============================================
- Hits 9555 0 -9555
+ Misses 9020 3829 -5191
+ Partials 819 0 -819
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [737 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `26.38%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 52.95% -0.12%
- Complexity 2968 2974 +6
============================================
Files 1410 1417 +7
Lines 30611 30681 +70
Branches 3406 3407 +1
============================================
+ Hits 16245 16246 +1
- Misses 13561 13631 +70
+ Partials 805 804 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/query/graphql/GraphQLQueryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL0dyYXBoUUxRdWVyeVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/query/graphql/resolver/HealthQuery.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL0hlYWx0aFF1ZXJ5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `24.00% <0.00%> (-1.00%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `18.40%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 52.79% 34.39% -18.41%
+ Complexity 2942 1926 -1016
=============================================
Files 1409 758 -651
Lines 30601 18972 -11629
Branches 3404 1880 -1524
=============================================
- Hits 16156 6525 -9631
+ Misses 13641 11938 -1703
+ Partials 804 509 -295
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1077 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 152 -1258
Lines 30607 3820 -26787
Branches 3404 454 -2950
============================================
- Hits 16267 0 -16267
+ Misses 13538 3820 -9718
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...988c3fe](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 53.06% 53.24% +0.17%
- Complexity 2968 2984 +16
============================================
Files 1410 778 -632
Lines 30611 19439 -11172
Branches 3406 1911 -1495
============================================
- Hits 16245 10351 -5894
+ Misses 13561 8228 -5333
- Partials 805 860 +55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [975 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `1.29%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 51.95% -1.30%
+ Complexity 2981 2940 -41
============================================
Files 774 777 +3
Lines 19425 19483 +58
Branches 1916 1918 +2
============================================
- Hits 10344 10122 -222
- Misses 8222 8519 +297
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 53.06% 53.08% +0.01%
- Complexity 2968 2973 +5
============================================
Files 1410 777 -633
Lines 30611 19435 -11176
Branches 3406 1911 -1495
============================================
- Hits 16245 10317 -5928
+ Misses 13561 8262 -5299
- Partials 805 856 +51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [976 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 166 -1244
Lines 30607 4056 -26551
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4056 -9482
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 53.03% -0.04%
- Complexity 2968 2974 +6
============================================
Files 1410 778 -632
Lines 30611 19447 -11164
Branches 3406 1917 -1489
============================================
- Hits 16245 10314 -5931
+ Misses 13561 8275 -5286
- Partials 805 858 +53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [974 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `11.62%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 41.52% -11.63%
+ Complexity 2974 2284 -690
=============================================
Files 1410 775 -635
Lines 30607 19491 -11116
Branches 3404 1918 -1486
=============================================
- Hits 16267 8094 -8173
+ Misses 13538 10780 -2758
+ Partials 802 617 -185
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1042 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 167 -1243
Lines 30607 4063 -26544
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4063 -9475
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `1.07%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 52.17% -1.08%
+ Complexity 2981 2940 -41
============================================
Files 774 774
Lines 19425 19399 -26
Branches 1916 1903 -13
============================================
- Hits 10344 10122 -222
- Misses 8222 8435 +213
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 52.93% -0.14%
- Complexity 2968 2974 +6
============================================
Files 1410 779 -631
Lines 30611 19486 -11125
Branches 3406 1918 -1488
============================================
- Hits 16245 10314 -5931
+ Misses 13561 8314 -5247
- Partials 805 858 +53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [973 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `18.58%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 52.79% 34.20% -18.59%
+ Complexity 2942 1920 -1022
=============================================
Files 1409 758 -651
Lines 30601 18964 -11637
Branches 3404 1866 -1538
=============================================
- Hits 16156 6487 -9669
+ Misses 13641 11966 -1675
+ Partials 804 511 -293
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1080 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `12.45%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 40.69% -12.46%
+ Complexity 2974 2259 -715
=============================================
Files 1410 775 -635
Lines 30607 19491 -11116
Branches 3404 1918 -1486
=============================================
- Hits 16267 7931 -8336
+ Misses 13538 10950 -2588
+ Partials 802 610 -192
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1043 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 167 -1243
Lines 30607 4063 -26544
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4063 -9475
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 162 -1248
Lines 30607 4007 -26600
Branches 3404 474 -2930
============================================
- Hits 16267 0 -16267
+ Misses 13538 4007 -9531
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `17.31%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.12% 35.81% -17.32%
+ Complexity 2974 2063 -911
=============================================
Files 774 775 +1
Lines 19434 19394 -40
Branches 1916 1898 -18
=============================================
- Hits 10325 6946 -3379
- Misses 8250 11919 +3669
+ Partials 859 529 -330
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [221 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 165 -1245
Lines 30607 4052 -26555
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4052 -9486
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `49.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 49.24% 0.00% -49.25%
============================================
Files 773 152 -621
Lines 19394 3791 -15603
Branches 1915 448 -1467
============================================
- Hits 9551 0 -9551
+ Misses 9024 3791 -5233
+ Partials 819 0 -819
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [738 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `26.38%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 52.95% -0.12%
- Complexity 2968 2974 +6
============================================
Files 1410 1417 +7
Lines 30611 30681 +70
Branches 3406 3407 +1
============================================
+ Hits 16245 16246 +1
- Misses 13561 13631 +70
+ Partials 805 804 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/query/graphql/GraphQLQueryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL0dyYXBoUUxRdWVyeVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/query/graphql/resolver/HealthQuery.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL0hlYWx0aFF1ZXJ5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `24.00% <0.00%> (-1.00%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#discussion_r451959997
##########
File path: oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/H2StorageProvider.java
##########
@@ -131,6 +135,9 @@ public void prepare() throws ServiceNotProvidedException, ModuleStartException {
@Override
public void start() throws ServiceNotProvidedException, ModuleStartException {
+ MetricsCreator metricCreator = getManager().find(TelemetryModule.NAME).provider().getService(MetricsCreator.class);
+ GaugeMetrics healthChecker = metricCreator.createHealthCheckerGauge("storage_h2", MetricsTag.EMPTY_KEY, MetricsTag.EMPTY_VALUE);
+ healthChecker.setValue(1);
Review comment:
Fixed with an asyn health check scheduler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `53.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 0.00% -53.07%
============================================
Files 1410 158 -1252
Lines 30611 3920 -26691
Branches 3406 466 -2940
============================================
- Hits 16245 0 -16245
+ Misses 13561 3920 -9641
+ Partials 805 0 -805
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `53.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 0.00% -53.26%
============================================
Files 774 154 -620
Lines 19425 3877 -15548
Branches 1916 458 -1458
============================================
- Hits 10344 0 -10344
+ Misses 8222 3877 -4345
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [741 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.12% 53.10% -0.03%
- Complexity 2974 2987 +13
============================================
Files 774 779 +5
Lines 19434 19499 +65
Branches 1916 1914 -2
============================================
+ Hits 10325 10355 +30
- Misses 8250 8283 +33
- Partials 859 861 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 152 -1258
Lines 30607 3828 -26779
Branches 3404 454 -2950
============================================
- Hits 16267 0 -16267
+ Misses 13538 3828 -9710
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...988c3fe](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `30.76%`.
> The diff coverage is `13.41%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 22.38% -30.77%
+ Complexity 2974 1349 -1625
=============================================
Files 1410 754 -656
Lines 30607 18756 -11851
Branches 3404 1833 -1571
=============================================
- Hits 16267 4199 -12068
- Misses 13538 14243 +705
+ Partials 802 314 -488
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-11.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `10.41% <0.00%> (-84.59%)` | `3.00 <0.00> (-6.00)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-3.00)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `23.52% <0.00%> (-64.71%)` | `2.00 <0.00> (-6.00)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1139 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 52.79% 52.33% -0.46%
- Complexity 2942 2955 +13
============================================
Files 1409 776 -633
Lines 30601 19449 -11152
Branches 3404 1917 -1487
============================================
- Hits 16156 10179 -5977
+ Misses 13641 8418 -5223
- Partials 804 852 +48
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [984 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `21.76%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.06% 31.30% -21.77%
+ Complexity 2968 1769 -1199
=============================================
Files 1410 754 -656
Lines 30611 18860 -11751
Branches 3406 1855 -1551
=============================================
- Hits 16245 5904 -10341
+ Misses 13561 12508 -1053
+ Partials 805 448 -357
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1088 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 165 -1245
Lines 30607 4052 -26555
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4052 -9486
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `10.77%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 42.37% -10.78%
+ Complexity 2974 2307 -667
=============================================
Files 1410 775 -635
Lines 30607 19491 -11116
Branches 3404 1918 -1486
=============================================
- Hits 16267 8259 -8008
+ Misses 13538 10612 -2926
+ Partials 802 620 -182
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1041 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `16.22%`.
> The diff coverage is `15.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 36.91% -16.23%
+ Complexity 2974 2105 -869
=============================================
Files 1410 771 -639
Lines 30607 19361 -11246
Branches 3404 1898 -1506
=============================================
- Hits 16267 7148 -9119
+ Misses 13538 11665 -1873
+ Partials 802 548 -254
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `43.66% <0.00%> (-6.34%)` | `11.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `10.41% <0.00%> (-84.59%)` | `3.00 <0.00> (-6.00)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1059 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `38.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 38.60% 0.00% -38.61%
============================================
Files 770 149 -621
Lines 19339 3773 -15566
Branches 1913 447 -1466
============================================
- Hits 7466 0 -7466
+ Misses 11310 3773 -7537
+ Partials 563 0 -563
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (-7.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [617 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `6.09%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.12% 47.03% -6.10%
+ Complexity 2974 2744 -230
============================================
Files 774 778 +4
Lines 19434 19445 +11
Branches 1916 1912 -4
============================================
- Hits 10325 9146 -1179
- Misses 8250 9500 +1250
+ Partials 859 799 -60
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [76 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **increase** coverage by `0.31%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 52.79% 53.10% +0.31%
- Complexity 2942 2985 +43
============================================
Files 1409 777 -632
Lines 30601 19488 -11113
Branches 3404 1918 -1486
============================================
- Hits 16156 10350 -5806
+ Misses 13641 8278 -5363
- Partials 804 860 +56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [982 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `1.11%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 52.13% -1.12%
+ Complexity 2981 2940 -41
============================================
Files 774 775 +1
Lines 19425 19415 -10
Branches 1916 1907 -9
============================================
- Hits 10344 10122 -222
- Misses 8222 8451 +229
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 155 -1255
Lines 30607 3873 -26734
Branches 3404 456 -2948
============================================
- Hits 16267 0 -16267
+ Misses 13538 3873 -9665
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1376 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 52.95% -0.12%
+ Complexity 2968 2965 -3
============================================
Files 1410 775 -635
Lines 30611 19429 -11182
Branches 3406 1911 -1495
============================================
- Hits 16245 10289 -5956
+ Misses 13561 8287 -5274
- Partials 805 853 +48
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [979 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `11.76%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.06% 41.29% -11.77%
+ Complexity 2968 2401 -567
=============================================
Files 1410 756 -654
Lines 30611 18913 -11698
Branches 3406 1873 -1533
=============================================
- Hits 16245 7811 -8434
+ Misses 13561 10418 -3143
+ Partials 805 684 -121
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1031 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `15.77%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.06% 37.29% -15.78%
+ Complexity 2968 2099 -869
=============================================
Files 1410 773 -637
Lines 30611 19300 -11311
Branches 3406 1904 -1502
=============================================
- Hits 16245 7198 -9047
+ Misses 13561 11542 -2019
+ Partials 805 560 -245
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1058 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `53.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 0.00% -53.07%
============================================
Files 1410 156 -1254
Lines 30611 3908 -26703
Branches 3406 466 -2940
============================================
- Hits 16245 0 -16245
+ Misses 13561 3908 -9653
+ Partials 805 0 -805
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `9.97%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 43.17% -9.98%
+ Complexity 2974 2344 -630
============================================
Files 1410 777 -633
Lines 30607 19505 -11102
Branches 3404 1918 -1486
============================================
- Hits 16267 8421 -7846
+ Misses 13538 10463 -3075
+ Partials 802 621 -181
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1035 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 160 -1250
Lines 30607 3983 -26624
Branches 3404 464 -2940
============================================
- Hits 16267 0 -16267
+ Misses 13538 3983 -9555
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1373 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `52.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 52.79% 0.00% -52.80%
============================================
Files 1409 161 -1248
Lines 30601 4049 -26552
Branches 3404 481 -2923
============================================
- Hits 16156 0 -16156
+ Misses 13641 4049 -9592
+ Partials 804 0 -804
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1375 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 52.87% -0.28%
+ Complexity 2974 2969 -5
============================================
Files 1410 777 -633
Lines 30607 19505 -11102
Branches 3404 1918 -1486
============================================
- Hits 16267 10313 -5954
+ Misses 13538 8335 -5203
- Partials 802 857 +55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [981 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `3.04%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.12% 50.08% -3.05%
+ Complexity 2974 2885 -89
============================================
Files 774 779 +5
Lines 19434 19485 +51
Branches 1916 1913 -3
============================================
- Hits 10325 9759 -566
- Misses 8250 8894 +644
+ Partials 859 832 -27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [39 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 153 -1257
Lines 30607 3828 -26779
Branches 3404 452 -2952
============================================
- Hits 16267 0 -16267
+ Misses 13538 3828 -9710
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1377 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **increase** coverage by `0.19%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 53.06% 53.25% +0.19%
- Complexity 2968 2984 +16
============================================
Files 1410 777 -633
Lines 30611 19435 -11176
Branches 3406 1911 -1495
============================================
- Hits 16245 10351 -5894
+ Misses 13561 8224 -5337
- Partials 805 860 +55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [975 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#discussion_r451959329
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/HealthStatus.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.query.type;
+
+import lombok.Getter;
+import lombok.Setter;
+
+@Getter
+@Setter
+public class HealthStatus {
+ private int score;
Review comment:
explained it in GraphQL schema, where users access normally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 159 -1251
Lines 30607 3944 -26663
Branches 3404 463 -2941
============================================
- Hits 16267 0 -16267
+ Misses 13538 3944 -9594
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...988c3fe](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `53.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 0.00% -53.26%
============================================
Files 774 152 -622
Lines 19425 3828 -15597
Branches 1916 454 -1462
============================================
- Hits 10344 0 -10344
+ Misses 8222 3828 -4394
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [742 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 162 -1248
Lines 30607 4007 -26600
Branches 3404 474 -2930
============================================
- Hits 16267 0 -16267
+ Misses 13538 4007 -9531
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#discussion_r451962176
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/HealthStatus.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.query.type;
+
+import lombok.Getter;
+import lombok.Setter;
+
+@Getter
+@Setter
+public class HealthStatus {
+ private int score;
Review comment:
I know it is there, and in the doc too. But this field should be highlight, and the rule should not be changed randomly. The comments help us to track if change happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `3.17%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.12% 49.95% -3.18%
+ Complexity 2974 2878 -96
============================================
Files 774 778 +4
Lines 19434 19481 +47
Branches 1916 1913 -3
============================================
- Hits 10325 9732 -593
- Misses 8250 8919 +669
+ Partials 859 830 -29
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [41 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **increase** coverage by `0.20%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 52.79% 53.00% +0.20%
- Complexity 2942 2978 +36
============================================
Files 1409 780 -629
Lines 30601 19498 -11103
Branches 3404 1918 -1486
============================================
- Hits 16156 10334 -5822
+ Misses 13641 8308 -5333
- Partials 804 856 +52
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [981 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `1.25%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 51.99% -1.26%
+ Complexity 2981 2926 -55
============================================
Files 774 771 -3
Lines 19425 19388 -37
Branches 1916 1903 -13
============================================
- Hits 10344 10081 -263
- Misses 8222 8467 +245
+ Partials 859 840 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 165 -1245
Lines 30607 4052 -26555
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4052 -9486
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `49.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 49.24% 0.00% -49.25%
============================================
Files 773 153 -620
Lines 19394 3817 -15577
Branches 1915 448 -1467
============================================
- Hits 9551 0 -9551
+ Misses 9024 3817 -5207
+ Partials 819 0 -819
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [737 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 160 -1250
Lines 30607 3983 -26624
Branches 3404 464 -2940
============================================
- Hits 16267 0 -16267
+ Misses 13538 3983 -9555
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1373 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...e90190f](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 160 -1250
Lines 30607 3986 -26621
Branches 3404 470 -2934
============================================
- Hits 16267 0 -16267
+ Misses 13538 3986 -9552
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1376 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.12% 53.00% -0.13%
- Complexity 2974 2979 +5
============================================
Files 774 778 +4
Lines 19434 19509 +75
Branches 1916 1918 +2
============================================
+ Hits 10325 10341 +16
- Misses 8250 8309 +59
Partials 859 859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `17.33%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.12% 35.79% -17.34%
+ Complexity 2974 2063 -911
=============================================
Files 774 777 +3
Lines 19434 19406 -28
Branches 1916 1911 -5
=============================================
- Hits 10325 6946 -3379
- Misses 8250 11931 +3681
+ Partials 859 529 -330
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [217 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `11.08%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 52.79% 41.70% -11.09%
+ Complexity 2942 2298 -644
=============================================
Files 1409 776 -633
Lines 30601 19449 -11152
Branches 3404 1917 -1487
=============================================
- Hits 16156 8112 -8044
+ Misses 13641 10726 -2915
+ Partials 804 611 -193
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1041 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `2.23%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 50.83% -2.24%
+ Complexity 2968 2843 -125
============================================
Files 1410 757 -653
Lines 30611 19018 -11593
Branches 3406 1878 -1528
============================================
- Hits 16245 9667 -6578
+ Misses 13561 8523 -5038
- Partials 805 828 +23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [994 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `16.37%`.
> The diff coverage is `15.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 36.77% -16.38%
+ Complexity 2974 2098 -876
=============================================
Files 1410 771 -639
Lines 30607 19361 -11246
Branches 3404 1898 -1506
=============================================
- Hits 16267 7120 -9147
+ Misses 13538 11696 -1842
+ Partials 802 545 -257
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `43.66% <0.00%> (-6.34%)` | `11.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `10.41% <0.00%> (-84.59%)` | `3.00 <0.00> (-6.00)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1059 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `12.42%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.25% 40.83% -12.43%
+ Complexity 2981 2226 -755
=============================================
Files 774 770 -4
Lines 19425 19346 -79
Branches 1916 1902 -14
=============================================
- Hits 10344 7899 -2445
- Misses 8222 10847 +2625
+ Partials 859 600 -259
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [198 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `20.50%`.
> The diff coverage is `15.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 32.64% -20.51%
+ Complexity 2974 1888 -1086
=============================================
Files 1410 771 -639
Lines 30607 19352 -11255
Branches 3404 1898 -1506
=============================================
- Hits 16267 6318 -9949
+ Misses 13538 12538 -1000
+ Partials 802 496 -306
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-11.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `10.41% <0.00%> (-84.59%)` | `3.00 <0.00> (-6.00)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1077 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `26.38%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 53.06% 53.09% +0.02%
- Complexity 2968 2984 +16
============================================
Files 1410 1417 +7
Lines 30611 30680 +69
Branches 3406 3407 +1
============================================
+ Hits 16245 16290 +45
- Misses 13561 13583 +22
- Partials 805 807 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/query/graphql/GraphQLQueryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL0dyYXBoUUxRdWVyeVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/query/graphql/resolver/HealthQuery.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL0hlYWx0aFF1ZXJ5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `24.00% <0.00%> (-1.00%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `53.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 0.00% -53.07%
============================================
Files 1410 150 -1260
Lines 30611 3793 -26818
Branches 3406 448 -2958
============================================
- Hits 16245 0 -16245
+ Misses 13561 3793 -9768
+ Partials 805 0 -805
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1380 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `0.51%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 52.73% -0.52%
+ Complexity 2981 2964 -17
============================================
Files 774 779 +5
Lines 19425 19494 +69
Branches 1916 1918 +2
============================================
- Hits 10344 10281 -63
- Misses 8222 8362 +140
+ Partials 859 851 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9c706d632ba4b9a70701b269173de69c32a7ee61&el=desc) will **decrease** coverage by `1.51%`.
> The diff coverage is `43.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 54.53% 53.01% -1.52%
- Complexity 2971 2979 +8
============================================
Files 750 777 +27
Lines 18938 19505 +567
Branches 1869 1918 +49
============================================
+ Hits 10328 10341 +13
- Misses 7751 8305 +554
Partials 859 859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==) | `63.63% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <ø> (-2.23%)` | `3.00 <0.00> (ø)` | |
| [...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `75.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 167 -1243
Lines 30607 4111 -26496
Branches 3404 482 -2922
============================================
- Hits 16267 0 -16267
+ Misses 13538 4111 -9427
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 52.93% -0.14%
- Complexity 2968 2974 +6
============================================
Files 1410 779 -631
Lines 30611 19486 -11125
Branches 3406 1918 -1488
============================================
- Hits 16245 10314 -5931
+ Misses 13561 8314 -5247
- Partials 805 858 +53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [973 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `10.76%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 42.38% -10.77%
+ Complexity 2974 2310 -664
=============================================
Files 1410 775 -635
Lines 30607 19491 -11116
Branches 3404 1918 -1486
=============================================
- Hits 16267 8261 -8006
+ Misses 13538 10610 -2928
+ Partials 802 620 -182
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1041 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `30.75%`.
> The diff coverage is `13.41%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 22.39% -30.76%
+ Complexity 2974 1349 -1625
=============================================
Files 1410 754 -656
Lines 30607 18748 -11859
Branches 3404 1833 -1571
=============================================
- Hits 16267 4199 -12068
- Misses 13538 14235 +697
+ Partials 802 314 -488
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-11.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `10.41% <0.00%> (-84.59%)` | `3.00 <0.00> (-6.00)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-3.00)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `23.52% <0.00%> (-64.71%)` | `2.00 <0.00> (-6.00)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1139 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 53.06% 53.12% +0.05%
- Complexity 2968 2977 +9
============================================
Files 1410 777 -633
Lines 30611 19435 -11176
Branches 3406 1911 -1495
============================================
- Hits 16245 10324 -5921
+ Misses 13561 8255 -5306
- Partials 805 856 +51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [975 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **increase** coverage by `53.00%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
+ Coverage 0.00% 53.00% +53.00%
- Complexity 0 2979 +2979
=============================================
Files 164 778 +614
Lines 4066 19509 +15443
Branches 481 1918 +1437
=============================================
+ Hits 0 10341 +10341
- Misses 4066 8309 +4243
- Partials 0 859 +859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (ø)` | `4.00 <0.00> (?)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (ø)` | `10.00 <2.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (ø)` | `13.00 <2.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [749 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 52.95% -0.30%
+ Complexity 2981 2975 -6
============================================
Files 774 779 +5
Lines 19425 19494 +69
Branches 1916 1918 +2
============================================
- Hits 10344 10324 -20
- Misses 8222 8312 +90
+ Partials 859 858 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `53.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 0.00% -53.26%
============================================
Files 774 149 -625
Lines 19425 3786 -15639
Branches 1916 454 -1462
============================================
- Hits 10344 0 -10344
+ Misses 8222 3786 -4436
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [742 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `7.55%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.12% 45.57% -7.56%
+ Complexity 2974 2697 -277
============================================
Files 774 778 +4
Lines 19434 19445 +11
Branches 1916 1912 -4
============================================
- Hits 10325 8862 -1463
- Misses 8250 9816 +1566
+ Partials 859 767 -92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [88 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `18.42%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 52.79% 34.37% -18.43%
+ Complexity 2942 1926 -1016
=============================================
Files 1409 760 -649
Lines 30601 18983 -11618
Branches 3404 1880 -1524
=============================================
- Hits 16156 6525 -9631
+ Misses 13641 11949 -1692
+ Partials 804 509 -295
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1077 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `12.50%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.25% 40.74% -12.51%
+ Complexity 2981 2226 -755
=============================================
Files 774 771 -3
Lines 19425 19385 -40
Branches 1916 1903 -13
=============================================
- Hits 10344 7899 -2445
- Misses 8222 10886 +2664
+ Partials 859 600 -259
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [197 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `53.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 0.00% -53.26%
============================================
Files 774 149 -625
Lines 19425 3778 -15647
Branches 1916 454 -1462
============================================
- Hits 10344 0 -10344
+ Misses 8222 3778 -4444
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [741 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.12% 53.10% -0.03%
- Complexity 2974 2987 +13
============================================
Files 774 779 +5
Lines 19434 19499 +65
Branches 1916 1914 -2
============================================
+ Hits 10325 10355 +30
- Misses 8250 8283 +33
- Partials 859 861 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `52.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 52.79% 0.00% -52.80%
============================================
Files 1409 164 -1245
Lines 30601 4066 -26535
Branches 3404 481 -2923
============================================
- Hits 16156 0 -16156
+ Misses 13641 4066 -9575
+ Partials 804 0 -804
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#discussion_r451960604
##########
File path: oap-server/server-telemetry/telemetry-api/src/main/java/org/apache/skywalking/oap/server/telemetry/api/MetricsCreator.java
##########
@@ -42,4 +46,30 @@
*/
HistogramMetrics createHistogramMetric(String name, String tips, MetricsTag.Keys tagKeys,
MetricsTag.Values tagValues, double... buckets);
+
+ /**
+ * Create a Health Check gauge.
+ */
+ default GaugeMetrics createHealthCheckerGauge(String name, MetricsTag.Keys tagKeys, MetricsTag.Values tagValues) {
Review comment:
If some modules want to provide more information or details about what's going on inside. the tags might be a more property place to show them up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `16.63%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.25% 36.61% -16.64%
+ Complexity 2981 2020 -961
=============================================
Files 774 751 -23
Lines 19425 18842 -583
Branches 1916 1860 -56
=============================================
- Hits 10344 6899 -3445
- Misses 8222 11390 +3168
+ Partials 859 553 -306
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [248 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `3.03%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.12% 50.09% -3.04%
+ Complexity 2974 2885 -89
============================================
Files 774 778 +4
Lines 19434 19481 +47
Branches 1916 1913 -3
============================================
- Hits 10325 9759 -566
- Misses 8250 8890 +640
+ Partials 859 832 -27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [40 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 156 -1254
Lines 30607 3869 -26738
Branches 3404 452 -2952
============================================
- Hits 16267 0 -16267
+ Misses 13538 3869 -9669
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1377 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `11.75%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.25% 41.49% -11.76%
+ Complexity 2981 2271 -710
=============================================
Files 774 771 -3
Lines 19425 19385 -40
Branches 1916 1903 -13
=============================================
- Hits 10344 8044 -2300
- Misses 8222 10739 +2517
+ Partials 859 602 -257
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [184 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `17.22%`.
> The diff coverage is `15.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 35.92% -17.23%
+ Complexity 2974 2061 -913
=============================================
Files 1410 771 -639
Lines 30607 19361 -11246
Branches 3404 1898 -1506
=============================================
- Hits 16267 6956 -9311
+ Misses 13538 11874 -1664
+ Partials 802 531 -271
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `43.66% <0.00%> (-6.34%)` | `11.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `10.41% <0.00%> (-84.59%)` | `3.00 <0.00> (-6.00)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1063 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `53.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.12% 0.00% -53.13%
============================================
Files 773 162 -611
Lines 19430 3962 -15468
Branches 1916 466 -1450
============================================
- Hits 10323 0 -10323
+ Misses 8248 3962 -4286
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [730 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 157 -1253
Lines 30607 3930 -26677
Branches 3404 462 -2942
============================================
- Hits 16267 0 -16267
+ Misses 13538 3930 -9608
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1375 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...988c3fe](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `53.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 0.00% -53.26%
============================================
Files 774 156 -618
Lines 19425 3897 -15528
Branches 1916 459 -1457
============================================
- Hits 10344 0 -10344
+ Misses 8222 3897 -4325
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [739 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#discussion_r451959802
##########
File path: docs/en/setup/backend/backend-health-check.md
##########
@@ -0,0 +1,62 @@
+# Health Check
+
+Health check intends to provide a unique approach to check the healthy status of OAP server. It includes the health status
+of modules, GraphQL and gRPC services readiness.
+
+## Health Checker Module.
+
+Health Checker module could solute how to observe the health status of modules. We can active it by below:
+```yaml
+health-checker:
+ selector: ${SW_HEALTH_CHECKER:default}
+ default:
+ checkIntervalSeconds: ${SW_HEALTH_CHECKER_INTERVAL_SECONDS:5}
+```
+Notice, we should enable `prometheus` telemetry at the same time.
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 160 -1250
Lines 30607 3939 -26668
Branches 3404 463 -2941
============================================
- Hits 16267 0 -16267
+ Misses 13538 3939 -9599
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1376 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **increase** coverage by `53.01%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
+ Coverage 0.00% 53.01% +53.01%
- Complexity 0 2979 +2979
=============================================
Files 164 777 +613
Lines 4066 19505 +15439
Branches 481 1918 +1437
=============================================
+ Hits 0 10341 +10341
- Misses 4066 8305 +4239
- Partials 0 859 +859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (ø)` | `4.00 <0.00> (?)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (ø)` | `10.00 <2.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (ø)` | `13.00 <2.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [748 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `15.37%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.25% 37.87% -15.38%
+ Complexity 2981 2109 -872
=============================================
Files 774 767 -7
Lines 19425 19256 -169
Branches 1916 1894 -22
=============================================
- Hits 10344 7294 -3050
- Misses 8222 11394 +3172
+ Partials 859 568 -291
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [227 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `22.71%`.
> The diff coverage is `29.23%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 52.79% 30.07% -22.72%
+ Complexity 2942 1727 -1215
=============================================
Files 1409 758 -651
Lines 30601 18952 -11649
Branches 3404 1866 -1538
=============================================
- Hits 16156 5700 -10456
+ Misses 13641 12803 -838
+ Partials 804 449 -355
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `0.00% <ø> (-58.34%)` | `0.00 <0.00> (-4.00)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1090 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `9.95%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 43.19% -9.96%
+ Complexity 2974 2344 -630
============================================
Files 1410 775 -635
Lines 30607 19494 -11113
Branches 3404 1918 -1486
============================================
- Hits 16267 8421 -7846
+ Misses 13538 10452 -3086
+ Partials 802 621 -181
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1035 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 161 -1249
Lines 30607 4002 -26605
Branches 3404 474 -2930
============================================
- Hits 16267 0 -16267
+ Misses 13538 4002 -9536
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1375 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 167 -1243
Lines 30607 4063 -26544
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4063 -9475
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 165 -1245
Lines 30607 4057 -26550
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4057 -9481
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1373 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 152 -1258
Lines 30607 3812 -26795
Branches 3404 448 -2956
============================================
- Hits 16267 0 -16267
+ Misses 13538 3812 -9726
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `16.00%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 37.13% -16.01%
+ Complexity 2974 2123 -851
=============================================
Files 1410 774 -636
Lines 30607 19416 -11191
Branches 3404 1916 -1488
=============================================
- Hits 16267 7211 -9056
+ Misses 13538 11657 -1881
+ Partials 802 548 -254
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1053 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `49.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 49.24% 0.00% -49.25%
============================================
Files 773 149 -624
Lines 19394 3773 -15621
Branches 1915 447 -1468
============================================
- Hits 9551 0 -9551
+ Misses 9024 3773 -5251
+ Partials 819 0 -819
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [740 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `18.12%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.12% 35.00% -18.13%
+ Complexity 2974 2029 -945
=============================================
Files 774 775 +1
Lines 19434 19391 -43
Branches 1916 1898 -18
=============================================
- Hits 10325 6788 -3537
- Misses 8250 12076 +3826
+ Partials 859 527 -332
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [238 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `13.60%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 52.79% 39.19% -13.61%
+ Complexity 2942 2194 -748
=============================================
Files 1409 776 -633
Lines 30601 19413 -11188
Branches 3404 1916 -1488
=============================================
- Hits 16156 7609 -8547
+ Misses 13641 11230 -2411
+ Partials 804 574 -230
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1052 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `15.75%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.06% 37.31% -15.76%
+ Complexity 2968 2099 -869
=============================================
Files 1410 771 -639
Lines 30611 19289 -11322
Branches 3406 1904 -1502
=============================================
- Hits 16245 7198 -9047
+ Misses 13561 11531 -2030
+ Partials 805 560 -245
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1058 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 53.10% -0.04%
- Complexity 2974 2985 +11
============================================
Files 1410 777 -633
Lines 30607 19488 -11119
Branches 3404 1918 -1486
============================================
- Hits 16267 10350 -5917
+ Misses 13538 8278 -5260
- Partials 802 860 +58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [976 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...988c3fe](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `16.26%`.
> The diff coverage is `15.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 36.88% -16.27%
+ Complexity 2974 2104 -870
=============================================
Files 1410 771 -639
Lines 30607 19361 -11246
Branches 3404 1898 -1506
=============================================
- Hits 16267 7141 -9126
+ Misses 13538 11673 -1865
+ Partials 802 547 -255
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `43.66% <0.00%> (-6.34%)` | `11.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `10.41% <0.00%> (-84.59%)` | `3.00 <0.00> (-6.00)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1059 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **increase** coverage by `0.31%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 52.79% 53.10% +0.31%
- Complexity 2942 2985 +43
============================================
Files 1409 777 -632
Lines 30601 19488 -11113
Branches 3404 1918 -1486
============================================
- Hits 16156 10350 -5806
+ Misses 13641 8278 -5363
- Partials 804 860 +56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [982 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...14a22df](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 156 -1254
Lines 30607 3908 -26699
Branches 3404 466 -2938
============================================
- Hits 16267 0 -16267
+ Misses 13538 3908 -9630
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1377 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `53.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 0.00% -53.07%
============================================
Files 1410 159 -1251
Lines 30611 3990 -26621
Branches 3406 474 -2932
============================================
- Hits 16245 0 -16245
+ Misses 13561 3990 -9571
+ Partials 805 0 -805
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1376 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 167 -1243
Lines 30607 4063 -26544
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4063 -9475
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `17.32%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.12% 35.80% -17.33%
+ Complexity 2974 2063 -911
=============================================
Files 774 775 +1
Lines 19434 19400 -34
Branches 1916 1911 -5
=============================================
- Hits 10325 6946 -3379
- Misses 8250 11925 +3675
+ Partials 859 529 -330
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [219 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `23.01%`.
> The diff coverage is `29.23%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.25% 30.23% -23.02%
+ Complexity 2981 1720 -1261
=============================================
Files 774 750 -24
Lines 19425 18791 -634
Branches 1916 1857 -59
=============================================
- Hits 10344 5682 -4662
- Misses 8222 12660 +4438
+ Partials 859 449 -410
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `0.00% <ø> (-58.34%)` | `0.00 <0.00> (-4.00)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [303 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **increase** coverage by `0.31%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 52.79% 53.10% +0.31%
- Complexity 2942 2985 +43
============================================
Files 1409 777 -632
Lines 30601 19488 -11113
Branches 3404 1918 -1486
============================================
- Hits 16156 10350 -5806
+ Misses 13641 8278 -5363
- Partials 804 860 +56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [982 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `10.94%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.25% 42.30% -10.95%
+ Complexity 2981 2305 -676
=============================================
Files 774 771 -3
Lines 19425 19388 -37
Branches 1916 1903 -13
=============================================
- Hits 10344 8202 -2142
- Misses 8222 10582 +2360
+ Partials 859 604 -255
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [166 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `26.38%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 52.95% -0.30%
+ Complexity 2981 2974 -7
============================================
Files 774 1417 +643
Lines 19425 30681 +11256
Branches 1916 3407 +1491
============================================
+ Hits 10344 16246 +5902
- Misses 8222 13631 +5409
+ Partials 859 804 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/query/graphql/GraphQLQueryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL0dyYXBoUUxRdWVyeVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/query/graphql/resolver/HealthQuery.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL0hlYWx0aFF1ZXJ5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `24.00% <0.00%> (-2.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [977 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `0.23%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.25% 53.01% -0.24%
+ Complexity 2981 2978 -3
============================================
Files 774 779 +5
Lines 19425 19494 +69
Branches 1916 1918 +2
============================================
- Hits 10344 10334 -10
- Misses 8222 8304 +82
+ Partials 859 856 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `18.59%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.06% 34.47% -18.60%
+ Complexity 2968 1916 -1052
=============================================
Files 1410 754 -656
Lines 30611 18860 -11751
Branches 3406 1855 -1551
=============================================
- Hits 16245 6502 -9743
+ Misses 13561 11849 -1712
+ Partials 805 509 -296
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1077 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#discussion_r451961881
##########
File path: oap-server/server-telemetry/telemetry-api/src/main/java/org/apache/skywalking/oap/server/telemetry/api/MetricsCreator.java
##########
@@ -42,4 +46,30 @@
*/
HistogramMetrics createHistogramMetric(String name, String tips, MetricsTag.Keys tagKeys,
MetricsTag.Values tagValues, double... buckets);
+
+ /**
+ * Create a Health Check gauge.
+ */
+ default GaugeMetrics createHealthCheckerGauge(String name, MetricsTag.Keys tagKeys, MetricsTag.Values tagValues) {
Review comment:
Show this on the health check query?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `5.52%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 47.54% -5.53%
+ Complexity 2968 2689 -279
============================================
Files 1410 757 -653
Lines 30611 18998 -11613
Branches 3406 1876 -1530
============================================
- Hits 16245 9033 -7212
+ Misses 13561 9181 -4380
+ Partials 805 784 -21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1005 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `0.44%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 52.79% 52.34% -0.45%
- Complexity 2942 2958 +16
============================================
Files 1409 776 -633
Lines 30601 19449 -11152
Branches 3404 1917 -1487
============================================
- Hits 16156 10181 -5975
+ Misses 13641 8416 -5225
- Partials 804 852 +48
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [984 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 165 -1245
Lines 30607 4105 -26502
Branches 3404 482 -2922
============================================
- Hits 16267 0 -16267
+ Misses 13538 4105 -9433
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `19.53%`.
> The diff coverage is `29.23%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 52.79% 33.25% -19.54%
+ Complexity 2942 1876 -1066
=============================================
Files 1409 758 -651
Lines 30601 18952 -11649
Branches 3404 1866 -1538
=============================================
- Hits 16156 6303 -9853
+ Misses 13641 12140 -1501
+ Partials 804 509 -295
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `0.00% <ø> (-58.34%)` | `0.00 <0.00> (-4.00)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1078 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 167 -1243
Lines 30607 4063 -26544
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4063 -9475
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `14.65%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 38.49% -14.66%
+ Complexity 2974 2163 -811
=============================================
Files 1410 774 -636
Lines 30607 19416 -11191
Branches 3404 1916 -1488
=============================================
- Hits 16267 7474 -8793
+ Misses 13538 11361 -2177
+ Partials 802 581 -221
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1052 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 165 -1245
Lines 30607 4057 -26550
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4057 -9481
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1373 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 157 -1253
Lines 30607 3885 -26722
Branches 3404 456 -2948
============================================
- Hits 16267 0 -16267
+ Misses 13538 3885 -9653
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1376 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 52.94% -0.13%
+ Complexity 2968 2965 -3
============================================
Files 1410 777 -633
Lines 30611 19435 -11176
Branches 3406 1911 -1495
============================================
- Hits 16245 10289 -5956
+ Misses 13561 8293 -5268
- Partials 805 853 +48
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [977 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 164 -1246
Lines 30607 4018 -26589
Branches 3404 474 -2930
============================================
- Hits 16267 0 -16267
+ Misses 13538 4018 -9520
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `16.72%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.25% 36.52% -16.73%
+ Complexity 2981 2018 -963
=============================================
Files 774 751 -23
Lines 19425 18842 -583
Branches 1916 1860 -56
=============================================
- Hits 10344 6882 -3462
- Misses 8222 11407 +3185
+ Partials 859 553 -306
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [250 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `1.45%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 51.61% -1.46%
+ Complexity 2968 2909 -59
============================================
Files 1410 776 -634
Lines 30611 19441 -11170
Branches 3406 1917 -1489
============================================
- Hits 16245 10035 -6210
+ Misses 13561 8552 -5009
- Partials 805 854 +49
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [985 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 156 -1254
Lines 30607 3908 -26699
Branches 3404 466 -2938
============================================
- Hits 16267 0 -16267
+ Misses 13538 3908 -9630
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1377 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `20.44%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.12% 32.68% -20.45%
+ Complexity 2974 1886 -1088
=============================================
Files 774 773 -1
Lines 19434 19330 -104
Branches 1916 1890 -26
=============================================
- Hits 10325 6318 -4007
- Misses 8250 12520 +4270
+ Partials 859 492 -367
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [267 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `26.38%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 52.95% -0.12%
- Complexity 2968 2974 +6
============================================
Files 1410 1417 +7
Lines 30611 30681 +70
Branches 3406 3407 +1
============================================
+ Hits 16245 16246 +1
- Misses 13561 13631 +70
+ Partials 805 804 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/query/graphql/GraphQLQueryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL0dyYXBoUUxRdWVyeVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...alking/oap/query/graphql/resolver/HealthQuery.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL0hlYWx0aFF1ZXJ5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `24.00% <0.00%> (-1.00%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `9.39%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 43.67% -9.40%
+ Complexity 2968 2524 -444
============================================
Files 1410 757 -653
Lines 30611 18962 -11649
Branches 3406 1875 -1531
============================================
- Hits 16245 8281 -7964
+ Misses 13561 9956 -3605
+ Partials 805 725 -80
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1022 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 52.93% -0.14%
- Complexity 2968 2974 +6
============================================
Files 1410 779 -631
Lines 30611 19486 -11125
Branches 3406 1918 -1488
============================================
- Hits 16245 10314 -5931
+ Misses 13561 8314 -5247
- Partials 805 858 +53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [973 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `14.64%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 38.49% -14.65%
+ Complexity 2974 2164 -810
=============================================
Files 1410 774 -636
Lines 30607 19416 -11191
Branches 3404 1916 -1488
=============================================
- Hits 16267 7475 -8792
+ Misses 13538 11361 -2177
+ Partials 802 580 -222
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1052 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 158 -1252
Lines 30607 3939 -26668
Branches 3404 463 -2941
============================================
- Hits 16267 0 -16267
+ Misses 13538 3939 -9599
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1375 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...988c3fe](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/42c8cebbc1bb30b003db477b86ec8f7360a1e1aa&el=desc) will **decrease** coverage by `14.34%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 52.79% 38.44% -14.35%
+ Complexity 2942 2149 -793
=============================================
Files 1409 776 -633
Lines 30601 19413 -11188
Branches 3404 1916 -1488
=============================================
- Hits 16156 7464 -8692
+ Misses 13641 11377 -2264
+ Partials 804 572 -232
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1058 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [42c8ceb...8d394cf](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `1.39%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 51.67% -1.40%
+ Complexity 2968 2913 -55
============================================
Files 1410 776 -634
Lines 30611 19441 -11170
Branches 3406 1917 -1489
============================================
- Hits 16245 10046 -6199
+ Misses 13561 8540 -5021
- Partials 805 855 +50
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [984 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 149 -1261
Lines 30607 3778 -26829
Branches 3404 454 -2950
============================================
- Hits 16267 0 -16267
+ Misses 13538 3778 -9760
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...988c3fe](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `16.30%`.
> The diff coverage is `15.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 36.83% -16.31%
+ Complexity 2974 2105 -869
=============================================
Files 1410 773 -637
Lines 30607 19403 -11204
Branches 3404 1902 -1502
=============================================
- Hits 16267 7148 -9119
+ Misses 13538 11707 -1831
+ Partials 802 548 -254
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `43.66% <0.00%> (-6.34%)` | `11.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `10.41% <0.00%> (-84.59%)` | `3.00 <0.00> (-6.00)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1057 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 167 -1243
Lines 30607 4063 -26544
Branches 3404 475 -2929
============================================
- Hits 16267 0 -16267
+ Misses 13538 4063 -9475
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `1.59%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 51.47% -1.60%
+ Complexity 2968 2898 -70
============================================
Files 1410 776 -634
Lines 30611 19441 -11170
Branches 3406 1917 -1489
============================================
- Hits 16245 10008 -6237
+ Misses 13561 8581 -4980
- Partials 805 852 +47
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [987 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `53.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 0.00% -53.07%
============================================
Files 1410 158 -1252
Lines 30611 3920 -26691
Branches 3406 466 -2940
============================================
- Hits 16245 0 -16245
+ Misses 13561 3920 -9641
+ Partials 805 0 -805
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `12.37%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.14% 40.77% -12.38%
+ Complexity 2974 2259 -715
=============================================
Files 1410 774 -636
Lines 30607 19452 -11155
Branches 3404 1917 -1487
=============================================
- Hits 16267 7931 -8336
+ Misses 13538 10911 -2627
+ Partials 802 610 -192
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [1044 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `51.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 51.60% 0.00% -51.61%
============================================
Files 773 162 -611
Lines 19430 3962 -15468
Branches 1916 466 -1450
============================================
- Hits 10027 0 -10027
+ Misses 8554 3962 -4592
+ Partials 849 0 -849
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [730 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 168 -1242
Lines 30607 4115 -26492
Branches 3404 482 -2922
============================================
- Hits 16267 0 -16267
+ Misses 13538 4115 -9423
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3ebcf97759314545af060f2d56f9e30408bc83dc&el=desc) will **decrease** coverage by `15.47%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.25% 37.77% -15.48%
+ Complexity 2981 2109 -872
=============================================
Files 774 770 -4
Lines 19425 19310 -115
Branches 1916 1901 -15
=============================================
- Hits 10344 7294 -3050
- Misses 8222 11448 +3226
+ Partials 859 568 -291
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [224 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [3ebcf97...5f97e24](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#discussion_r451242194
##########
File path: oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/H2StorageProvider.java
##########
@@ -139,6 +146,7 @@ public void start() throws ServiceNotProvidedException, ModuleStartException {
} catch (StorageException e) {
throw new ModuleStartException(e.getMessage(), e);
}
+ healthChecker.setValue(1);
Review comment:
```suggestion
healthChecker.setValue(0);
```
##########
File path: oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/H2StorageProvider.java
##########
@@ -131,6 +135,9 @@ public void prepare() throws ServiceNotProvidedException, ModuleStartException {
@Override
public void start() throws ServiceNotProvidedException, ModuleStartException {
+ MetricsCreator metricCreator = getManager().find(TelemetryModule.NAME).provider().getService(MetricsCreator.class);
+ GaugeMetrics healthChecker = metricCreator.createHealthCheckerGauge("storage_h2", MetricsTag.EMPTY_KEY, MetricsTag.EMPTY_VALUE);
+ healthChecker.setValue(1);
Review comment:
> Why always `1`? According to your doc, 1 should mean unhealthy? I think you missed some codes.
This may be the initial status "unhealthy", and after the connection is established (line 142-145), the value should be set to `0`, so I reckon the line at 149 should be `healthChecker.setValue(0);`? @hanahmily
##########
File path: docs/en/setup/backend/backend-health-check.md
##########
@@ -0,0 +1,62 @@
+# Health Check
+
+Health check intends to provide a unique approach to check the healthy status of OAP server. It includes the health status
+of modules, GraphQL and gRPC services readiness.
+
+## Health Checker Module.
+
+Health Checker module could solute how to observe the health status of modules. We can active it by below:
+```yaml
+health-checker:
+ selector: ${SW_HEALTH_CHECKER:default}
+ default:
+ checkIntervalSeconds: ${SW_HEALTH_CHECKER_INTERVAL_SECONDS:5}
+```
+Notice, we should enable `prometheus` telemetry at the same time.
Review comment:
+1 "Any module should not depend on another module's implementation. "
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `49.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 49.26% 0.00% -49.27%
============================================
Files 771 149 -622
Lines 19388 3773 -15615
Branches 1915 447 -1468
============================================
- Hits 9551 0 -9551
+ Misses 9018 3773 -5245
+ Partials 819 0 -819
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [738 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `15.69%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.06% 37.37% -15.70%
+ Complexity 2968 2056 -912
=============================================
Files 1410 755 -655
Lines 30611 18889 -11722
Branches 3406 1871 -1535
=============================================
- Hits 16245 7059 -9186
+ Misses 13561 11273 -2288
+ Partials 805 557 -248
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1067 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 53.01% -0.14%
- Complexity 2974 2979 +5
============================================
Files 1410 777 -633
Lines 30607 19505 -11102
Branches 3404 1918 -1486
============================================
- Hits 16267 10341 -5926
+ Misses 13538 8305 -5233
- Partials 802 859 +57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [979 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 161 -1249
Lines 30607 4011 -26596
Branches 3404 477 -2927
============================================
- Hits 16267 0 -16267
+ Misses 13538 4011 -9527
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1375 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...aa94eb9](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `2.22%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.12% 50.90% -2.23%
+ Complexity 2974 2909 -65
============================================
Files 774 779 +5
Lines 19434 19485 +51
Branches 1916 1913 -3
============================================
- Hits 10325 9918 -407
- Misses 8250 8726 +476
+ Partials 859 841 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [35 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `7.46%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.12% 45.66% -7.47%
+ Complexity 2974 2697 -277
============================================
Files 774 777 +3
Lines 19434 19406 -28
Branches 1916 1911 -5
============================================
- Hits 10325 8862 -1463
- Misses 8250 9777 +1527
+ Partials 859 767 -92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-1.09%)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (-3.34%)` | `10.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (+3.52%)` | `13.00 <2.00> (+2.00)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [89 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **decrease** coverage by `51.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 51.60% 0.00% -51.61%
============================================
Files 773 155 -618
Lines 19430 3829 -15601
Branches 1916 448 -1468
============================================
- Hits 10027 0 -10027
+ Misses 8554 3829 -4725
+ Partials 849 0 -849
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [737 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f7ae055c7a03014452fc2db333438c6e349f2a&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 1410 162 -1248
Lines 30607 4007 -26600
Branches 3404 474 -2930
============================================
- Hits 16267 0 -16267
+ Misses 13538 4007 -9531
+ Partials 802 0 -802
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [e8f7ae0...eed2fa7](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `21.73%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
- Coverage 53.06% 31.33% -21.74%
+ Complexity 2968 1778 -1190
=============================================
Files 1410 756 -654
Lines 30611 18913 -11698
Branches 3406 1873 -1533
=============================================
- Hits 16245 5926 -10319
+ Misses 13561 12538 -1023
+ Partials 805 449 -356
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [1085 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 53.06% 53.24% +0.17%
- Complexity 2968 2984 +16
============================================
Files 1410 778 -632
Lines 30611 19439 -11172
Branches 3406 1911 -1495
============================================
- Hits 16245 10351 -5894
+ Misses 13561 8228 -5333
- Partials 805 860 +55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [975 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `2.52%`.
> The diff coverage is `28.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 50.54% -2.53%
+ Complexity 2968 2866 -102
============================================
Files 1410 776 -634
Lines 30611 19441 -11170
Branches 3406 1917 -1489
============================================
- Hits 16245 9826 -6419
+ Misses 13561 8771 -4790
- Partials 805 844 +39
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (-4.49%)` | `4.00 <0.00> (ø)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `24.13% <24.13%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.45% <100.00%> (+0.45%)` | `9.00 <1.00> (ø)` | |
| [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [990 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6ba9c7f81b41d80e306fb2b10a95309cdd3783cf&el=desc) will **decrease** coverage by `53.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 53.06% 0.00% -53.07%
============================================
Files 1410 160 -1250
Lines 30611 3995 -26616
Branches 3406 474 -2932
============================================
- Hits 16245 0 -16245
+ Misses 13561 3995 -9566
+ Partials 805 0 -805
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1375 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [6ba9c7f...62e9410](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report
> Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c8fc457e825b8c6a047b44b5da8704ed08a56e45&el=desc) will **increase** coverage by `53.01%`.
> The diff coverage is `34.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5046 +/- ##
=============================================
+ Coverage 0.00% 53.01% +53.01%
- Complexity 0 2979 +2979
=============================================
Files 161 777 +616
Lines 4049 19505 +15456
Branches 481 1918 +1437
=============================================
+ Hits 0 10341 +10341
- Misses 4049 8305 +4256
- Partials 0 859 +859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/health/checker/provider/HealthQueryService.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhRdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../oap/server/telemetry/none/MetricsCreatorNoop.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ3JlYXRvck5vb3AuamF2YQ==) | `53.84% <0.00%> (ø)` | `4.00 <0.00> (?)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...lemetry/prometheus/PrometheusMetricsCollector.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `7.14% <7.14%> (ø)` | `1.00 <1.00> (?)` | |
| [...health/checker/provider/HealthCheckerProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyUHJvdmlkZXIuamF2YQ==) | `21.87% <21.87%> (ø)` | `4.00 <4.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `91.66% <75.00%> (ø)` | `10.00 <2.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `53.52% <77.77%> (ø)` | `13.00 <2.00> (?)` | |
| [...r/health/checker/provider/HealthCheckerConfig.java](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9wcm92aWRlci9IZWFsdGhDaGVja2VyQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [749 more](https://codecov.io/gh/apache/skywalking/pull/5046/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=footer). Last update [c8fc457...8df7746](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org