You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/06/18 23:04:57 UTC
Review Request 22758: Added flags::parse() overload for RateLimits protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22758/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1501
https://issues.apache.org/jira/browse/MESOS-1501
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/common/parse.hpp 5b12e38852a7a033e20da084df6bae90e3cb9e73
src/common/type_utils.hpp 27ea4d2d73c098c0fb535d9d2838b5a283c35656
src/master/flags.hpp 47bb0dc04504fc847cc02fa97eb0d045a8835c9e
src/master/master.cpp 888657dd4bc50085882382908e3c48ccb857c621
src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9
Diff: https://reviews.apache.org/r/22758/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 22758: Added flags::parse() overload for RateLimits
protobuf.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22758/
-----------------------------------------------------------
(Updated June 22, 2014, 9:01 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-1501
https://issues.apache.org/jira/browse/MESOS-1501
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/common/parse.hpp 5b12e38852a7a033e20da084df6bae90e3cb9e73
src/common/type_utils.hpp 27ea4d2d73c098c0fb535d9d2838b5a283c35656
src/master/flags.hpp 47bb0dc04504fc847cc02fa97eb0d045a8835c9e
src/master/master.cpp 00152f5b889a2d10255835779b66c9ed26df9a2b
src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9
Diff: https://reviews.apache.org/r/22758/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 22758: Added flags::parse() overload for RateLimits
protobuf.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22758/#review46189
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22639, 22740, 22758]
All tests passed.
- Mesos ReviewBot
On June 18, 2014, 9:04 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22758/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 9:04 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1501
> https://issues.apache.org/jira/browse/MESOS-1501
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/parse.hpp 5b12e38852a7a033e20da084df6bae90e3cb9e73
> src/common/type_utils.hpp 27ea4d2d73c098c0fb535d9d2838b5a283c35656
> src/master/flags.hpp 47bb0dc04504fc847cc02fa97eb0d045a8835c9e
> src/master/master.cpp 888657dd4bc50085882382908e3c48ccb857c621
> src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9
>
> Diff: https://reviews.apache.org/r/22758/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 22758: Added flags::parse() overload for RateLimits
protobuf.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22758/#review46148
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 18, 2014, 9:04 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22758/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 9:04 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1501
> https://issues.apache.org/jira/browse/MESOS-1501
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/parse.hpp 5b12e38852a7a033e20da084df6bae90e3cb9e73
> src/common/type_utils.hpp 27ea4d2d73c098c0fb535d9d2838b5a283c35656
> src/master/flags.hpp 47bb0dc04504fc847cc02fa97eb0d045a8835c9e
> src/master/master.cpp 888657dd4bc50085882382908e3c48ccb857c621
> src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9
>
> Diff: https://reviews.apache.org/r/22758/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>