You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "waynexia (via GitHub)" <gi...@apache.org> on 2023/04/10 11:55:39 UTC

[GitHub] [arrow-datafusion] waynexia commented on pull request #5811: Scalar arithmetic should return error when overflows.

waynexia commented on PR #5811:
URL: https://github.com/apache/arrow-datafusion/pull/5811#issuecomment-1501732283

   Test error:
   
   > ---- scalar::tests::scalar_sub_trait_int64_overflow_test stdout ----
   thread 'scalar::tests::scalar_sub_trait_int64_overflow_test' panicked at 'attempt to subtract with overflow', datafusion/common/src/scalar.rs:1934:9
   
   It looks like the methods called in unit tests should also be `*_checked`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org