[GitHub] [iceberg] rdblue commented on a diff in pull request #2639: Parquet: Support parquet modular encryption

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #2639:
URL: https://github.com/apache/iceberg/pull/2639#discussion_r1155354743


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -639,6 +672,16 @@ public DataWriteBuilder withKeyMetadata(EncryptionKeyMetadata metadata) {
       return this;
     }
 
+    public DataWriteBuilder withFileEncryptionKey(ByteBuffer fileEncryptionKey) {
+      appenderBuilder.withFileEncryptionKey(fileEncryptionKey);
+      return this;
+    }
+
+    public DataWriteBuilder withAadPrefix(ByteBuffer aadPrefix) {

Review Comment:
   This name was not updated to AAD. We need to have consistent method names throughout, so please double check.



##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -740,6 +783,16 @@ public DeleteWriteBuilder withKeyMetadata(EncryptionKeyMetadata metadata) {
       return this;
     }
 
+    public DeleteWriteBuilder withFileEncryptionKey(ByteBuffer fileEncryptionKey) {
+      appenderBuilder.withFileEncryptionKey(fileEncryptionKey);
+      return this;
+    }
+
+    public DeleteWriteBuilder withAadPrefix(ByteBuffer aadPrefix) {

Review Comment:
   Same here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org