You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/23 18:30:36 UTC

[GitHub] [pulsar] michaeljmarshall commented on pull request #12113: Remove unused method: asyncCloseCursorLedger

michaeljmarshall commented on pull request #12113:
URL: https://github.com/apache/pulsar/pull/12113#issuecomment-926055744


   I agree that it seems appropriate to use `asyncCloseCursorLedger` to replace the code in the `operationComplete` method. My only question is if failing the callback is the right behavior. It seems correct to me, but I'd like to verify with someone more familiar with this part of the code base.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org