You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/23 15:04:14 UTC

[GitHub] [netbeans] matthiasblaesing commented on issue #1963: [NETBEANS-1603] I can't see MySQL stored procedures in NetBeans

matthiasblaesing commented on issue #1963: [NETBEANS-1603] I can't see MySQL stored procedures in NetBeans
URL: https://github.com/apache/netbeans/pull/1963#issuecomment-590077638
 
 
   @sbrbot my request boils down to this: It is easier to merge a PR if it does not raise discussions. @junichi11 and I most probably don't agree on everything, but if your PR does not touch areas it does not need to touch it will get approval easier. In this case changing the choise of words or removing NO18N markers does nothing to help the PR.
   
   The same goes for the change to the Oracle statements. It is well possible, that the DB treats the statement case sensitive, then your change introduces a regression. The point is: I did not test on Oracle DB and my reading is, that you did neither, so it would be better to keep the case as-is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists