[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7577: implement string_to_array

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #7577:
URL: https://github.com/apache/arrow-datafusion/pull/7577#discussion_r1327947535


##########
datafusion/sqllogictest/test_files/functions.slt:
##########
@@ -723,6 +723,36 @@ SELECT split_part(arrow_cast('foo_bar', 'Dictionary(Int32, Utf8)'), '_', 2)
 ----
 bar
 
+query ?

Review Comment:
   Can you also please add a test that works on tables (not just scalars).
   
   Something like 
   
   ```sql
   create table strings(value varchar) as values ('foo'), ('abc def'), ('abc'), NULL;
   select string_to-array(value) from values
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org