[GitHub] [incubator-superset] villebro commented on a change in pull request #9013: set SUPERSET_WEBSERVER timeout for urllib opener

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9013: set SUPERSET_WEBSERVER timeout for urllib opener
URL: https://github.com/apache/incubator-superset/pull/9013#discussion_r370813660
 
 

 ##########
 File path: superset/tasks/schedules.py
 ##########
 @@ -258,7 +258,7 @@ def _get_slice_data(schedule):
 
     opener = urllib.request.build_opener()
     opener.addheaders.append(("Cookie", f"session={cookies['session']}"))
-    response = opener.open(slice_url)
+    response = opener.open(slice_url, timeout=config["SUPERSET_WEBSERVER_TIMEOUT"])
 
 Review comment:
   Does this solve a problem that you're facing? Based on the documentation, leaving timeout unset never triggers a timeout: https://docs.python.org/3/library/socket.html?highlight=socket#socket.getdefaulttimeout This leaves me to conclude that the timeout is thrown once the webserver's own timeout is reached, rendering this timeout setting obsolete. Is this not the case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org