You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/08 17:52:44 UTC

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #27548: Fix bug in various hooks that causes SQL run without a handler to always return None.

ephraimbuddy commented on code in PR #27548:
URL: https://github.com/apache/airflow/pull/27548#discussion_r1016949338


##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -273,7 +273,7 @@ def run(
             if not self.get_autocommit(conn):
                 conn.commit()
 
-        if handler is None:
+        if handler is not None:

Review Comment:
   This looks odd IMO. cc @potiuk 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org