You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by vensant <gi...@git.apache.org> on 2016/09/15 15:55:31 UTC
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
GitHub user vensant opened a pull request:
https://github.com/apache/zeppelin/pull/1430
[ZEPPELIN-868] Notebook import fails when notebook is large
### What is this PR for?
A bug fix: Added validation in the note import dialog box to check for the uploaded json file size and throw error report if the file size exceeds 1MB, as the websocket frame is not able to send json file of size over 1MB.
### What type of PR is it?
Bug Fix
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-868
### How should this be tested?
1. Deploy Zeppelin and click on 'Import Note' in the Welcome to Zeppelin page.
2. Click 'Choose a JSON here' and upload a json file whose file size is over 1MB
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vensant/zeppelin ZEPPELIN-868
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1430.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1430
----
commit 276b676f4ad198f9e95bf9c639ac0b37c8349d2f
Author: vensant <ve...@imaginea.com>
Date: 2016-09-15T14:38:47Z
Added validation in the note import dialog box to check for the uploaded json file size as the websocket frame is not able to send file of size over 1MB
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1430
@vensant it would be better to properly catch the error in the back-end and send it to the front
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by vensant <gi...@git.apache.org>.
Github user vensant commented on the issue:
https://github.com/apache/zeppelin/pull/1430
Closed and reopened the pull request in order to re-trigger the Travis CI build. Build failed due to test failures Again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1430
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
Posted by vensant <gi...@git.apache.org>.
GitHub user vensant reopened a pull request:
https://github.com/apache/zeppelin/pull/1430
[ZEPPELIN-868] Notebook import fails when notebook is large
### What is this PR for?
A bug fix: Added validation in the note import dialog box to check for the uploaded json file size and throw error report if the file size exceeds 1MB, as the websocket frame is not able to send json file of size over 1MB.
### What type of PR is it?
Bug Fix
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-868
### How should this be tested?
1. Deploy Zeppelin and click on 'Import Note' in the Welcome to Zeppelin page.
2. Click 'Choose a JSON here' and upload a json file whose file size is over 1MB
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vensant/zeppelin ZEPPELIN-868
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1430.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1430
----
commit 213181c02d5029b143bb55cbae32408d456e3cf9
Author: vensant <ve...@imaginea.com>
Date: 2016-09-15T14:38:47Z
Added validation in the note import dialog box to check for the uploaded json file size as the websocket frame is not able to send file of size over 1MB
commit c2710193d57274aba9d7e34272d6b29edd81ccea
Author: vensant <ve...@imaginea.com>
Date: 2016-09-16T06:06:30Z
Rectified the errors due to grunt build no color failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by vensant <gi...@git.apache.org>.
Github user vensant commented on the issue:
https://github.com/apache/zeppelin/pull/1430
Closed and reopened the pull request in order to re-trigger the Travis CI build. Build failed due to test failures
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
Posted by vensant <gi...@git.apache.org>.
Github user vensant closed the pull request at:
https://github.com/apache/zeppelin/pull/1430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by vensant <gi...@git.apache.org>.
Github user vensant commented on the issue:
https://github.com/apache/zeppelin/pull/1430
Reopening the pull request as the build failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
Posted by vensant <gi...@git.apache.org>.
GitHub user vensant reopened a pull request:
https://github.com/apache/zeppelin/pull/1430
[ZEPPELIN-868] Notebook import fails when notebook is large
### What is this PR for?
A bug fix: Added validation in the note import dialog box to check for the uploaded json file size and throw error report if the file size exceeds 1MB, as the websocket frame is not able to send json file of size over 1MB.
### What type of PR is it?
Bug Fix
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-868
### How should this be tested?
1. Deploy Zeppelin and click on 'Import Note' in the Welcome to Zeppelin page.
2. Click 'Choose a JSON here' and upload a json file whose file size is over 1MB
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vensant/zeppelin ZEPPELIN-868
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1430.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1430
----
commit 213181c02d5029b143bb55cbae32408d456e3cf9
Author: vensant <ve...@imaginea.com>
Date: 2016-09-15T14:38:47Z
Added validation in the note import dialog box to check for the uploaded json file size as the websocket frame is not able to send file of size over 1MB
commit c2710193d57274aba9d7e34272d6b29edd81ccea
Author: vensant <ve...@imaginea.com>
Date: 2016-09-16T06:06:30Z
Rectified the errors due to grunt build no color failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by vensant <gi...@git.apache.org>.
Github user vensant commented on the issue:
https://github.com/apache/zeppelin/pull/1430
Closed and reopened the pull request in order to re-trigger the Travis CI build. Build failed due to test failures Again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/1430
@vensant Nice update. Can you also make this limit on UI dynamic by reading the size configured in zeppelin-site.xml or zeppelin-env.sh. Look for`zeppelin.websocket.max.text.message.size` or `ZEPPELIN_WEBSOCKET_MAX_TEXT_MESSAGE_SIZE` in the respective files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by vensant <gi...@git.apache.org>.
Github user vensant commented on the issue:
https://github.com/apache/zeppelin/pull/1430
Reopening the pull request as the build failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
Posted by vensant <gi...@git.apache.org>.
GitHub user vensant reopened a pull request:
https://github.com/apache/zeppelin/pull/1430
[ZEPPELIN-868] Notebook import fails when notebook is large
### What is this PR for?
A bug fix: Added validation in the note import dialog box to check for the uploaded json file size and throw error report if the file size exceeds 1MB, as the websocket frame is not able to send json file of size over 1MB.
### What type of PR is it?
Bug Fix
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-868
### How should this be tested?
1. Deploy Zeppelin and click on 'Import Note' in the Welcome to Zeppelin page.
2. Click 'Choose a JSON here' and upload a json file whose file size is over 1MB
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vensant/zeppelin ZEPPELIN-868
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1430.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1430
----
commit 213181c02d5029b143bb55cbae32408d456e3cf9
Author: vensant <ve...@imaginea.com>
Date: 2016-09-15T14:38:47Z
Added validation in the note import dialog box to check for the uploaded json file size as the websocket frame is not able to send file of size over 1MB
commit c2710193d57274aba9d7e34272d6b29edd81ccea
Author: vensant <ve...@imaginea.com>
Date: 2016-09-16T06:06:30Z
Rectified the errors due to grunt build no color failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by vensant <gi...@git.apache.org>.
Github user vensant commented on the issue:
https://github.com/apache/zeppelin/pull/1430
@corneadoug once the file is uploaded, it tries to process the json but because the file exceeds the max limit it tries to close the websocket event. so I am trying to broadcast and catch the error code and setting the error message in html.
We can also implement it the way you have suggested by stopping the flow of execution by comparing the size with the max size in the client side itself
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
Posted by vensant <gi...@git.apache.org>.
Github user vensant closed the pull request at:
https://github.com/apache/zeppelin/pull/1430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
Posted by vensant <gi...@git.apache.org>.
Github user vensant closed the pull request at:
https://github.com/apache/zeppelin/pull/1430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
Posted by vensant <gi...@git.apache.org>.
GitHub user vensant reopened a pull request:
https://github.com/apache/zeppelin/pull/1430
[ZEPPELIN-868] Notebook import fails when notebook is large
### What is this PR for?
A bug fix: Added validation in the note import dialog box to check for the uploaded json file size and throw error report if the file size exceeds 1MB, as the websocket frame is not able to send json file of size over 1MB.
### What type of PR is it?
Bug Fix
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-868
### How should this be tested?
1. Deploy Zeppelin and click on 'Import Note' in the Welcome to Zeppelin page.
2. Click 'Choose a JSON here' and upload a json file whose file size is over 1MB
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vensant/zeppelin ZEPPELIN-868
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1430.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1430
----
commit 5a1f6ae88349644be0d2e2b6b1ad63607fe984ed
Author: vensant <ve...@imaginea.com>
Date: 2016-09-15T14:38:47Z
Added validation in the note import dialog box to check for the uploaded json file size as the websocket frame is not able to send file of size over 1MB
commit 2c5ba4a35ee91bd41b28c00dafc675cde3a5940c
Author: vensant <ve...@imaginea.com>
Date: 2016-09-16T06:06:30Z
Rectified the errors due to grunt build no color failure
commit 55c934973120701e27160eb0bb1812496ed9b82c
Author: vensant <ve...@imaginea.com>
Date: 2016-09-22T06:29:58Z
made changes for reading the max limit from the configuration list and dynamically showing it in UI
commit 23c05ed911da25f612cd9d01c45960171bd85f07
Author: vensant <ve...@imaginea.com>
Date: 2016-09-27T06:37:12Z
client level validation added for import file size check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by vensant <gi...@git.apache.org>.
Github user vensant commented on the issue:
https://github.com/apache/zeppelin/pull/1430
@corneadoug instead of validating the error in server side, I have just changed the code in the client side, that compares the input file size with the maximum limit of file size that is already set in the server side as a property.
It is simpler than the one that catches the exception that is thrown in the server side. Please check with the code change and let me know.
Thanks,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
Posted by vensant <gi...@git.apache.org>.
Github user vensant closed the pull request at:
https://github.com/apache/zeppelin/pull/1430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1430
CI is green LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
Posted by vensant <gi...@git.apache.org>.
GitHub user vensant reopened a pull request:
https://github.com/apache/zeppelin/pull/1430
[ZEPPELIN-868] Notebook import fails when notebook is large
### What is this PR for?
A bug fix: Added validation in the note import dialog box to check for the uploaded json file size and throw error report if the file size exceeds 1MB, as the websocket frame is not able to send json file of size over 1MB.
### What type of PR is it?
Bug Fix
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-868
### How should this be tested?
1. Deploy Zeppelin and click on 'Import Note' in the Welcome to Zeppelin page.
2. Click 'Choose a JSON here' and upload a json file whose file size is over 1MB
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vensant/zeppelin ZEPPELIN-868
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1430.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1430
----
commit 77a0cc1cd1ae43f53d2d20898e1a0e65e8d7be29
Author: vensant <ve...@imaginea.com>
Date: 2016-09-15T14:38:47Z
Added validation in the note import dialog box to check for the uploaded json file size as the websocket frame is not able to send file of size over 1MB
commit e48aac6d5a94ba2e21c1a3fd3f78bea68cb004e3
Author: vensant <ve...@imaginea.com>
Date: 2016-09-16T06:06:30Z
Rectified the errors due to grunt build no color failure
commit 5dcdcfe85506c42baa3224b87fc4f027fb448467
Author: vensant <ve...@imaginea.com>
Date: 2016-09-22T06:29:58Z
made changes for reading the max limit from the configuration list and dynamically showing it in UI
commit c65f2c7adf4f526506480f8aa5edcc03fb6f7783
Author: vensant <ve...@imaginea.com>
Date: 2016-09-27T06:37:12Z
client level validation added for import file size check
commit bd1acc088f1b9cf60f0ebac21b4a9289adb82728
Author: vensant <ve...@imaginea.com>
Date: 2016-09-29T06:12:23Z
fixed the review comments on the pull request
commit 29ad4cee20334bf3fa0cdd37211ca412a1e638ec
Author: vensant <ve...@imaginea.com>
Date: 2016-09-29T07:27:43Z
committed the code which missed during rebase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1430
@vensant I don't really get why the error is being triggered this way.
We are talking about the file size, but we show the error when the Websocket connection is cut.
One example is to go on that import window, and to stop Zeppelin-server
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1430: [ZEPPELIN-868] Notebook import fails when noteb...
Posted by vensant <gi...@git.apache.org>.
Github user vensant closed the pull request at:
https://github.com/apache/zeppelin/pull/1430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...
Posted by vensant <gi...@git.apache.org>.
Github user vensant commented on the issue:
https://github.com/apache/zeppelin/pull/1430
@r-kamath thanks for the inputs!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---