You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2014/05/01 13:05:00 UTC
svn commit: r1591602 - in /commons/proper/collections/trunk/src: changes/
main/java/org/apache/commons/collections4/
Author: tn
Date: Thu May 1 11:04:59 2014
New Revision: 1591602
URL: http://svn.apache.org/r1591602
Log:
[COLLECTIONS-519] Constructors of *Utils classes are now protected to allow sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
Modified:
commons/proper/collections/trunk/src/changes/changes.xml
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
Modified: commons/proper/collections/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/changes/changes.xml?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/changes/changes.xml (original)
+++ commons/proper/collections/trunk/src/changes/changes.xml Thu May 1 11:04:59 2014
@@ -22,6 +22,9 @@
<body>
<release version="4.1" date="TBD" description="">
+ <action issue="COLLECTIONS-519" dev="tn" type="fix" due-to="Radoslav Paskalev, Daniel Feist">
+ Constructors of *Utils classes are now protected to allow sub-classing.
+ </action>
<action issue="COLLECTIONS-512" dev="tn" type="fix" due-to="Cyrille Artho">
"TransformingComparator" did not comply with the contract of Object#equals.
</action>
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java Thu May 1 11:04:59 2014
@@ -56,7 +56,7 @@ public class ClosureUtils {
/**
* This class is not normally instantiated.
*/
- private ClosureUtils() {}
+ protected ClosureUtils() {}
/**
* Gets a Closure that always throws an exception.
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java Thu May 1 11:04:59 2014
@@ -185,7 +185,7 @@ public class CollectionUtils {
/**
* <code>CollectionUtils</code> should not normally be instantiated.
*/
- private CollectionUtils() {}
+ protected CollectionUtils() {}
/**
* Returns the immutable EMPTY_COLLECTION with generic type safety.
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java Thu May 1 11:04:59 2014
@@ -43,7 +43,7 @@ public class ComparatorUtils {
/**
* ComparatorUtils should not normally be instantiated.
*/
- private ComparatorUtils() {}
+ protected ComparatorUtils() {}
/**
* Comparator for natural sort order.
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java Thu May 1 11:04:59 2014
@@ -34,7 +34,7 @@ public class EnumerationUtils {
/**
* EnumerationUtils is not normally instantiated.
*/
- private EnumerationUtils() {}
+ protected EnumerationUtils() {}
/**
* Creates a list based on an enumeration.
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java Thu May 1 11:04:59 2014
@@ -41,7 +41,7 @@ public class FactoryUtils {
/**
* This class is not normally instantiated.
*/
- private FactoryUtils() {}
+ protected FactoryUtils() {}
/**
* Gets a Factory that always throws an exception.
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java Thu May 1 11:04:59 2014
@@ -119,7 +119,7 @@ public class IteratorUtils {
/**
* IteratorUtils is not normally instantiated.
*/
- private IteratorUtils() {}
+ protected IteratorUtils() {}
// Empty
//-----------------------------------------------------------------------
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java Thu May 1 11:04:59 2014
@@ -46,7 +46,7 @@ public class ListUtils {
/**
* <code>ListUtils</code> should not normally be instantiated.
*/
- private ListUtils() {}
+ protected ListUtils() {}
//-----------------------------------------------------------------------
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java Thu May 1 11:04:59 2014
@@ -92,7 +92,7 @@ public class MapUtils {
/**
* <code>MapUtils</code> should not normally be instantiated.
*/
- private MapUtils() {}
+ protected MapUtils() {}
// Type safe getters
//-------------------------------------------------------------------------
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java Thu May 1 11:04:59 2014
@@ -48,7 +48,7 @@ public class MultiMapUtils {
/**
* <code>MultiMapUtils</code> should not normally be instantiated.
*/
- private MultiMapUtils() {
+ protected MultiMapUtils() {
}
/**
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java Thu May 1 11:04:59 2014
@@ -74,7 +74,7 @@ public class PredicateUtils {
/**
* This class is not normally instantiated.
*/
- private PredicateUtils() {}
+ protected PredicateUtils() {}
// Simple predicates
//-----------------------------------------------------------------------------
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java Thu May 1 11:04:59 2014
@@ -40,7 +40,7 @@ public class QueueUtils {
/**
* <code>QueueUtils</code> should not normally be instantiated.
*/
- private QueueUtils() {}
+ protected QueueUtils() {}
//-----------------------------------------------------------------------
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java Thu May 1 11:04:59 2014
@@ -69,7 +69,7 @@ public class SetUtils {
/**
* <code>SetUtils</code> should not normally be instantiated.
*/
- private SetUtils() {}
+ protected SetUtils() {}
//-----------------------------------------------------------------------
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java Thu May 1 11:04:59 2014
@@ -20,11 +20,11 @@ import java.util.Collection;
import java.util.Map;
import java.util.Set;
-import org.apache.commons.collections4.set.UnmodifiableSet;
import org.apache.commons.collections4.collection.UnmodifiableCollection;
import org.apache.commons.collections4.iterators.UnmodifiableMapIterator;
import org.apache.commons.collections4.map.EntrySetToMapIteratorAdapter;
import org.apache.commons.collections4.map.UnmodifiableEntrySet;
+import org.apache.commons.collections4.set.UnmodifiableSet;
/**
* Utilities for working with "split maps:" objects that implement {@link Put}
@@ -41,7 +41,7 @@ public class SplitMapUtils {
/**
* <code>SplitMapUtils</code> should not normally be instantiated.
*/
- private SplitMapUtils() {}
+ protected SplitMapUtils() {}
//-----------------------------------------------------------------------
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java Thu May 1 11:04:59 2014
@@ -66,7 +66,7 @@ public class TransformerUtils {
/**
* This class is not normally instantiated.
*/
- private TransformerUtils() {}
+ protected TransformerUtils() {}
/**
* Gets a transformer that always throws an exception.
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java Thu May 1 11:04:59 2014
@@ -29,7 +29,7 @@ public class TrieUtils {
/**
* {@link TrieUtils} should not normally be instantiated.
*/
- private TrieUtils() {}
+ protected TrieUtils() {}
/**
* Returns an unmodifiable instance of a {@link Trie}
Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src:
changes/ main/java/org/apache/commons/collections4/
Posted by Thomas Neidhart <th...@gmail.com>.
Reverted commit in r1591832.
On Thu, May 1, 2014 at 3:03 PM, sebb <se...@gmail.com> wrote:
> On 1 May 2014 12:05, <tn...@apache.org> wrote:
> > Author: tn
> > Date: Thu May 1 11:04:59 2014
> > New Revision: 1591602
> >
> > URL: http://svn.apache.org/r1591602
> > Log:
> > [COLLECTIONS-519] Constructors of *Utils classes are now protected to
> allow sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
>
> -1
>
> I don't think this is a good idea.
>
> See my comments on the JIRA issue.
>
> > Modified:
> > commons/proper/collections/trunk/src/changes/changes.xml
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
> >
> > Modified: commons/proper/collections/trunk/src/changes/changes.xml
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/changes/changes.xml?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > --- commons/proper/collections/trunk/src/changes/changes.xml (original)
> > +++ commons/proper/collections/trunk/src/changes/changes.xml Thu May 1
> 11:04:59 2014
> > @@ -22,6 +22,9 @@
> > <body>
> >
> > <release version="4.1" date="TBD" description="">
> > + <action issue="COLLECTIONS-519" dev="tn" type="fix"
> due-to="Radoslav Paskalev, Daniel Feist">
> > + Constructors of *Utils classes are now protected to allow
> sub-classing.
> > + </action>
> > <action issue="COLLECTIONS-512" dev="tn" type="fix" due-to="Cyrille
> Artho">
> > "TransformingComparator" did not comply with the contract of
> Object#equals.
> > </action>
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
> Thu May 1 11:04:59 2014
> > @@ -56,7 +56,7 @@ public class ClosureUtils {
> > /**
> > * This class is not normally instantiated.
> > */
> > - private ClosureUtils() {}
> > + protected ClosureUtils() {}
> >
> > /**
> > * Gets a Closure that always throws an exception.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
> Thu May 1 11:04:59 2014
> > @@ -185,7 +185,7 @@ public class CollectionUtils {
> > /**
> > * <code>CollectionUtils</code> should not normally be instantiated.
> > */
> > - private CollectionUtils() {}
> > + protected CollectionUtils() {}
> >
> > /**
> > * Returns the immutable EMPTY_COLLECTION with generic type safety.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
> Thu May 1 11:04:59 2014
> > @@ -43,7 +43,7 @@ public class ComparatorUtils {
> > /**
> > * ComparatorUtils should not normally be instantiated.
> > */
> > - private ComparatorUtils() {}
> > + protected ComparatorUtils() {}
> >
> > /**
> > * Comparator for natural sort order.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
> Thu May 1 11:04:59 2014
> > @@ -34,7 +34,7 @@ public class EnumerationUtils {
> > /**
> > * EnumerationUtils is not normally instantiated.
> > */
> > - private EnumerationUtils() {}
> > + protected EnumerationUtils() {}
> >
> > /**
> > * Creates a list based on an enumeration.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
> Thu May 1 11:04:59 2014
> > @@ -41,7 +41,7 @@ public class FactoryUtils {
> > /**
> > * This class is not normally instantiated.
> > */
> > - private FactoryUtils() {}
> > + protected FactoryUtils() {}
> >
> > /**
> > * Gets a Factory that always throws an exception.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
> Thu May 1 11:04:59 2014
> > @@ -119,7 +119,7 @@ public class IteratorUtils {
> > /**
> > * IteratorUtils is not normally instantiated.
> > */
> > - private IteratorUtils() {}
> > + protected IteratorUtils() {}
> >
> > // Empty
> >
> //-----------------------------------------------------------------------
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
> Thu May 1 11:04:59 2014
> > @@ -46,7 +46,7 @@ public class ListUtils {
> > /**
> > * <code>ListUtils</code> should not normally be instantiated.
> > */
> > - private ListUtils() {}
> > + protected ListUtils() {}
> >
> >
> //-----------------------------------------------------------------------
> >
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
> Thu May 1 11:04:59 2014
> > @@ -92,7 +92,7 @@ public class MapUtils {
> > /**
> > * <code>MapUtils</code> should not normally be instantiated.
> > */
> > - private MapUtils() {}
> > + protected MapUtils() {}
> >
> > // Type safe getters
> >
> //-------------------------------------------------------------------------
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
> Thu May 1 11:04:59 2014
> > @@ -48,7 +48,7 @@ public class MultiMapUtils {
> > /**
> > * <code>MultiMapUtils</code> should not normally be instantiated.
> > */
> > - private MultiMapUtils() {
> > + protected MultiMapUtils() {
> > }
> >
> > /**
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
> Thu May 1 11:04:59 2014
> > @@ -74,7 +74,7 @@ public class PredicateUtils {
> > /**
> > * This class is not normally instantiated.
> > */
> > - private PredicateUtils() {}
> > + protected PredicateUtils() {}
> >
> > // Simple predicates
> >
> //-----------------------------------------------------------------------------
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
> Thu May 1 11:04:59 2014
> > @@ -40,7 +40,7 @@ public class QueueUtils {
> > /**
> > * <code>QueueUtils</code> should not normally be instantiated.
> > */
> > - private QueueUtils() {}
> > + protected QueueUtils() {}
> >
> >
> //-----------------------------------------------------------------------
> >
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
> Thu May 1 11:04:59 2014
> > @@ -69,7 +69,7 @@ public class SetUtils {
> > /**
> > * <code>SetUtils</code> should not normally be instantiated.
> > */
> > - private SetUtils() {}
> > + protected SetUtils() {}
> >
> >
> //-----------------------------------------------------------------------
> >
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
> Thu May 1 11:04:59 2014
> > @@ -20,11 +20,11 @@ import java.util.Collection;
> > import java.util.Map;
> > import java.util.Set;
> >
> > -import org.apache.commons.collections4.set.UnmodifiableSet;
> > import
> org.apache.commons.collections4.collection.UnmodifiableCollection;
> > import
> org.apache.commons.collections4.iterators.UnmodifiableMapIterator;
> > import org.apache.commons.collections4.map.EntrySetToMapIteratorAdapter;
> > import org.apache.commons.collections4.map.UnmodifiableEntrySet;
> > +import org.apache.commons.collections4.set.UnmodifiableSet;
> >
> > /**
> > * Utilities for working with "split maps:" objects that implement
> {@link Put}
> > @@ -41,7 +41,7 @@ public class SplitMapUtils {
> > /**
> > * <code>SplitMapUtils</code> should not normally be instantiated.
> > */
> > - private SplitMapUtils() {}
> > + protected SplitMapUtils() {}
> >
> >
> //-----------------------------------------------------------------------
> >
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
> Thu May 1 11:04:59 2014
> > @@ -66,7 +66,7 @@ public class TransformerUtils {
> > /**
> > * This class is not normally instantiated.
> > */
> > - private TransformerUtils() {}
> > + protected TransformerUtils() {}
> >
> > /**
> > * Gets a transformer that always throws an exception.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
> Thu May 1 11:04:59 2014
> > @@ -29,7 +29,7 @@ public class TrieUtils {
> > /**
> > * {@link TrieUtils} should not normally be instantiated.
> > */
> > - private TrieUtils() {}
> > + protected TrieUtils() {}
> >
> > /**
> > * Returns an unmodifiable instance of a {@link Trie}
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src:
changes/ main/java/org/apache/commons/collections4/
Posted by Benedikt Ritter <br...@apache.org>.
-1 I agree with sebb. There is no use case for this. I've elaborated this
some more in the jira.
2014-05-01 20:18 GMT+02:00 Dipanjan Laha <di...@gmail.com>:
> -1
>
> Imho this usecase also gives a false impression of over riding, so maybe we
> should make the util classes final as Gary suggested. And imo switching to
> Guava would be much more of an effort than to compose ones own util class
> :)
>
> On Thursday, 1 May 2014, Jörg Schaible
> <joerg.schaible@gmx.de<javascript:_e(%7B%7D,'cvml','joerg.schaible@gmx.de
> ');>>
> wrote:
>
> > sebb wrote:
> >
> > > On 1 May 2014 14:21, Thomas Neidhart <th...@gmail.com>
> wrote:
> > >> On 05/01/2014 03:03 PM, sebb wrote:
> > >>> On 1 May 2014 12:05, <tn...@apache.org> wrote:
> > >>>> Author: tn
> > >>>> Date: Thu May 1 11:04:59 2014
> > >>>> New Revision: 1591602
> > >>>>
> > >>>> URL: http://svn.apache.org/r1591602
> > >>>> Log:
> > >>>> [COLLECTIONS-519] Constructors of *Utils classes are now protected
> to
> > >>>> [allow sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
> > >>>
> > >>> -1
> > >>>
> > >>> I don't think this is a good idea.
> > >>>
> > >>> See my comments on the JIRA issue.
> > >>
> > >> I consider this to be a compromise considering the fact that
> previously
> > >> the util classes all had a public constructor.
> > >>
> > >> So when people are migrating from 3.2.1 to 4.0, they have some
> troubles.
> > >> To ease the migration I thought that making it protected is safe:
> > >>
> > >> * it can not be instantiated
> > >
> > > Surely it is now instantiable via a sub-class?
> > >
> > >> * if somebody wants to sub-class: at your own risk, like before
> > >>
> > >> The composition approach is the right way to go, and I would
> personally
> > >> never do something like the issue originator.
> > >
> > > The problem we have is that if 4.1 now allows sub-classing, how can we
> > > ever drop it?
> > >
> > > We need to grab the opportunity of 4.x to fix all these bad coding
> > > practises.
> > >
> > > Conversion to 4.x will amyway require some effort on the part of users.
> > > Let's not spoil the API for all for the sake of a few.
> >
> > +1
> >
> > We broke the API on purpose.
> >
> > - Jörg
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src:
changes/ main/java/org/apache/commons/collections4/
Posted by Dipanjan Laha <di...@gmail.com>.
-1
Imho this usecase also gives a false impression of over riding, so maybe we
should make the util classes final as Gary suggested. And imo switching to
Guava would be much more of an effort than to compose ones own util class :)
On Thursday, 1 May 2014, Jörg Schaible
<joerg.schaible@gmx.de<javascript:_e(%7B%7D,'cvml','joerg.schaible@gmx.de');>>
wrote:
> sebb wrote:
>
> > On 1 May 2014 14:21, Thomas Neidhart <th...@gmail.com> wrote:
> >> On 05/01/2014 03:03 PM, sebb wrote:
> >>> On 1 May 2014 12:05, <tn...@apache.org> wrote:
> >>>> Author: tn
> >>>> Date: Thu May 1 11:04:59 2014
> >>>> New Revision: 1591602
> >>>>
> >>>> URL: http://svn.apache.org/r1591602
> >>>> Log:
> >>>> [COLLECTIONS-519] Constructors of *Utils classes are now protected to
> >>>> [allow sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
> >>>
> >>> -1
> >>>
> >>> I don't think this is a good idea.
> >>>
> >>> See my comments on the JIRA issue.
> >>
> >> I consider this to be a compromise considering the fact that previously
> >> the util classes all had a public constructor.
> >>
> >> So when people are migrating from 3.2.1 to 4.0, they have some troubles.
> >> To ease the migration I thought that making it protected is safe:
> >>
> >> * it can not be instantiated
> >
> > Surely it is now instantiable via a sub-class?
> >
> >> * if somebody wants to sub-class: at your own risk, like before
> >>
> >> The composition approach is the right way to go, and I would personally
> >> never do something like the issue originator.
> >
> > The problem we have is that if 4.1 now allows sub-classing, how can we
> > ever drop it?
> >
> > We need to grab the opportunity of 4.x to fix all these bad coding
> > practises.
> >
> > Conversion to 4.x will amyway require some effort on the part of users.
> > Let's not spoil the API for all for the sake of a few.
>
> +1
>
> We broke the API on purpose.
>
> - Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src: changes/ main/java/org/apache/commons/collections4/
Posted by Jörg Schaible <jo...@gmx.de>.
sebb wrote:
> On 1 May 2014 14:21, Thomas Neidhart <th...@gmail.com> wrote:
>> On 05/01/2014 03:03 PM, sebb wrote:
>>> On 1 May 2014 12:05, <tn...@apache.org> wrote:
>>>> Author: tn
>>>> Date: Thu May 1 11:04:59 2014
>>>> New Revision: 1591602
>>>>
>>>> URL: http://svn.apache.org/r1591602
>>>> Log:
>>>> [COLLECTIONS-519] Constructors of *Utils classes are now protected to
>>>> [allow sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
>>>
>>> -1
>>>
>>> I don't think this is a good idea.
>>>
>>> See my comments on the JIRA issue.
>>
>> I consider this to be a compromise considering the fact that previously
>> the util classes all had a public constructor.
>>
>> So when people are migrating from 3.2.1 to 4.0, they have some troubles.
>> To ease the migration I thought that making it protected is safe:
>>
>> * it can not be instantiated
>
> Surely it is now instantiable via a sub-class?
>
>> * if somebody wants to sub-class: at your own risk, like before
>>
>> The composition approach is the right way to go, and I would personally
>> never do something like the issue originator.
>
> The problem we have is that if 4.1 now allows sub-classing, how can we
> ever drop it?
>
> We need to grab the opportunity of 4.x to fix all these bad coding
> practises.
>
> Conversion to 4.x will amyway require some effort on the part of users.
> Let's not spoil the API for all for the sake of a few.
+1
We broke the API on purpose.
- Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src:
changes/ main/java/org/apache/commons/collections4/
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 01/05/2014 16:13, Thomas Neidhart a écrit :
> If there is too much trouble upgrading to collections 4, they might also
> switch to guava, which I have seen a couple of times already.
And they'll cry on every Guava update when deprecated methods are
aggressively removed ;)
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src:
changes/ main/java/org/apache/commons/collections4/
Posted by sebb <se...@gmail.com>.
On 1 May 2014 15:13, Thomas Neidhart <th...@gmail.com> wrote:
> On 05/01/2014 03:39 PM, sebb wrote:
>> On 1 May 2014 14:21, Thomas Neidhart <th...@gmail.com> wrote:
>>> On 05/01/2014 03:03 PM, sebb wrote:
>>>> On 1 May 2014 12:05, <tn...@apache.org> wrote:
>>>>> Author: tn
>>>>> Date: Thu May 1 11:04:59 2014
>>>>> New Revision: 1591602
>>>>>
>>>>> URL: http://svn.apache.org/r1591602
>>>>> Log:
>>>>> [COLLECTIONS-519] Constructors of *Utils classes are now protected to allow sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
>>>>
>>>> -1
>>>>
>>>> I don't think this is a good idea.
>>>>
>>>> See my comments on the JIRA issue.
>>>
>>> I consider this to be a compromise considering the fact that previously
>>> the util classes all had a public constructor.
>>>
>>> So when people are migrating from 3.2.1 to 4.0, they have some troubles.
>>> To ease the migration I thought that making it protected is safe:
>>>
>>> * it can not be instantiated
>>
>> Surely it is now instantiable via a sub-class?
>>
>>> * if somebody wants to sub-class: at your own risk, like before
>>>
>>> The composition approach is the right way to go, and I would personally
>>> never do something like the issue originator.
>>
>> The problem we have is that if 4.1 now allows sub-classing, how can we
>> ever drop it?
>>
>> We need to grab the opportunity of 4.x to fix all these bad coding practises.
>>
>> Conversion to 4.x will amyway require some effort on the part of users.
>> Let's not spoil the API for all for the sake of a few.
>
> As long as there was only 1 guy requesting this, I had the same opinion
> as you (and I already wanted to close the issue as Wont fix).
>
> But who knows how many people/projects have done the same and now want
> to migrate to collections 4 and are facing this issue.
Then perhaps we need to provide more documentation on why this change was made.
> If there is too much trouble upgrading to collections 4, they might also
> switch to guava, which I have seen a couple of times already.
If Guava suits them better, so be it.
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src:
changes/ main/java/org/apache/commons/collections4/
Posted by Thomas Neidhart <th...@gmail.com>.
On 05/01/2014 03:39 PM, sebb wrote:
> On 1 May 2014 14:21, Thomas Neidhart <th...@gmail.com> wrote:
>> On 05/01/2014 03:03 PM, sebb wrote:
>>> On 1 May 2014 12:05, <tn...@apache.org> wrote:
>>>> Author: tn
>>>> Date: Thu May 1 11:04:59 2014
>>>> New Revision: 1591602
>>>>
>>>> URL: http://svn.apache.org/r1591602
>>>> Log:
>>>> [COLLECTIONS-519] Constructors of *Utils classes are now protected to allow sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
>>>
>>> -1
>>>
>>> I don't think this is a good idea.
>>>
>>> See my comments on the JIRA issue.
>>
>> I consider this to be a compromise considering the fact that previously
>> the util classes all had a public constructor.
>>
>> So when people are migrating from 3.2.1 to 4.0, they have some troubles.
>> To ease the migration I thought that making it protected is safe:
>>
>> * it can not be instantiated
>
> Surely it is now instantiable via a sub-class?
>
>> * if somebody wants to sub-class: at your own risk, like before
>>
>> The composition approach is the right way to go, and I would personally
>> never do something like the issue originator.
>
> The problem we have is that if 4.1 now allows sub-classing, how can we
> ever drop it?
>
> We need to grab the opportunity of 4.x to fix all these bad coding practises.
>
> Conversion to 4.x will amyway require some effort on the part of users.
> Let's not spoil the API for all for the sake of a few.
As long as there was only 1 guy requesting this, I had the same opinion
as you (and I already wanted to close the issue as Wont fix).
But who knows how many people/projects have done the same and now want
to migrate to collections 4 and are facing this issue.
If there is too much trouble upgrading to collections 4, they might also
switch to guava, which I have seen a couple of times already.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src:
changes/ main/java/org/apache/commons/collections4/
Posted by sebb <se...@gmail.com>.
On 1 May 2014 14:21, Thomas Neidhart <th...@gmail.com> wrote:
> On 05/01/2014 03:03 PM, sebb wrote:
>> On 1 May 2014 12:05, <tn...@apache.org> wrote:
>>> Author: tn
>>> Date: Thu May 1 11:04:59 2014
>>> New Revision: 1591602
>>>
>>> URL: http://svn.apache.org/r1591602
>>> Log:
>>> [COLLECTIONS-519] Constructors of *Utils classes are now protected to allow sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
>>
>> -1
>>
>> I don't think this is a good idea.
>>
>> See my comments on the JIRA issue.
>
> I consider this to be a compromise considering the fact that previously
> the util classes all had a public constructor.
>
> So when people are migrating from 3.2.1 to 4.0, they have some troubles.
> To ease the migration I thought that making it protected is safe:
>
> * it can not be instantiated
Surely it is now instantiable via a sub-class?
> * if somebody wants to sub-class: at your own risk, like before
>
> The composition approach is the right way to go, and I would personally
> never do something like the issue originator.
The problem we have is that if 4.1 now allows sub-classing, how can we
ever drop it?
We need to grab the opportunity of 4.x to fix all these bad coding practises.
Conversion to 4.x will amyway require some effort on the part of users.
Let's not spoil the API for all for the sake of a few.
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src:
changes/ main/java/org/apache/commons/collections4/
Posted by Thomas Neidhart <th...@gmail.com>.
On 05/01/2014 03:03 PM, sebb wrote:
> On 1 May 2014 12:05, <tn...@apache.org> wrote:
>> Author: tn
>> Date: Thu May 1 11:04:59 2014
>> New Revision: 1591602
>>
>> URL: http://svn.apache.org/r1591602
>> Log:
>> [COLLECTIONS-519] Constructors of *Utils classes are now protected to allow sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
>
> -1
>
> I don't think this is a good idea.
>
> See my comments on the JIRA issue.
I consider this to be a compromise considering the fact that previously
the util classes all had a public constructor.
So when people are migrating from 3.2.1 to 4.0, they have some troubles.
To ease the migration I thought that making it protected is safe:
* it can not be instantiated
* if somebody wants to sub-class: at your own risk, like before
The composition approach is the right way to go, and I would personally
never do something like the issue originator.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src:
changes/ main/java/org/apache/commons/collections4/
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, May 1, 2014 at 9:03 AM, sebb <se...@gmail.com> wrote:
> On 1 May 2014 12:05, <tn...@apache.org> wrote:
> > Author: tn
> > Date: Thu May 1 11:04:59 2014
> > New Revision: 1591602
> >
> > URL: http://svn.apache.org/r1591602
> > Log:
> > [COLLECTIONS-519] Constructors of *Utils classes are now protected to
> allow sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
>
> -1
>
> I don't think this is a good idea.
>
> See my comments on the JIRA issue.
>
Shouldn't these util classes be final anyway?
Gary
>
> > Modified:
> > commons/proper/collections/trunk/src/changes/changes.xml
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
> >
> > Modified: commons/proper/collections/trunk/src/changes/changes.xml
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/changes/changes.xml?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > --- commons/proper/collections/trunk/src/changes/changes.xml (original)
> > +++ commons/proper/collections/trunk/src/changes/changes.xml Thu May 1
> 11:04:59 2014
> > @@ -22,6 +22,9 @@
> > <body>
> >
> > <release version="4.1" date="TBD" description="">
> > + <action issue="COLLECTIONS-519" dev="tn" type="fix"
> due-to="Radoslav Paskalev, Daniel Feist">
> > + Constructors of *Utils classes are now protected to allow
> sub-classing.
> > + </action>
> > <action issue="COLLECTIONS-512" dev="tn" type="fix" due-to="Cyrille
> Artho">
> > "TransformingComparator" did not comply with the contract of
> Object#equals.
> > </action>
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
> Thu May 1 11:04:59 2014
> > @@ -56,7 +56,7 @@ public class ClosureUtils {
> > /**
> > * This class is not normally instantiated.
> > */
> > - private ClosureUtils() {}
> > + protected ClosureUtils() {}
> >
> > /**
> > * Gets a Closure that always throws an exception.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
> Thu May 1 11:04:59 2014
> > @@ -185,7 +185,7 @@ public class CollectionUtils {
> > /**
> > * <code>CollectionUtils</code> should not normally be instantiated.
> > */
> > - private CollectionUtils() {}
> > + protected CollectionUtils() {}
> >
> > /**
> > * Returns the immutable EMPTY_COLLECTION with generic type safety.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
> Thu May 1 11:04:59 2014
> > @@ -43,7 +43,7 @@ public class ComparatorUtils {
> > /**
> > * ComparatorUtils should not normally be instantiated.
> > */
> > - private ComparatorUtils() {}
> > + protected ComparatorUtils() {}
> >
> > /**
> > * Comparator for natural sort order.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
> Thu May 1 11:04:59 2014
> > @@ -34,7 +34,7 @@ public class EnumerationUtils {
> > /**
> > * EnumerationUtils is not normally instantiated.
> > */
> > - private EnumerationUtils() {}
> > + protected EnumerationUtils() {}
> >
> > /**
> > * Creates a list based on an enumeration.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
> Thu May 1 11:04:59 2014
> > @@ -41,7 +41,7 @@ public class FactoryUtils {
> > /**
> > * This class is not normally instantiated.
> > */
> > - private FactoryUtils() {}
> > + protected FactoryUtils() {}
> >
> > /**
> > * Gets a Factory that always throws an exception.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
> Thu May 1 11:04:59 2014
> > @@ -119,7 +119,7 @@ public class IteratorUtils {
> > /**
> > * IteratorUtils is not normally instantiated.
> > */
> > - private IteratorUtils() {}
> > + protected IteratorUtils() {}
> >
> > // Empty
> >
> //-----------------------------------------------------------------------
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
> Thu May 1 11:04:59 2014
> > @@ -46,7 +46,7 @@ public class ListUtils {
> > /**
> > * <code>ListUtils</code> should not normally be instantiated.
> > */
> > - private ListUtils() {}
> > + protected ListUtils() {}
> >
> >
> //-----------------------------------------------------------------------
> >
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
> Thu May 1 11:04:59 2014
> > @@ -92,7 +92,7 @@ public class MapUtils {
> > /**
> > * <code>MapUtils</code> should not normally be instantiated.
> > */
> > - private MapUtils() {}
> > + protected MapUtils() {}
> >
> > // Type safe getters
> >
> //-------------------------------------------------------------------------
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
> Thu May 1 11:04:59 2014
> > @@ -48,7 +48,7 @@ public class MultiMapUtils {
> > /**
> > * <code>MultiMapUtils</code> should not normally be instantiated.
> > */
> > - private MultiMapUtils() {
> > + protected MultiMapUtils() {
> > }
> >
> > /**
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
> Thu May 1 11:04:59 2014
> > @@ -74,7 +74,7 @@ public class PredicateUtils {
> > /**
> > * This class is not normally instantiated.
> > */
> > - private PredicateUtils() {}
> > + protected PredicateUtils() {}
> >
> > // Simple predicates
> >
> //-----------------------------------------------------------------------------
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
> Thu May 1 11:04:59 2014
> > @@ -40,7 +40,7 @@ public class QueueUtils {
> > /**
> > * <code>QueueUtils</code> should not normally be instantiated.
> > */
> > - private QueueUtils() {}
> > + protected QueueUtils() {}
> >
> >
> //-----------------------------------------------------------------------
> >
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
> Thu May 1 11:04:59 2014
> > @@ -69,7 +69,7 @@ public class SetUtils {
> > /**
> > * <code>SetUtils</code> should not normally be instantiated.
> > */
> > - private SetUtils() {}
> > + protected SetUtils() {}
> >
> >
> //-----------------------------------------------------------------------
> >
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
> Thu May 1 11:04:59 2014
> > @@ -20,11 +20,11 @@ import java.util.Collection;
> > import java.util.Map;
> > import java.util.Set;
> >
> > -import org.apache.commons.collections4.set.UnmodifiableSet;
> > import
> org.apache.commons.collections4.collection.UnmodifiableCollection;
> > import
> org.apache.commons.collections4.iterators.UnmodifiableMapIterator;
> > import org.apache.commons.collections4.map.EntrySetToMapIteratorAdapter;
> > import org.apache.commons.collections4.map.UnmodifiableEntrySet;
> > +import org.apache.commons.collections4.set.UnmodifiableSet;
> >
> > /**
> > * Utilities for working with "split maps:" objects that implement
> {@link Put}
> > @@ -41,7 +41,7 @@ public class SplitMapUtils {
> > /**
> > * <code>SplitMapUtils</code> should not normally be instantiated.
> > */
> > - private SplitMapUtils() {}
> > + protected SplitMapUtils() {}
> >
> >
> //-----------------------------------------------------------------------
> >
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
> Thu May 1 11:04:59 2014
> > @@ -66,7 +66,7 @@ public class TransformerUtils {
> > /**
> > * This class is not normally instantiated.
> > */
> > - private TransformerUtils() {}
> > + protected TransformerUtils() {}
> >
> > /**
> > * Gets a transformer that always throws an exception.
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
> Thu May 1 11:04:59 2014
> > @@ -29,7 +29,7 @@ public class TrieUtils {
> > /**
> > * {@link TrieUtils} should not normally be instantiated.
> > */
> > - private TrieUtils() {}
> > + protected TrieUtils() {}
> >
> > /**
> > * Returns an unmodifiable instance of a {@link Trie}
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src:
changes/ main/java/org/apache/commons/collections4/
Posted by sebb <se...@gmail.com>.
On 1 May 2014 12:05, <tn...@apache.org> wrote:
> Author: tn
> Date: Thu May 1 11:04:59 2014
> New Revision: 1591602
>
> URL: http://svn.apache.org/r1591602
> Log:
> [COLLECTIONS-519] Constructors of *Utils classes are now protected to allow sub-classing. Thanks to Radoslav Paskalev, Daniel Feist.
-1
I don't think this is a good idea.
See my comments on the JIRA issue.
> Modified:
> commons/proper/collections/trunk/src/changes/changes.xml
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
>
> Modified: commons/proper/collections/trunk/src/changes/changes.xml
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/changes/changes.xml?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/changes/changes.xml (original)
> +++ commons/proper/collections/trunk/src/changes/changes.xml Thu May 1 11:04:59 2014
> @@ -22,6 +22,9 @@
> <body>
>
> <release version="4.1" date="TBD" description="">
> + <action issue="COLLECTIONS-519" dev="tn" type="fix" due-to="Radoslav Paskalev, Daniel Feist">
> + Constructors of *Utils classes are now protected to allow sub-classing.
> + </action>
> <action issue="COLLECTIONS-512" dev="tn" type="fix" due-to="Cyrille Artho">
> "TransformingComparator" did not comply with the contract of Object#equals.
> </action>
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ClosureUtils.java Thu May 1 11:04:59 2014
> @@ -56,7 +56,7 @@ public class ClosureUtils {
> /**
> * This class is not normally instantiated.
> */
> - private ClosureUtils() {}
> + protected ClosureUtils() {}
>
> /**
> * Gets a Closure that always throws an exception.
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/CollectionUtils.java Thu May 1 11:04:59 2014
> @@ -185,7 +185,7 @@ public class CollectionUtils {
> /**
> * <code>CollectionUtils</code> should not normally be instantiated.
> */
> - private CollectionUtils() {}
> + protected CollectionUtils() {}
>
> /**
> * Returns the immutable EMPTY_COLLECTION with generic type safety.
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ComparatorUtils.java Thu May 1 11:04:59 2014
> @@ -43,7 +43,7 @@ public class ComparatorUtils {
> /**
> * ComparatorUtils should not normally be instantiated.
> */
> - private ComparatorUtils() {}
> + protected ComparatorUtils() {}
>
> /**
> * Comparator for natural sort order.
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/EnumerationUtils.java Thu May 1 11:04:59 2014
> @@ -34,7 +34,7 @@ public class EnumerationUtils {
> /**
> * EnumerationUtils is not normally instantiated.
> */
> - private EnumerationUtils() {}
> + protected EnumerationUtils() {}
>
> /**
> * Creates a list based on an enumeration.
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/FactoryUtils.java Thu May 1 11:04:59 2014
> @@ -41,7 +41,7 @@ public class FactoryUtils {
> /**
> * This class is not normally instantiated.
> */
> - private FactoryUtils() {}
> + protected FactoryUtils() {}
>
> /**
> * Gets a Factory that always throws an exception.
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/IteratorUtils.java Thu May 1 11:04:59 2014
> @@ -119,7 +119,7 @@ public class IteratorUtils {
> /**
> * IteratorUtils is not normally instantiated.
> */
> - private IteratorUtils() {}
> + protected IteratorUtils() {}
>
> // Empty
> //-----------------------------------------------------------------------
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/ListUtils.java Thu May 1 11:04:59 2014
> @@ -46,7 +46,7 @@ public class ListUtils {
> /**
> * <code>ListUtils</code> should not normally be instantiated.
> */
> - private ListUtils() {}
> + protected ListUtils() {}
>
> //-----------------------------------------------------------------------
>
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java Thu May 1 11:04:59 2014
> @@ -92,7 +92,7 @@ public class MapUtils {
> /**
> * <code>MapUtils</code> should not normally be instantiated.
> */
> - private MapUtils() {}
> + protected MapUtils() {}
>
> // Type safe getters
> //-------------------------------------------------------------------------
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MultiMapUtils.java Thu May 1 11:04:59 2014
> @@ -48,7 +48,7 @@ public class MultiMapUtils {
> /**
> * <code>MultiMapUtils</code> should not normally be instantiated.
> */
> - private MultiMapUtils() {
> + protected MultiMapUtils() {
> }
>
> /**
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/PredicateUtils.java Thu May 1 11:04:59 2014
> @@ -74,7 +74,7 @@ public class PredicateUtils {
> /**
> * This class is not normally instantiated.
> */
> - private PredicateUtils() {}
> + protected PredicateUtils() {}
>
> // Simple predicates
> //-----------------------------------------------------------------------------
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/QueueUtils.java Thu May 1 11:04:59 2014
> @@ -40,7 +40,7 @@ public class QueueUtils {
> /**
> * <code>QueueUtils</code> should not normally be instantiated.
> */
> - private QueueUtils() {}
> + protected QueueUtils() {}
>
> //-----------------------------------------------------------------------
>
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SetUtils.java Thu May 1 11:04:59 2014
> @@ -69,7 +69,7 @@ public class SetUtils {
> /**
> * <code>SetUtils</code> should not normally be instantiated.
> */
> - private SetUtils() {}
> + protected SetUtils() {}
>
> //-----------------------------------------------------------------------
>
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/SplitMapUtils.java Thu May 1 11:04:59 2014
> @@ -20,11 +20,11 @@ import java.util.Collection;
> import java.util.Map;
> import java.util.Set;
>
> -import org.apache.commons.collections4.set.UnmodifiableSet;
> import org.apache.commons.collections4.collection.UnmodifiableCollection;
> import org.apache.commons.collections4.iterators.UnmodifiableMapIterator;
> import org.apache.commons.collections4.map.EntrySetToMapIteratorAdapter;
> import org.apache.commons.collections4.map.UnmodifiableEntrySet;
> +import org.apache.commons.collections4.set.UnmodifiableSet;
>
> /**
> * Utilities for working with "split maps:" objects that implement {@link Put}
> @@ -41,7 +41,7 @@ public class SplitMapUtils {
> /**
> * <code>SplitMapUtils</code> should not normally be instantiated.
> */
> - private SplitMapUtils() {}
> + protected SplitMapUtils() {}
>
> //-----------------------------------------------------------------------
>
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TransformerUtils.java Thu May 1 11:04:59 2014
> @@ -66,7 +66,7 @@ public class TransformerUtils {
> /**
> * This class is not normally instantiated.
> */
> - private TransformerUtils() {}
> + protected TransformerUtils() {}
>
> /**
> * Gets a transformer that always throws an exception.
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java?rev=1591602&r1=1591601&r2=1591602&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java (original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/TrieUtils.java Thu May 1 11:04:59 2014
> @@ -29,7 +29,7 @@ public class TrieUtils {
> /**
> * {@link TrieUtils} should not normally be instantiated.
> */
> - private TrieUtils() {}
> + protected TrieUtils() {}
>
> /**
> * Returns an unmodifiable instance of a {@link Trie}
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org