You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rh...@apache.org on 2014/06/23 13:13:56 UTC
svn commit: r1604749 - in /subversion/trunk/subversion/include: svn_client.h
svn_wc.h
Author: rhuijben
Date: Mon Jun 23 11:13:55 2014
New Revision: 1604749
URL: http://svn.apache.org/r1604749
Log:
Extend documentation on a few new in 1.9 apis.
* subversion/include/svn_client.h
(svn_client_cleanup2): Document several new in 1.9 arguments.
(svn_client_cleanup): Add missing SVN_DEPRECATED.
* subversion/include/svn_wc.h
(svn_wc_cleanup4): Document clear_dav_cache as in svn_client.h
Modified:
subversion/trunk/subversion/include/svn_client.h
subversion/trunk/subversion/include/svn_wc.h
Modified: subversion/trunk/subversion/include/svn_client.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_client.h?rev=1604749&r1=1604748&r2=1604749&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_client.h (original)
+++ subversion/trunk/subversion/include/svn_client.h Mon Jun 23 11:13:55 2014
@@ -4130,9 +4130,23 @@ svn_client_vacuum(const char *dir_abspat
apr_pool_t *scratch_pool);
-/** Recursively cleanup a working copy directory @a dir, finishing any
+/** Recursively cleanup a working copy directory @a dir_abspath, finishing any
* incomplete operations, removing lockfiles, etc.
*
+ * If @a break_locks is @c TRUE, existing working copy locks at or below @a
+ * dir_abspath are broken, otherwise a normal write lock is obtained.
+ *
+ * If @a fix_recorded_timestamps is @c TRUE, this function fixes recorded
+ * timestamps for unmodified files in the working copy, reducing comparision
+ * time on future checks.
+ *
+ * If @a clear_dav_cache is @c TRUE, the caching of DAV information for older
+ * mod_dav served repositories is cleared. This clearing invalidates some
+ * cached information used for pre-HTTPv2 repositories.
+ *
+ * If @a vacuum_pristines is @c TRUE, and @a dir_abspath points to the working
+ * copy root unreferenced files in the pristine store are removed.
+ *
* If @a include_externals is @c TRUE, recurse into externals and clean
* them up as well.
*
@@ -4160,6 +4174,7 @@ svn_client_cleanup2(const char *dir_absp
*
* @deprecated Provided for limited backwards compatibility with the 1.8 API.
*/
+SVN_DEPRECATED
svn_error_t *
svn_client_cleanup(const char *dir,
svn_client_ctx_t *ctx,
Modified: subversion/trunk/subversion/include/svn_wc.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_wc.h?rev=1604749&r1=1604748&r2=1604749&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_wc.h (original)
+++ subversion/trunk/subversion/include/svn_wc.h Mon Jun 23 11:13:55 2014
@@ -7362,8 +7362,13 @@ svn_wc_get_pristine_copy_path(const char
* files will be updated, which will improve performance of future is-modified
* checks.
*
+ * If @a clear_dav_cache is @c TRUE, the caching of DAV information for older
+ * mod_dav served repositories is cleared. This clearing invalidates some
+ * cached information used for pre-HTTPv2 repositories.
+ *
* If @a vacuum_pristines is TRUE, try to remove unreferenced pristines from
- * the working copy.
+ * the working copy. (Will not remove anything unless the obtained lock applies
+ * to the entire working copy)
*
* If @a cancel_func is non-NULL, invoke it with @a cancel_baton at various
* points during the operation. If it returns an error (typically
RE: svn commit: r1604749 - in /subversion/trunk/subversion/include: svn_client.h svn_wc.h
Posted by Bert Huijben <be...@qqmail.nl>.
I don’t know, this was added in r1496954 with message
[[
Allow 'svn cleanup' to remove unversioned items from the working copy.
This should address the feature request from issue #3549.
Add two new options to 'svn cleanup', --remove-unversioned and --no-ignore.
The former causes unversioned files and directories to be removed after
successful cleanup. The latter causes ignored items to be removed as well.
One remaining question is what to do with externals. Right now, 'svn cleanup'
never recurses into externals. Should it recurse into externals if the
--remove-unversioned option is given? Should we change it to always recurse
into externals by default? I'm not quite sure.
]]
I would say that the function still does what it used to do, so we should probably just use the default text.
(This was before moving some of the new code paths into svn_client_vacuum())
Bert
From: Branko Čibej [mailto:brane@wandisco.com]
Sent: maandag 23 juni 2014 16:40
To: Subversion Development
Subject: Re: svn commit: r1604749 - in /subversion/trunk/subversion/include: svn_client.h svn_wc.h
On 23.06.2014 13:13, rhuijben@apache.org <ma...@apache.org> wrote:
Author: rhuijben
Date: Mon Jun 23 11:13:55 2014
New Revision: 1604749
This comment doesn't really refer to this commit, but since it's recent ...
@@ -4160,6 +4174,7 @@ svn_client_cleanup2(const char *dir_absp
*
* @deprecated Provided for limited backwards compatibility with the 1.8 API.
*/
+SVN_DEPRECATED
svn_error_t *
svn_client_cleanup(const char *dir,
svn_client_ctx_t *ctx,
Why "limited backwards compatibility"? What exactly is limited about it?
-- Brane
--
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com <ma...@wandisco.com>
Re: svn commit: r1604749 - in /subversion/trunk/subversion/include:
svn_client.h svn_wc.h
Posted by Branko Čibej <br...@wandisco.com>.
On 23.06.2014 13:13, rhuijben@apache.org wrote:
> Author: rhuijben
> Date: Mon Jun 23 11:13:55 2014
> New Revision: 1604749
This comment doesn't really refer to this commit, but since it's recent ...
> @@ -4160,6 +4174,7 @@ svn_client_cleanup2(const char *dir_absp
> *
> * @deprecated Provided for limited backwards compatibility with the 1.8 API.
> */
> +SVN_DEPRECATED
> svn_error_t *
> svn_client_cleanup(const char *dir,
> svn_client_ctx_t *ctx,
Why "limited backwards compatibility"? What exactly is limited about it?
-- Brane
--
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com