You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ammachado (via GitHub)" <gi...@apache.org> on 2023/07/19 14:03:49 UTC
[GitHub] [camel] ammachado opened a new pull request, #10735: [CAMEL-19613] Convert components to use the camel-test-infra-core: AS2 component
ammachado opened a new pull request, #10735:
URL: https://github.com/apache/camel/pull/10735
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
Convert components to use the camel-test-infra-core: AS2 component
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10735: [CAMEL-19613] Convert components to use the camel-test-infra-core: AS2 component
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10735:
URL: https://github.com/apache/camel/pull/10735#issuecomment-1644571536
Oh it seems like its some tests that was only supposed to be run if you have setup an AS2 server
[ERROR] AS2ServerManagerIT.sendEditMessageToFailingProcessorTest » FailedToCreateRoute Failed to create route route7: Route(route7)[From[as2://server/listen?requestUriPattern=/] ... because of Failed to resolve endpoint: as2://server/listen?requestUriPattern=/ due to: serverPortNumber must be specified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10735: [CAMEL-19613] Convert components to use the camel-test-infra-core: AS2 component
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10735:
URL: https://github.com/apache/camel/pull/10735#issuecomment-1642314263
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10735: [CAMEL-19613] Convert components to use the camel-test-infra-core: AS2 component
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10735:
URL: https://github.com/apache/camel/pull/10735#issuecomment-1644570375
It may be that this PR is causing some of the as2 tests to fail on CI
https://ci-builds.apache.org/job/Camel/job/Camel%20JDK17/job/main/lastCompletedBuild/testReport/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10735: [CAMEL-19613] Convert components to use the camel-test-infra-core: AS2 component
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10735:
URL: https://github.com/apache/camel/pull/10735#issuecomment-1644587011
> Oh it seems like its some tests that was only supposed to be run if you have setup an AS2 server
>
> [ERROR] AS2ServerManagerIT.sendEditMessageToFailingProcessorTest » FailedToCreateRoute Failed to create route route7: Route(route7)[From[as2://server/listen?requestUriPattern=/] ... because of Failed to resolve endpoint: as2://server/listen?requestUriPattern=/ due to: serverPortNumber must be specified
ACK. I remember pointing out in a review that some of these tests were missing assumptions to skip them if certain properties were not provided. I'll investigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #10735: [CAMEL-19613] Convert components to use the camel-test-infra-core: AS2 component
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #10735:
URL: https://github.com/apache/camel/pull/10735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10735: [CAMEL-19613] Convert components to use the camel-test-infra-core: AS2 component
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10735:
URL: https://github.com/apache/camel/pull/10735#issuecomment-1642152150
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org