[GitHub] [arrow-rs] alamb commented on a diff in pull request #3464: Implement fallible streams for `FlightClient::do_put`

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #3464:
URL: https://github.com/apache/arrow-rs/pull/3464#discussion_r1093751084


##########
arrow-flight/tests/client.rs:
##########
@@ -326,6 +330,87 @@ async fn test_do_put_error_stream() {
     .await;
 }
 
+#[tokio::test]
+async fn test_do_put_error_client() {
+    do_test(|test_server, mut client| async move {
+        client.add_header("foo-header", "bar-header-value").unwrap();
+
+        let e = Status::invalid_argument("bad arg: client");
+
+        // input stream to client sends good FlightData followed by an error
+        let input_flight_data = test_flight_data().await;
+        let input_stream = futures::stream::iter(input_flight_data.clone())

Review Comment:
   I added these two tests to show what is going on -- aka that the error provided to the client `do_put` call need to get to the returned stream even though the error did not come from the server



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org