[GitHub] [hive] kgyrtkirk commented on a change in pull request #2910: HIVE-24949: Fail to rename a partition with customized catalog

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #2910:
URL: https://github.com/apache/hive/pull/2910#discussion_r808191572



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
##########
@@ -600,7 +599,7 @@ public Partition alterPartition(RawStore msdb, Warehouse wh, String catName, Str
     Database db;
     try {
       msdb.openTransaction();
-      Table tbl = msdb.getTable(DEFAULT_CATALOG_NAME, dbname, name, null);

Review comment:
       this also seems like a bugfix :)

##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -9768,7 +9767,8 @@ private void writeMPartitionColumnStatistics(Table table, Partition partition,
 
       for (ColumnStatisticsObj statsObj : statsObjs) {
         MPartitionColumnStatistics mStatsObj =
-            StatObjectConverter.convertToMPartitionColumnStatistics(mPartition, statsDesc, statsObj, colStats.getEngine());
+            StatObjectConverter.convertToMPartitionColumnStatistics(mPartition, statsDesc, statsObj,
+                colStats.getEngine(), getDefaultCatalog(conf));

Review comment:
       I think the catalog name should be already accessible thru: `MPartition -> MTable -> MDatabase ->catalogName`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org