You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/09/13 00:50:41 UTC
Review Request 51831: change EntryEventImpl code that does instanceof
StoredObject checks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51831/
-----------------------------------------------------------
Review request for geode, anilkumar gingade and Eric Shu.
Bugs: GEODE-1886
https://issues.apache.org/jira/browse/GEODE-1886
Repository: geode
Description
-------
The EntryEventImpl code now checks the region first to see if it is configured off-heap.
If it is not it can give up early and not bother checking if it is an instance of StoredObject.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java bd7596f84a6a80e420c52e3a60df9e36e9a70ebb
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java bc8a64e8aebb497ec71290c645363a2aeb678e29
Diff: https://reviews.apache.org/r/51831/diff/
Testing
-------
precheckin, perf test
Thanks,
Darrel Schneider
Re: Review Request 51831: change EntryEventImpl code that does
instanceof StoredObject checks
Posted by Darrel Schneider <ds...@pivotal.io>.
> On Sept. 13, 2016, 4:16 p.m., anilkumar gingade wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java, line 773
> > <https://reviews.apache.org/r/51831/diff/1/?file=1497503#file1497503line773>
> >
> > Not sure if this could save a lot interms of temp GC:
> >
> > if (this.isOffHeapPossigle()) {
> > return OffHeapHelper.copyIfNeeded(basicGetNewValue());
> > }
> > return basicGetNewValue();
My understanding is that local variables are not a gc issue
- Darrel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51831/#review148800
-----------------------------------------------------------
On Sept. 12, 2016, 5:50 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51831/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2016, 5:50 p.m.)
>
>
> Review request for geode, anilkumar gingade and Eric Shu.
>
>
> Bugs: GEODE-1886
> https://issues.apache.org/jira/browse/GEODE-1886
>
>
> Repository: geode
>
>
> Description
> -------
>
> The EntryEventImpl code now checks the region first to see if it is configured off-heap.
> If it is not it can give up early and not bother checking if it is an instance of StoredObject.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java bd7596f84a6a80e420c52e3a60df9e36e9a70ebb
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java bc8a64e8aebb497ec71290c645363a2aeb678e29
>
> Diff: https://reviews.apache.org/r/51831/diff/
>
>
> Testing
> -------
>
> precheckin, perf test
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 51831: change EntryEventImpl code that does
instanceof StoredObject checks
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51831/#review148800
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java (line 773)
<https://reviews.apache.org/r/51831/#comment216313>
Not sure if this could save a lot interms of temp GC:
if (this.isOffHeapPossigle()) {
return OffHeapHelper.copyIfNeeded(basicGetNewValue());
}
return basicGetNewValue();
- anilkumar gingade
On Sept. 13, 2016, 12:50 a.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51831/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2016, 12:50 a.m.)
>
>
> Review request for geode, anilkumar gingade and Eric Shu.
>
>
> Bugs: GEODE-1886
> https://issues.apache.org/jira/browse/GEODE-1886
>
>
> Repository: geode
>
>
> Description
> -------
>
> The EntryEventImpl code now checks the region first to see if it is configured off-heap.
> If it is not it can give up early and not bother checking if it is an instance of StoredObject.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java bd7596f84a6a80e420c52e3a60df9e36e9a70ebb
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java bc8a64e8aebb497ec71290c645363a2aeb678e29
>
> Diff: https://reviews.apache.org/r/51831/diff/
>
>
> Testing
> -------
>
> precheckin, perf test
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 51831: change EntryEventImpl code that does
instanceof StoredObject checks
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51831/#review149095
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Shu
On Sept. 14, 2016, 10:34 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51831/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2016, 10:34 p.m.)
>
>
> Review request for geode, anilkumar gingade and Eric Shu.
>
>
> Bugs: GEODE-1886
> https://issues.apache.org/jira/browse/GEODE-1886
>
>
> Repository: geode
>
>
> Description
> -------
>
> The EntryEventImpl code now checks the region first to see if it is configured off-heap.
> If it is not it can give up early and not bother checking if it is an instance of StoredObject.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java bd7596f84a6a80e420c52e3a60df9e36e9a70ebb
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/StoredObject.java 47ad4e2466b2604ef843dc2fb7a8cbb3225d8a8a
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java bc8a64e8aebb497ec71290c645363a2aeb678e29
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessorTest.java 3e51fd9f95612bccfb96e4c68175581954af6ae4
>
> Diff: https://reviews.apache.org/r/51831/diff/
>
>
> Testing
> -------
>
> precheckin, perf test
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 51831: change EntryEventImpl code that does
instanceof StoredObject checks
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51831/#review149101
-----------------------------------------------------------
Ship it!
Ship It!
- anilkumar gingade
On Sept. 14, 2016, 10:34 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51831/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2016, 10:34 p.m.)
>
>
> Review request for geode, anilkumar gingade and Eric Shu.
>
>
> Bugs: GEODE-1886
> https://issues.apache.org/jira/browse/GEODE-1886
>
>
> Repository: geode
>
>
> Description
> -------
>
> The EntryEventImpl code now checks the region first to see if it is configured off-heap.
> If it is not it can give up early and not bother checking if it is an instance of StoredObject.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java bd7596f84a6a80e420c52e3a60df9e36e9a70ebb
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/StoredObject.java 47ad4e2466b2604ef843dc2fb7a8cbb3225d8a8a
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java bc8a64e8aebb497ec71290c645363a2aeb678e29
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessorTest.java 3e51fd9f95612bccfb96e4c68175581954af6ae4
>
> Diff: https://reviews.apache.org/r/51831/diff/
>
>
> Testing
> -------
>
> precheckin, perf test
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 51831: change EntryEventImpl code that does
instanceof StoredObject checks
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51831/
-----------------------------------------------------------
(Updated Sept. 14, 2016, 3:34 p.m.)
Review request for geode, anilkumar gingade and Eric Shu.
Changes
-------
renamed isOffHeapPossible to mayHaveOffHeapReferences
simplified implementation by just calling getOffHeap which reduced unit test changes
moved isOffHeapReference to StoredObject and named it hasReferenceCount
Bugs: GEODE-1886
https://issues.apache.org/jira/browse/GEODE-1886
Repository: geode
Description
-------
The EntryEventImpl code now checks the region first to see if it is configured off-heap.
If it is not it can give up early and not bother checking if it is an instance of StoredObject.
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java bd7596f84a6a80e420c52e3a60df9e36e9a70ebb
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/StoredObject.java 47ad4e2466b2604ef843dc2fb7a8cbb3225d8a8a
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java bc8a64e8aebb497ec71290c645363a2aeb678e29
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessorTest.java 3e51fd9f95612bccfb96e4c68175581954af6ae4
Diff: https://reviews.apache.org/r/51831/diff/
Testing
-------
precheckin, perf test
Thanks,
Darrel Schneider
Re: Review Request 51831: change EntryEventImpl code that does
instanceof StoredObject checks
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51831/#review148801
-----------------------------------------------------------
Ship it!
Ship It!
- anilkumar gingade
On Sept. 13, 2016, 12:50 a.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51831/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2016, 12:50 a.m.)
>
>
> Review request for geode, anilkumar gingade and Eric Shu.
>
>
> Bugs: GEODE-1886
> https://issues.apache.org/jira/browse/GEODE-1886
>
>
> Repository: geode
>
>
> Description
> -------
>
> The EntryEventImpl code now checks the region first to see if it is configured off-heap.
> If it is not it can give up early and not bother checking if it is an instance of StoredObject.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java bd7596f84a6a80e420c52e3a60df9e36e9a70ebb
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java bc8a64e8aebb497ec71290c645363a2aeb678e29
>
> Diff: https://reviews.apache.org/r/51831/diff/
>
>
> Testing
> -------
>
> precheckin, perf test
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 51831: change EntryEventImpl code that does
instanceof StoredObject checks
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51831/#review148794
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Shu
On Sept. 13, 2016, 12:50 a.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51831/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2016, 12:50 a.m.)
>
>
> Review request for geode, anilkumar gingade and Eric Shu.
>
>
> Bugs: GEODE-1886
> https://issues.apache.org/jira/browse/GEODE-1886
>
>
> Repository: geode
>
>
> Description
> -------
>
> The EntryEventImpl code now checks the region first to see if it is configured off-heap.
> If it is not it can give up early and not bother checking if it is an instance of StoredObject.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java bd7596f84a6a80e420c52e3a60df9e36e9a70ebb
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java bc8a64e8aebb497ec71290c645363a2aeb678e29
>
> Diff: https://reviews.apache.org/r/51831/diff/
>
>
> Testing
> -------
>
> precheckin, perf test
>
>
> Thanks,
>
> Darrel Schneider
>
>