You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2013/06/05 20:14:45 UTC

[Bug 55065] New: wasted work in Spline3.converge()

https://issues.apache.org/bugzilla/show_bug.cgi?id=55065

            Bug ID: 55065
           Summary: wasted work in Spline3.converge()
           Product: JMeter
           Version: 2.9
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: nistor1@illinois.edu

Created attachment 30400
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30400&action=edit
patch

The problem appears in version 2.9 and in revision 1489981.  I
attached a one-line patch that fixes it.

In method "Spline3.converge", the loop from 0 to "_n" should break
immediately after "converge" is set to "false".  All the iterations
after "converge" is set to "false" do not perform any useful work
because the "if (converge)" statement will always evaluate to "false"
and the "true" branch will never be taken again for the remaining
iterations.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55065] wasted work in Spline3.converge()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55065

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
           Hardware|PC                          |All
         Resolution|---                         |FIXED
                 OS|Linux                       |All

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Thanks for patch, applied.

Date: Wed Jun  5 18:59:09 2013
New Revision: 1490003

URL: http://svn.apache.org/r1490003
Log:
Bug 55065 - wasted work in Spline3.converge()
Bugzilla Id: 55065

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/Spline3.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55065] wasted work in Spline3.converge()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55065

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55065] Useless processing in Spline3.converge()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55065

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Wed Jun  5 19:06:31 2013
New Revision: 1490009

URL: http://svn.apache.org/r1490009
Log:
Bug 55065 - wasted work in Spline3.converge()
Bug renaming
Bugzilla Id: 55065

Modified:
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55065] Useless processing in Spline3.converge()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55065

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|wasted work in              |Useless processing in
                   |Spline3.converge()          |Spline3.converge()

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55065] wasted work in Spline3.converge()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55065

Adrian Nistor <ni...@illinois.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
                 CC|                            |nistor1@illinois.edu

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55065] Useless processing in Spline3.converge()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55065

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.