You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Nevo Hed (JIRA)" <ji...@apache.org> on 2014/01/17 07:59:19 UTC

[jira] [Comment Edited] (THRIFT-2184) undefined method rspec_verify for Thrift::MemoryBufferTransport

    [ https://issues.apache.org/jira/browse/THRIFT-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874496#comment-13874496 ] 

Nevo Hed edited comment on THRIFT-2184 at 1/17/14 6:58 AM:
-----------------------------------------------------------

Patch attached

To reproduce the problem one needs to 'sudo gem install rspec' and ensure that the rspec 2.14.x is installed.  While lib/rb/thrift.gemspec specifies 'rspec', '~> 2.10.0'  (i.e. do not go beyond 2.10.x), the install-exec-hook make rule was invoking rake directly, bypassing the gemspec.  Running "rake install" through bundler

p.s. I am a rake/rspec/bundler newb - please review carfully


was (Author: nhed):
To reproduce the problem one needs to 'sudo gem install rspec' and ensure that the rspec 2.14.x is installed.  While lib/rb/thrift.gemspec specifies 'rspec', '~> 2.10.0'  (i.e. do not go beyond 2.10.x), the install-exec-hook make rule was invoking rake directly, bypassing the gemspec.  Running "rake install" through bundler

p.s. I am a rake/rspec/bundler newb - please review carfully

> undefined method rspec_verify for Thrift::MemoryBufferTransport
> ---------------------------------------------------------------
>
>                 Key: THRIFT-2184
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2184
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Library
>    Affects Versions: 0.9.1
>            Reporter: Paul Brannan
>         Attachments: THRIFT-2184.patch
>
>
> When running 'make install', I get the following errors that do not occur when just running 'make':
> {noformat}
>   1) BinaryProtocolAccelerated it should behave like a binary protocol should write a byte
>      Failure/Error: @trans.rspec_verify
>      NoMethodError:
>        undefined method `rspec_verify' for #<Thrift::MemoryBufferTransport:0x000000034e86c8>
>      Shared Example Group: "a binary protocol" called from ./spec/binary_protocol_accelerated_spec.rb:28
>      # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in <top (required)>'
>   2) BinaryProtocol it should behave like a binary protocol should write a byte
>      Failure/Error: @trans.rspec_verify
>      NoMethodError:
>        undefined method `rspec_verify' for #<Thrift::MemoryBufferTransport:0x000000034509e0>
>      Shared Example Group: "a binary protocol" called from ./spec/binary_protocol_spec.rb:25
>      # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in <top (required)>'
> {noformat}
> I commented out the call to #rspec_verify, but I do not know what the correct fix is.
> I also get numerous (related) warnings about mock being deprecated:
> {noformat}
> DEPRECATION: mock is deprecated. Use double instead. Called from /home/pbrannan/git/thrift/lib/rb/spec/unix_socket_spec.rb:93:in `block (3 levels) in <top (required)>'.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)