You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/09/15 12:08:55 UTC
[GitHub] [incubator-mxnet] mozga-intel opened a new pull request #20581: The size of a stack needs to be greater than 4
mozga-intel opened a new pull request #20581:
URL: https://github.com/apache/incubator-mxnet/pull/20581
## Description ##
The size of a stack is always 4. A new optional<T> ([#658](https://github.com/dmlc/dmlc-core/pull/658)) structure is used to indicate that an object t may be "moved from" ~ allowing the efficient transfer of resources from t to another object. If an old value is moved into a new object, then the size is not enough and a blind value is reading out of the memory ~ hence: a double corruption error shows up. The size of the stack needs to be greater to avoid double corruption errors. The issue comes from #20560.
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20581: [Master] The size of a stack needs to be greater than 4
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20581:
URL: https://github.com/apache/incubator-mxnet/pull/20581#issuecomment-920224466
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20581: [Master] The size of a stack needs to be greater than 4
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20581:
URL: https://github.com/apache/incubator-mxnet/pull/20581#issuecomment-920224508
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20581: [Master] The size of a stack needs to be greater than 4
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20581:
URL: https://github.com/apache/incubator-mxnet/pull/20581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20581: The size of a stack needs to be greater than 4
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20581:
URL: https://github.com/apache/incubator-mxnet/pull/20581#issuecomment-919961603
Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [miscellaneous, website, edge, unix-cpu, sanity, windows-cpu, windows-gpu, clang, centos-gpu, unix-gpu, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20581: [Master] The size of a stack needs to be greater than 4
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20581:
URL: https://github.com/apache/incubator-mxnet/pull/20581#issuecomment-920014111
Jenkins CI successfully triggered : [website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20581: [Master] The size of a stack needs to be greater than 4
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20581:
URL: https://github.com/apache/incubator-mxnet/pull/20581#issuecomment-920014056
@mxnet-bot run ci [website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org