You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by sh...@apache.org on 2009/01/16 21:50:59 UTC

svn commit: r735123 - in /hadoop/core/branches/branch-0.20: CHANGES.txt src/hdfs/org/apache/hadoop/hdfs/DFSClient.java

Author: shv
Date: Fri Jan 16 12:50:59 2009
New Revision: 735123

URL: http://svn.apache.org/viewvc?rev=735123&view=rev
Log:
HADOOP-3894. Merge -r 735120:735121 from trunk to branch 0.20.

Modified:
    hadoop/core/branches/branch-0.20/CHANGES.txt
    hadoop/core/branches/branch-0.20/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java

Modified: hadoop/core/branches/branch-0.20/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/branches/branch-0.20/CHANGES.txt?rev=735123&r1=735122&r2=735123&view=diff
==============================================================================
--- hadoop/core/branches/branch-0.20/CHANGES.txt (original)
+++ hadoop/core/branches/branch-0.20/CHANGES.txt Fri Jan 16 12:50:59 2009
@@ -553,6 +553,8 @@
     HADOOP-4739. Fix spelling and grammar, improve phrasing of some sections in
     mapred tutorial. (Vivek Ratan via cdouglas)
 
+    HADOOP-3894. DFSClient logging improvements. (Steve Loughran via shv)
+
   BUG FIXES
 
     HADOOP-4697. Fix getBlockLocations in KosmosFileSystem to handle multiple

Modified: hadoop/core/branches/branch-0.20/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
URL: http://svn.apache.org/viewvc/hadoop/core/branches/branch-0.20/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java?rev=735123&r1=735122&r2=735123&view=diff
==============================================================================
--- hadoop/core/branches/branch-0.20/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java (original)
+++ hadoop/core/branches/branch-0.20/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java Fri Jan 16 12:50:59 2009
@@ -963,8 +963,7 @@
           try {
             out.close();
           } catch (IOException ie) {
-            System.err.println("Exception closing file " + src);
-            ie.printStackTrace();
+            LOG.error("Exception closing file " + src+ " : " + ie, ie);
           }
         }
       }
@@ -2432,7 +2431,9 @@
       while (!success && clientRunning) {
         DatanodeInfo[] newnodes = null;
         if (nodes == null) {
-          String msg = "Could not get block locations. Aborting...";
+          String msg = "Could not get block locations. " +
+                                          "Source file \"" + src
+                                          + "\" - Aborting...";
           LOG.warn(msg);
           setLastException(new IOException(msg));
           closed = true;