You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/06/03 01:38:34 UTC

[GitHub] [incubator-tubemq] pingyu opened a new pull request #122: [TUBEMQ-166]Hide `bdbStore` configs in master.ini

pingyu opened a new pull request #122:
URL: https://github.com/apache/incubator-tubemq/pull/122


   Move `[bdbStore]` configs in `master.ini` to `[replication]` & `[master]`, as `bdb` is an implementation detail, better not to bother users.
   
   ```
   bdbRepGroupName         --> [replication].repGroupName
   bdbNodeName             --> [replication].repNodeName
   bdbNodePort             --> [replication].repNodePort
   bdbHelperHost           --> [replication].repHelperHost
   bdbEnvHome              --> [master].metaDataPath
   bdbLocalSync            --> [replication].metaLocalSyncPolicy
   bdbReplicaSync          --> [replication].metaReplicaSyncPolicy
   bdbReplicaAck           --> [replication].repReplicaAckPolicy
   bdbStatusCheckTimeoutMs --> [replication].repStatusCheckTimeoutMs
   ```  
   
   Besides, `[bdbStore]` section and all inner configs are still supported, but will be ignored when `[replication]` exists.
   Print a warning in master.log about "deprecated blah blah" while [bdbStore] is using.
   
   Related Docs will be update in another PR coming soon:
   ```
   docs/tubemq_config_introduction.md
   docs/tubemq_user_guide.md
   docs/tubemq_config_introduction_cn.doc
   docs/tubemq_user_guide_cn.doc
   ```
   
   Issue: https://issues.apache.org/jira/browse/TUBEMQ-166
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] gosonzhang commented on pull request #122: [TUBEMQ-166]Hide `bdbStore` configs in master.ini

Posted by GitBox <gi...@apache.org>.
gosonzhang commented on pull request #122:
URL: https://github.com/apache/incubator-tubemq/pull/122#issuecomment-637918990


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] gosonzhang merged pull request #122: [TUBEMQ-166]Hide `bdbStore` configs in master.ini

Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #122:
URL: https://github.com/apache/incubator-tubemq/pull/122


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] gosonzhang commented on pull request #122: [TUBEMQ-166]Hide `bdbStore` configs in master.ini

Posted by GitBox <gi...@apache.org>.
gosonzhang commented on pull request #122:
URL: https://github.com/apache/incubator-tubemq/pull/122#issuecomment-637918491


   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org