You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/01 02:57:09 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4661: Make
TransformFunction.getDictionary() API consistent with
DataSource.getDictionary()
codecov-io commented on issue #4661: Make TransformFunction.getDictionary() API consistent with DataSource.getDictionary()
URL: https://github.com/apache/incubator-pinot/pull/4661#issuecomment-536837957
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4661?src=pr&el=h1) Report
> Merging [#4661](https://codecov.io/gh/apache/incubator-pinot/pull/4661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/8193e52ad23177700c66e6fcd5593dcd79c1ec45?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `50.76%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4661 +/- ##
============================================
- Coverage 64.56% 64.54% -0.03%
Complexity 16 16
============================================
Files 1056 1056
Lines 56187 56178 -9
Branches 8328 8323 -5
============================================
- Hits 36276 36258 -18
- Misses 17224 17227 +3
- Partials 2687 2693 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4661?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4661/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...re/startree/v2/store/StarTreeMetricDataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4661/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9zdG9yZS9TdGFyVHJlZU1ldHJpY0RhdGFTb3VyY2UuamF2YQ==) | `56.52% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...not/core/operator/transform/TransformOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4661/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vVHJhbnNmb3JtT3BlcmF0b3IuamF2YQ==) | `94.44% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...re/segment/index/data/source/ColumnDataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4661/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2RhdGEvc291cmNlL0NvbHVtbkRhdGFTb3VyY2UuamF2YQ==) | `95.45% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ator/transform/function/BaseTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4661/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQmFzZVRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `31.11% <40%> (-0.65%)` | `0 <0> (ø)` | |
| [...r/transform/function/ValueInTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4661/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVmFsdWVJblRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `30.7% <45.45%> (-3.14%)` | `0 <0> (ø)` | |
| [...startree/v2/store/StarTreeDimensionDataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4661/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9zdG9yZS9TdGFyVHJlZURpbWVuc2lvbkRhdGFTb3VyY2UuamF2YQ==) | `72.72% <50%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../transform/function/MapValueTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4661/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTWFwVmFsdWVUcmFuc2Zvcm1GdW5jdGlvbi5qYXZh) | `85.29% <66.66%> (+0.91%)` | `0 <0> (ø)` | :arrow_down: |
| [...core/operator/filter/ExpressionFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4661/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvRXhwcmVzc2lvbkZpbHRlck9wZXJhdG9yLmphdmE=) | `71.14% <77.77%> (-0.57%)` | `0 <0> (ø)` | |
| [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4661/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `32.05% <0%> (-51.29%)` | `0% <0%> (ø)` | |
| ... and [40 more](https://codecov.io/gh/apache/incubator-pinot/pull/4661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4661?src=pr&el=footer). Last update [8193e52...c3aefc9](https://codecov.io/gh/apache/incubator-pinot/pull/4661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org