You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/11 09:50:56 UTC

[GitHub] [camel-quarkus] aldettinger opened a new pull request #872: Fixed missing registry values in native mode #867

aldettinger opened a new pull request #872: Fixed missing registry values in native mode #867
URL: https://github.com/apache/camel-quarkus/pull/872
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on issue #872: Fixed missing registry values in native mode #867

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #872: Fixed missing registry values in native mode #867
URL: https://github.com/apache/camel-quarkus/pull/872#issuecomment-597543304
 
 
   @aldettinger sorry, there are conflicts due to #865 , could you please rebase?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #872: Fixed missing registry values in native mode #867

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #872: Fixed missing registry values in native mode #867
URL: https://github.com/apache/camel-quarkus/pull/872#discussion_r390862958
 
 

 ##########
 File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/NativeImageProcessor.java
 ##########
 @@ -224,8 +224,9 @@ void process(
             // Register routes as reflection aware as camel-main main use reflection
             // to bind beans to the registry
             //
-            camelRoutesBuilders.forEach(dotName -> {
-                reflectiveClass.produce(new ReflectiveClassBuildItem(true, true, dotName.toString()));
+            camelRoutesBuilders.forEach(camelRoutesBuilderClassBuildItem -> {
+                reflectiveClass.produce(
+                        new ReflectiveClassBuildItem(true, true, camelRoutesBuilderClassBuildItem.getDotName().toString()));
 
 Review comment:
   good catch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] aldettinger closed pull request #872: Fixed missing registry values in native mode #867

Posted by GitBox <gi...@apache.org>.
aldettinger closed pull request #872: Fixed missing registry values in native mode #867
URL: https://github.com/apache/camel-quarkus/pull/872
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] aldettinger commented on issue #872: Fixed missing registry values in native mode #867

Posted by GitBox <gi...@apache.org>.
aldettinger commented on issue #872: Fixed missing registry values in native mode #867
URL: https://github.com/apache/camel-quarkus/pull/872#issuecomment-597589318
 
 
   Thanks for review guys. @ppalaga, sure I'm gonna rebase and thanks for pointing to the reorg ticket :+1: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services