You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ra...@apache.org on 2018/09/16 11:15:55 UTC

[cordova-cli] branch cross-spawn-test created (now 3dae152)

This is an automated email from the ASF dual-hosted git repository.

raphinesse pushed a change to branch cross-spawn-test
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git.


      at 3dae152  Remove flaky test for cross-spawn test setup

This branch includes the following new commits:

     new 3dae152  Remove flaky test for cross-spawn test setup

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[cordova-cli] 01/01: Remove flaky test for cross-spawn test setup

Posted by ra...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

raphinesse pushed a commit to branch cross-spawn-test
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git

commit 3dae152c5a6f77282998aafa1ec140c95736ef88
Author: Raphael von der GrĂ¼n <ra...@gmail.com>
AuthorDate: Sun Sep 16 13:15:28 2018 +0200

    Remove flaky test for cross-spawn test setup
---
 spec/cli.spec.js | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/spec/cli.spec.js b/spec/cli.spec.js
index 172dd17..17269d2 100644
--- a/spec/cli.spec.js
+++ b/spec/cli.spec.js
@@ -290,32 +290,6 @@ describe('cordova cli', () => {
             });
         });
 
-        it('Test#028 : opts-out if prompt times out AND it tracks opt-out', () => {
-            // Remove any optOut settings that might have been saved
-            // ... and force prompt to be shown
-            telemetry.clear();
-
-            // We override telemetry timeout here so we don't need to wait
-            // 30 seconds. 0s is impossible with the current implementation.
-            telemetry.timeoutInSecs = 0.01;
-
-            // Don't display the prompt
-            spyOn(process.stdout, 'write');
-
-            telemetry.isOptedIn.and.callThrough();
-            telemetry.showPrompt.and.callThrough();
-            telemetry.hasUserOptedInOrOut.and.returnValue(false);
-
-            return cli(['node', 'cordova', '--version']).then(() => {
-                if (process.env.CI) {
-                    expect(telemetry.isOptedIn()).toBeTruthy();
-                } else {
-                    expect(telemetry.isOptedIn()).toBeFalsy();
-                }
-                expect(telemetry.track).toHaveBeenCalledWith('telemetry', 'off', 'via-cli-prompt-choice', 'successful');
-            });
-        });
-
         it("Test#029 : is NOT collected in CI environments and doesn't prompt", () => {
             telemetry.isCI.and.returnValue(true);
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org