You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ap...@apache.org on 2022/10/26 17:35:16 UTC

[arrow] branch master updated: ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h (#14445)

This is an automated email from the ASF dual-hosted git repository.

apitrou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new b87370d607 ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h (#14445)
b87370d607 is described below

commit b87370d6071cdb9313430e14482cbc4f7ad05e35
Author: Sanjiban Sengupta <sa...@gmail.com>
AuthorDate: Wed Oct 26 23:05:08 2022 +0530

    ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h (#14445)
    
    This PR modifies the `DecorateWithRowNumber` method in the `DataBatch` class to return an unknown error to avoid getting a compilation warning.
    
    Lead-authored-by: Sanjiban Sengupta <sa...@gmail.com>
    Co-authored-by: Antoine Pitrou <an...@python.org>
    Signed-off-by: Antoine Pitrou <an...@python.org>
---
 cpp/src/arrow/csv/parser.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cpp/src/arrow/csv/parser.h b/cpp/src/arrow/csv/parser.h
index e257d315e3..c73e52ce83 100644
--- a/cpp/src/arrow/csv/parser.h
+++ b/cpp/src/arrow/csv/parser.h
@@ -121,6 +121,7 @@ class ARROW_EXPORT DataBatch {
     }
     // Use return_if so that when extra context is enabled it will be added
     ARROW_RETURN_IF_(true, std::move(status), ARROW_STRINGIFY(status));
+    return std::move(status);
   }
 
   // The number of rows in this batch (not including any skipped ones)