[jira] [Commented] (PHOENIX-5734) IndexScrutinyTool should not report rows beyond maxLookBack age

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063569#comment-17063569 ] 

Hadoop QA commented on PHOENIX-5734:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12997234/PHOENIX-5734-4.x.patch
  against 4.x branch at commit 264715133cdb8085b48a79eddfe3d27736614715.
  ATTACHMENT ID: 12997234

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        props.put(QueryServices.GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS_ATTRIB, Long.toString(0));
+    private static PreparedStatement getUpsertDataStmt(String tableFullName, Connection conn) throws SQLException {
+                        SchemaUtil.getPhysicalHBaseTableName(schema, dataTableName, false).getString();
+                    tableToCompact = SchemaUtil.getPhysicalHBaseTableName(schema, indexTableName, false).getString();
+                SourceTable sourceTable, Class<? extends IndexScrutinyMapper> mapperClass) throws Exception {
+        private Job configureSubmittableJob(Job job, Path outputPath, Class<? extends IndexScrutinyMapper> mapperClass) throws Exception {
+                throw new IllegalArgumentException("Index scrutiny can't look back past the configured" +

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3620//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3620//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3620//console

This message is automatically generated.

> IndexScrutinyTool should not report rows beyond maxLookBack age
> ---------------------------------------------------------------
>
>                 Key: PHOENIX-5734
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5734
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Swaroopa Kadam
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>             Fix For: 4.16.0
>
>         Attachments: PHOENIX-5734-4.x.patch, PHOENIX-5734.4.x-HBase-1.3.v1.patch
>
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> Index Scrutiny tool should not report row mismatch if the row gets rewritten during the run and the last version around is beyond max look back age which will then get removed by compaction. 
>  
> Or add another type of counters to separate invalid rows into BEYOND_MAX_LOOKBACK or similar



--
This message was sent by Atlassian Jira
(v8.3.4#803005)