You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/09/14 11:50:17 UTC

[GitHub] [incubator-dolphinscheduler] geosmart opened a new pull request #3743: [FEATURE-736] integrate ldap authentication

geosmart opened a new pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743


   ## What is the purpose of the pull request
   impletments FAETURE [#736] to integrate ldap authentication
   
   ## Brief change log
   *(for example:)*
     - format code in package `org.apache.dolphinscheduler.api.security`
     - add ldap config in `application-api.properties`,config use online mock ldap server
     - core logic in `LdapAuthenticator`(for user login ) and `LdapService` (for ldap auth)
    
   ## Verify this pull request
   This change added tests and can be verified as follows:
   
   *(example:)*
     - Added LdapAuthenticatorTest to test authenticate.
     - Added LdapServiceTest to test ldap auth.
     - Change SecurityConfigTest  to SecurityConfigPassWordTest fro password auth.
     - Added SecurityConfigLDAPTest  fro ldapauth.
     - refactor authentication with ldap and password


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-750038323


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/50.png' alt='58.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list) [58.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692021598


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
 ct/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/50.png' alt='58.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list) [58.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692007525


   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
 ct/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/50.png' alt='58.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list) [58.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5.png' alt='4.1%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list) [4.1% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-commenter commented on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692020157


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=h1) Report
   > Merging [#3743](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/3942740941533721694ceef2177c5363b0d0f200?el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `37.86%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #3743      +/-   ##
   ============================================
   - Coverage     39.98%   39.96%   -0.03%     
   - Complexity     2901     2908       +7     
   ============================================
     Files           457      460       +3     
     Lines         21665    21726      +61     
     Branches       2637     2642       +5     
   ============================================
   + Hits           8662     8682      +20     
   - Misses        12185    12229      +44     
   + Partials        818      815       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...nscheduler/api/security/impl/ldap/LdapService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvbGRhcC9MZGFwU2VydmljZS5qYXZh) | `5.40% <5.40%> (ø)` | `2.00 <2.00> (?)` | |
   | [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `74.77% <42.85%> (+0.41%)` | `81.00 <1.00> (+1.00)` | |
   | [...uler/api/security/impl/ldap/LdapAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvbGRhcC9MZGFwQXV0aGVudGljYXRvci5qYXZh) | `87.50% <87.50%> (ø)` | `3.00 <3.00> (?)` | |
   | [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `68.42% <100.00%> (+3.71%)` | `5.00 <0.00> (+1.00)` | |
   | [...duler/api/security/impl/AbstractAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvQWJzdHJhY3RBdXRoZW50aWNhdG9yLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <2.00> (?)` | |
   | [...r/api/security/impl/pwd/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvcHdkL1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh) | `33.33% <0.00%> (-21.57%)` | `5.00% <0.00%> (-1.00%)` | |
   | [...rver/master/processor/queue/TaskResponseEvent.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlRXZlbnQuamF2YQ==) | `49.01% <0.00%> (-9.81%)` | `9.00% <0.00%> (-5.00%)` | |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=footer). Last update [3942740...cd375d8](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] geosmart removed a comment on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
geosmart removed a comment on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692020837


   > # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=h1) Report
   > > Merging [#3743](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/3942740941533721694ceef2177c5363b0d0f200?el=desc) will **decrease** coverage by `0.02%`.
   > > The diff coverage is `37.86%`.
   > 
   > [![Impacted file tree graph](https://camo.githubusercontent.com/1da646f7a87233eb4143f01ff390b5e2fec98ba5/68747470733a2f2f636f6465636f762e696f2f67682f6170616368652f696e63756261746f722d646f6c7068696e7363686564756c65722f70756c6c2f333734332f6772617068732f747265652e7376673f77696474683d363530266865696768743d313530267372633d707226746f6b656e3d627639695858524c6939)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=tree)
   > 
   > ```diff
   > @@             Coverage Diff              @@
   > ##                dev    #3743      +/-   ##
   > ============================================
   > - Coverage     39.98%   39.96%   -0.03%     
   > - Complexity     2901     2908       +7     
   > ============================================
   >   Files           457      460       +3     
   >   Lines         21665    21726      +61     
   >   Branches       2637     2642       +5     
   > ============================================
   > + Hits           8662     8682      +20     
   > - Misses        12185    12229      +44     
   > + Partials        818      815       -3     
   > ```
   > 
   > [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=tree)	Coverage Δ	Complexity Δ	
   > [...nscheduler/api/security/impl/ldap/LdapService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvbGRhcC9MZGFwU2VydmljZS5qYXZh)	`5.40% <5.40%> (ø)`	`2.00 <2.00> (?)`	
   > [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=)	`74.77% <42.85%> (+0.41%)`	`81.00 <1.00> (+1.00)`	
   > [...uler/api/security/impl/ldap/LdapAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvbGRhcC9MZGFwQXV0aGVudGljYXRvci5qYXZh)	`87.50% <87.50%> (ø)`	`3.00 <3.00> (?)`	
   > [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh)	`100.00% <100.00%> (ø)`	`2.00 <0.00> (ø)`	
   > [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=)	`68.42% <100.00%> (+3.71%)`	`5.00 <0.00> (+1.00)`	
   > [...duler/api/security/impl/AbstractAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvQWJzdHJhY3RBdXRoZW50aWNhdG9yLmphdmE=)	`100.00% <100.00%> (ø)`	`8.00 <2.00> (?)`	
   > [...r/api/security/impl/pwd/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvcHdkL1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh)	`100.00% <100.00%> (ø)`	`2.00 <2.00> (?)`	
   > [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh)	`33.33% <0.00%> (-21.57%)`	`5.00% <0.00%> (-1.00%)`	
   > [...rver/master/processor/queue/TaskResponseEvent.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlRXZlbnQuamF2YQ==)	`49.01% <0.00%> (-9.81%)`	`9.00% <0.00%> (-5.00%)`	
   > ... and [4 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree-more)			
   > [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=continue).
   > 
   > > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=footer). Last update [3942740...cd375d8](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] geosmart commented on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
geosmart commented on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692020837


   > # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=h1) Report
   > > Merging [#3743](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/3942740941533721694ceef2177c5363b0d0f200?el=desc) will **decrease** coverage by `0.02%`.
   > > The diff coverage is `37.86%`.
   > 
   > [![Impacted file tree graph](https://camo.githubusercontent.com/1da646f7a87233eb4143f01ff390b5e2fec98ba5/68747470733a2f2f636f6465636f762e696f2f67682f6170616368652f696e63756261746f722d646f6c7068696e7363686564756c65722f70756c6c2f333734332f6772617068732f747265652e7376673f77696474683d363530266865696768743d313530267372633d707226746f6b656e3d627639695858524c6939)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=tree)
   > 
   > ```diff
   > @@             Coverage Diff              @@
   > ##                dev    #3743      +/-   ##
   > ============================================
   > - Coverage     39.98%   39.96%   -0.03%     
   > - Complexity     2901     2908       +7     
   > ============================================
   >   Files           457      460       +3     
   >   Lines         21665    21726      +61     
   >   Branches       2637     2642       +5     
   > ============================================
   > + Hits           8662     8682      +20     
   > - Misses        12185    12229      +44     
   > + Partials        818      815       -3     
   > ```
   > 
   > [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=tree)	Coverage Δ	Complexity Δ	
   > [...nscheduler/api/security/impl/ldap/LdapService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvbGRhcC9MZGFwU2VydmljZS5qYXZh)	`5.40% <5.40%> (ø)`	`2.00 <2.00> (?)`	
   > [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=)	`74.77% <42.85%> (+0.41%)`	`81.00 <1.00> (+1.00)`	
   > [...uler/api/security/impl/ldap/LdapAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvbGRhcC9MZGFwQXV0aGVudGljYXRvci5qYXZh)	`87.50% <87.50%> (ø)`	`3.00 <3.00> (?)`	
   > [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh)	`100.00% <100.00%> (ø)`	`2.00 <0.00> (ø)`	
   > [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=)	`68.42% <100.00%> (+3.71%)`	`5.00 <0.00> (+1.00)`	
   > [...duler/api/security/impl/AbstractAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvQWJzdHJhY3RBdXRoZW50aWNhdG9yLmphdmE=)	`100.00% <100.00%> (ø)`	`8.00 <2.00> (?)`	
   > [...r/api/security/impl/pwd/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvcHdkL1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh)	`100.00% <100.00%> (ø)`	`2.00 <2.00> (?)`	
   > [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh)	`33.33% <0.00%> (-21.57%)`	`5.00% <0.00%> (-1.00%)`	
   > [...rver/master/processor/queue/TaskResponseEvent.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlRXZlbnQuamF2YQ==)	`49.01% <0.00%> (-9.81%)`	`9.00% <0.00%> (-5.00%)`	
   > ... and [4 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree-more)			
   > [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=continue).
   > 
   > > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=footer). Last update [3942740...cd375d8](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] felix-thinkingdata commented on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
felix-thinkingdata commented on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692451479


   ok  i see😅😅😅发自我的iPhone------------------ Original ------------------From: geosmart  <no...@github.com>Date: Tue,Sep 15,2020 9:19 AMTo: apache/incubator-dolphinscheduler <in...@noreply.github.com>Cc: felix.wang <fe...@thinkingdata.cn>, Comment <co...@noreply.github.com>Subject: Re: [apache/incubator-dolphinscheduler] [FEATURE-736] integrate ldapauthentication (#3743)
   
   
   
   dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/AbstractAuthenticator.java
   
   Is this abstraction necessary?
   
   这种抽象有没有必要？
   
   
   
   if I don't refactor a AbstractAuthenticator , sonar will detect the duplicate and can not pass...
   
   
   
   —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.
   
   [
   
   {
   
   "@context": "http://schema.org",
   
   "@type": "EmailMessage",
   
   "potentialAction": {
   
   "@type": "ViewAction",
   
   "target": "https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692402838",
   
   "url": "https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692402838",
   
   "name": "View Pull Request"
   
   },
   
   "description": "View this Pull Request on GitHub",
   
   "publisher": {
   
   "@type": "Organization",
   
   "name": "GitHub",
   
   "url": "https://github.com"
   
   }
   
   }
   
   ]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] geosmart commented on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
geosmart commented on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692402838


   > dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/AbstractAuthenticator.java
   > 
   > Is this abstraction necessary?
   > 
   > 这种抽象有没有必要？
   
   if I don't refactor a AbstractAuthenticator , sonar will detect the duplicate and can not pass...
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692021598


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
 ct/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/50.png' alt='58.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list) [58.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] geosmart commented on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
geosmart commented on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692022076


   LdapService.java need Ldap service to test, the online demo ldap service is not stable for continue delivery.
   so I didn't add LdapServiceTest.java to the pom file


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692007525


   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
 ct/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/50.png' alt='58.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list) [58.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5.png' alt='4.1%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list) [4.1% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] CalvinKirs merged pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-750036483


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=h1) Report
   > Merging [#3743](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=desc) (9084c88) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/e24e690c0b79bf7f9e66fe5c75dedcc1d266cfde?el=desc) (e24e690) will **increase** coverage by `0.01%`.
   > The diff coverage is `37.86%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #3743      +/-   ##
   ============================================
   + Coverage     43.17%   43.18%   +0.01%     
   - Complexity     3169     3177       +8     
   ============================================
     Files           467      470       +3     
     Lines         21668    21729      +61     
     Branches       2621     2626       +5     
   ============================================
   + Hits           9355     9384      +29     
   - Misses        11414    11447      +33     
   + Partials        899      898       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...nscheduler/api/security/impl/ldap/LdapService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvbGRhcC9MZGFwU2VydmljZS5qYXZh) | `5.40% <5.40%> (ø)` | `2.00 <2.00> (?)` | |
   | [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `74.13% <42.85%> (+0.43%)` | `79.00 <1.00> (+1.00)` | |
   | [...uler/api/security/impl/ldap/LdapAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvbGRhcC9MZGFwQXV0aGVudGljYXRvci5qYXZh) | `87.50% <87.50%> (ø)` | `3.00 <3.00> (?)` | |
   | [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `68.42% <100.00%> (+3.71%)` | `5.00 <0.00> (+1.00)` | |
   | [...duler/api/security/impl/AbstractAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvQWJzdHJhY3RBdXRoZW50aWNhdG9yLmphdmE=) | `100.00% <100.00%> (ø)` | `8.00 <2.00> (?)` | |
   | [...r/api/security/impl/pwd/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvcHdkL1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...org/apache/dolphinscheduler/remote/utils/Host.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0hvc3QuamF2YQ==) | `13.43% <0.00%> (-2.99%)` | `5.00% <0.00%> (-1.00%)` | |
   | [...dolphinscheduler/remote/future/ResponseFuture.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2Z1dHVyZS9SZXNwb25zZUZ1dHVyZS5qYXZh) | `81.35% <0.00%> (-1.70%)` | `18.00% <0.00%> (-1.00%)` | |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=footer). Last update [e24e690...9084c88](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3743?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692027034


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
 ct/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3743&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/50.png' alt='58.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list) [58.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3743&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] geosmart closed pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
geosmart closed pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] geosmart edited a comment on pull request #3743: [FEATURE-736] integrate ldap authentication

Posted by GitBox <gi...@apache.org>.
geosmart edited a comment on pull request #3743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692022076






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org