You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2009/10/19 12:21:31 UTC
[jira] Created: (QPID-2154) New Network IO Layer has doesn't appear
to clean up connections on connection close.
New Network IO Layer has doesn't appear to clean up connections on connection close.
------------------------------------------------------------------------------------
Key: QPID-2154
URL: https://issues.apache.org/jira/browse/QPID-2154
Project: Qpid
Issue Type: Bug
Components: Java Broker
Reporter: Martin Ritchie
Fix For: 0.6
Attachments: MessageDisappearTail.txt
The new AMQProtocolEngine appears does not appear to reliably clear the ConnectionRegistry when closing connections.
The Missing test run over the weekend genereated 25GB of log which appears to be the Broker stuck in the ConnectionRegistry.close() loop. This would suggest that the new IO layer is not correctly notifying and/or removing the closed connection from the ConnectionRegistry.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2154) New Network IO Layer has doesn't appear
to clean up connections on connection close.
Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marnie McCormack updated QPID-2154:
-----------------------------------
Fix Version/s: (was: 0.6)
0.7
Moving items unlikely to be completed for 0.6 out to 0.7
> New Network IO Layer has doesn't appear to clean up connections on connection close.
> ------------------------------------------------------------------------------------
>
> Key: QPID-2154
> URL: https://issues.apache.org/jira/browse/QPID-2154
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: 0.7
>
> Attachments: MessageDisappearTail.txt
>
>
> The new AMQProtocolEngine appears does not appear to reliably clear the ConnectionRegistry when closing connections.
> The Missing test run over the weekend genereated 25GB of log which appears to be the Broker stuck in the ConnectionRegistry.close() loop. This would suggest that the new IO layer is not correctly notifying and/or removing the closed connection from the ConnectionRegistry.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2154) New Network IO Layer has doesn't
appear to clean up connections on connection close.
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770754#action_12770754 ]
Aidan Skinner commented on QPID-2154:
-------------------------------------
I can't see any way for the connection to be added twice, I think it's more likely that the _virtualHost is null, which I guess is possible, if unlikely.
It might be better to make this a little less fragile by storing a pointer to the connectionRegistry itself in setVirtualHost.
Is this happening regularly, or was it a once off?
> New Network IO Layer has doesn't appear to clean up connections on connection close.
> ------------------------------------------------------------------------------------
>
> Key: QPID-2154
> URL: https://issues.apache.org/jira/browse/QPID-2154
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Martin Ritchie
> Assignee: Aidan Skinner
> Fix For: 0.6
>
> Attachments: MessageDisappearTail.txt
>
>
> The new AMQProtocolEngine appears does not appear to reliably clear the ConnectionRegistry when closing connections.
> The Missing test run over the weekend genereated 25GB of log which appears to be the Broker stuck in the ConnectionRegistry.close() loop. This would suggest that the new IO layer is not correctly notifying and/or removing the closed connection from the ConnectionRegistry.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2154) New Network IO Layer has doesn't
appear to clean up connections on connection close.
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767281#action_12767281 ]
Martin Ritchie commented on QPID-2154:
--------------------------------------
After taking a heap dump. Out of the many(15) virtualhosts that we have created! (Something else to address with our InVM testing)
There is only one virtualhost that has eny AMQProtocolEngines. This Engine is marked _closed=true, so wlll never remove from the _registry.
Questions:
- The only place _closed is set true is AFTER the ConnectionRegistry remove.. so was it added twice?
- If it wasn't added twice then why was it not removed.
> New Network IO Layer has doesn't appear to clean up connections on connection close.
> ------------------------------------------------------------------------------------
>
> Key: QPID-2154
> URL: https://issues.apache.org/jira/browse/QPID-2154
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Martin Ritchie
> Fix For: 0.6
>
> Attachments: MessageDisappearTail.txt
>
>
> The new AMQProtocolEngine appears does not appear to reliably clear the ConnectionRegistry when closing connections.
> The Missing test run over the weekend genereated 25GB of log which appears to be the Broker stuck in the ConnectionRegistry.close() loop. This would suggest that the new IO layer is not correctly notifying and/or removing the closed connection from the ConnectionRegistry.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-2154) New Network IO Layer has doesn't
appear to clean up connections on connection close.
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner reassigned QPID-2154:
-----------------------------------
Assignee: Aidan Skinner
> New Network IO Layer has doesn't appear to clean up connections on connection close.
> ------------------------------------------------------------------------------------
>
> Key: QPID-2154
> URL: https://issues.apache.org/jira/browse/QPID-2154
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Martin Ritchie
> Assignee: Aidan Skinner
> Fix For: 0.6
>
> Attachments: MessageDisappearTail.txt
>
>
> The new AMQProtocolEngine appears does not appear to reliably clear the ConnectionRegistry when closing connections.
> The Missing test run over the weekend genereated 25GB of log which appears to be the Broker stuck in the ConnectionRegistry.close() loop. This would suggest that the new IO layer is not correctly notifying and/or removing the closed connection from the ConnectionRegistry.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2154) New Network IO Layer has doesn't appear
to clean up connections on connection close.
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-2154:
---------------------------------
Attachment: MessageDisappearTail.txt
This is the end of the test out file that was over 25Gb. The remaineder of the file was the loop:
Internal Error - closing connection
Marking connection : Closing (was closed)
Marking connection : Closed ( was closing).
> New Network IO Layer has doesn't appear to clean up connections on connection close.
> ------------------------------------------------------------------------------------
>
> Key: QPID-2154
> URL: https://issues.apache.org/jira/browse/QPID-2154
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Martin Ritchie
> Fix For: 0.6
>
> Attachments: MessageDisappearTail.txt
>
>
> The new AMQProtocolEngine appears does not appear to reliably clear the ConnectionRegistry when closing connections.
> The Missing test run over the weekend genereated 25GB of log which appears to be the Broker stuck in the ConnectionRegistry.close() loop. This would suggest that the new IO layer is not correctly notifying and/or removing the closed connection from the ConnectionRegistry.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-2154) New Network IO Layer has doesn't
appear to clean up connections on connection close.
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner reassigned QPID-2154:
-----------------------------------
Assignee: Martin Ritchie (was: Aidan Skinner)
Hrm, Jira doesn't have a NEEDINFO status...
> New Network IO Layer has doesn't appear to clean up connections on connection close.
> ------------------------------------------------------------------------------------
>
> Key: QPID-2154
> URL: https://issues.apache.org/jira/browse/QPID-2154
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: 0.6
>
> Attachments: MessageDisappearTail.txt
>
>
> The new AMQProtocolEngine appears does not appear to reliably clear the ConnectionRegistry when closing connections.
> The Missing test run over the weekend genereated 25GB of log which appears to be the Broker stuck in the ConnectionRegistry.close() loop. This would suggest that the new IO layer is not correctly notifying and/or removing the closed connection from the ConnectionRegistry.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org