You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2011/01/11 12:59:46 UTC

[jira] Created: (CASSANDRA-1963) Allow user to specify files to compact through JMX

Allow user to specify files to compact through JMX 
---------------------------------------------------

                 Key: CASSANDRA-1963
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1963
             Project: Cassandra
          Issue Type: New Feature
          Components: API
            Reporter: Sylvain Lebresne
            Assignee: Sylvain Lebresne
            Priority: Minor
             Fix For: 0.7.1


When you don't have enough space to perform a major compaction but know there
would be space to reclaim, the actual algorithm (discard the biggest sstables
one by one until it fits) may not be helpful.
This is even more true now that minor compaction can remove tombstone and more
importantly with expiring columns (for which the compaction of a single
sstable can make sense).

This ticket proposes to expose a simple function through JMX to allow the
submission of a compaction on user-specified sstables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1963) Allow user to specify files to compact through JMX

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-1963:
----------------------------------------

    Attachment: 0001-Allow-submitting-compaction-of-user-defined-files.patch

> Allow user to specify files to compact through JMX 
> ---------------------------------------------------
>
>                 Key: CASSANDRA-1963
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1963
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 0001-Allow-submitting-compaction-of-user-defined-files.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When you don't have enough space to perform a major compaction but know there
> would be space to reclaim, the actual algorithm (discard the biggest sstables
> one by one until it fits) may not be helpful.
> This is even more true now that minor compaction can remove tombstone and more
> importantly with expiring columns (for which the compaction of a single
> sstable can make sense).
> This ticket proposes to expose a simple function through JMX to allow the
> submission of a compaction on user-specified sstables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1963) Allow user to specify files to compact through JMX

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-1963:
----------------------------------------

    Attachment: 0001-Allow-submitting-compaction-of-user-defined-files.patch

> Allow user to specify files to compact through JMX 
> ---------------------------------------------------
>
>                 Key: CASSANDRA-1963
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1963
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 0001-Allow-submitting-compaction-of-user-defined-files.patch
>
>   Original Estimate: 2h
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> When you don't have enough space to perform a major compaction but know there
> would be space to reclaim, the actual algorithm (discard the biggest sstables
> one by one until it fits) may not be helpful.
> This is even more true now that minor compaction can remove tombstone and more
> importantly with expiring columns (for which the compaction of a single
> sstable can make sense).
> This ticket proposes to expose a simple function through JMX to allow the
> submission of a compaction on user-specified sstables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1963) Allow user to specify files to compact through JMX

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980127#action_12980127 ] 

Sylvain Lebresne commented on CASSANDRA-1963:
---------------------------------------------

.equals() with no other changes won't work because in sstable.descriptor, the directory is an absolute path.
We could construct descriptor with an absolute path too but I haven't found any satisfying way to do that 
(DB.getDataFileLocationForTable() may not return the right path if you have multiple volumes). Hence the 
endsWith.

> Allow user to specify files to compact through JMX 
> ---------------------------------------------------
>
>                 Key: CASSANDRA-1963
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1963
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 0001-Allow-submitting-compaction-of-user-defined-files.patch, 1963-v2.txt
>
>   Original Estimate: 2h
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> When you don't have enough space to perform a major compaction but know there
> would be space to reclaim, the actual algorithm (discard the biggest sstables
> one by one until it fits) may not be helpful.
> This is even more true now that minor compaction can remove tombstone and more
> importantly with expiring columns (for which the compaction of a single
> sstable can make sense).
> This ticket proposes to expose a simple function through JMX to allow the
> submission of a compaction on user-specified sstables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1963) Allow user to specify files to compact through JMX

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-1963:
----------------------------------------

    Attachment:     (was: 0001-Allow-submitting-compaction-of-user-defined-files.patch)

> Allow user to specify files to compact through JMX 
> ---------------------------------------------------
>
>                 Key: CASSANDRA-1963
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1963
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 0001-Allow-submitting-compaction-of-user-defined-files.patch
>
>   Original Estimate: 2h
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> When you don't have enough space to perform a major compaction but know there
> would be space to reclaim, the actual algorithm (discard the biggest sstables
> one by one until it fits) may not be helpful.
> This is even more true now that minor compaction can remove tombstone and more
> importantly with expiring columns (for which the compaction of a single
> sstable can make sense).
> This ticket proposes to expose a simple function through JMX to allow the
> submission of a compaction on user-specified sstables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1963) Allow user to specify files to compact through JMX

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1963:
--------------------------------------

    Attachment: 1963-v2.txt

some cleanup in v2.

is there a reason for using endswith in 

            if (sstable.descriptor.toString().endsWith(descriptor.toString()))

?

Seems like .equals would be more appropriate, possibly case-insensitive.

> Allow user to specify files to compact through JMX 
> ---------------------------------------------------
>
>                 Key: CASSANDRA-1963
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1963
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 0001-Allow-submitting-compaction-of-user-defined-files.patch, 1963-v2.txt
>
>   Original Estimate: 2h
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> When you don't have enough space to perform a major compaction but know there
> would be space to reclaim, the actual algorithm (discard the biggest sstables
> one by one until it fits) may not be helpful.
> This is even more true now that minor compaction can remove tombstone and more
> importantly with expiring columns (for which the compaction of a single
> sstable can make sense).
> This ticket proposes to expose a simple function through JMX to allow the
> submission of a compaction on user-specified sstables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1963) Allow user to specify files to compact through JMX

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980210#action_12980210 ] 

Hudson commented on CASSANDRA-1963:
-----------------------------------

Integrated in Cassandra-0.7 #151 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/151/])
    

> Allow user to specify files to compact through JMX 
> ---------------------------------------------------
>
>                 Key: CASSANDRA-1963
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1963
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.1
>
>         Attachments: 0001-Allow-submitting-compaction-of-user-defined-files.patch, 1963-v2.txt
>
>   Original Estimate: 2h
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> When you don't have enough space to perform a major compaction but know there
> would be space to reclaim, the actual algorithm (discard the biggest sstables
> one by one until it fits) may not be helpful.
> This is even more true now that minor compaction can remove tombstone and more
> importantly with expiring columns (for which the compaction of a single
> sstable can make sense).
> This ticket proposes to expose a simple function through JMX to allow the
> submission of a compaction on user-specified sstables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.