[jira] [Commented] (TEZ-1495) ATS integration for TezClient

["Hitesh Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118437#comment-14118437 ] 

Hitesh Shah commented on TEZ-1495:
----------------------------------

Comments
  - replace "http://" and "https://" with final static constants
  - getVertexStatus throws exception with "Failed to parse DagStatus" 

{code}
+    // Status of the DAG is updated only when it completes. default to RUNNING if no status found
+    // as the ATS is not updated until the status of dag is running.
{code}
   - the above should be fixed in the event generation layer. 
   
   - please file a jira for "//TODO: till secure mode testing is done." if it is meant to be addressed in a follow-up jira - also change comment to include the jira info. 

{code}
+    } catch (RuntimeException e) {
+      throw new TezException("Unknown error occurred while fetching data from ATS");
+    }
{code}
   - why is there a catch-all block here? Is there a particular exception ( or set of exceptions ) that needs to be caught? 








> ATS integration for TezClient
> -----------------------------
>
>                 Key: TEZ-1495
>                 URL: https://issues.apache.org/jira/browse/TEZ-1495
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Prakash Ramachandran
>            Assignee: Prakash Ramachandran
>         Attachments: TEZ-1495.1.patch, TEZ-1495.2.patch, TEZ-1495.3.patch, TEZ-1495.WIP.1.patch
>
>
> Tez client should automatically redirect to ATS when the AM is not running.
> All APIs exposed ( DAG status, counters, etc ) from the DAGClient should continue to work after the AM has shut down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)