[jira] [Commented] (TEZ-3313) ATSFileParser : Wrong args passed in VersionInfo

["Rajesh Balamohan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360702#comment-15360702 ] 

Rajesh Balamohan commented on TEZ-3313:
---------------------------------------

[~ozawa] - Thanks for the review. 

1. What's the difference between revision and version? We should write it down on docs.
>> version would be something like "version=0.7.0" and revision would be the git_commit_id "revision=46301d87cd9aaffaee17a6a14c51e97cd9e9313d".

2. Why not making the order of arguments for constructors same as org.apache.tez.common.VersionInfo? (String version, String revision, String buildTime) looks to be better since it's more consistent with org.apache.tez.common.VersionInfo.
>> Agreed, that can be done. Btw, reusing common.VersionInfo would call for relaxing the constructor to public in org.apache.tez.common.VersionInfo. When tez parser was created, it was created as an independent module and not make any changes in existing tez. Hence, POJO was created as it is just an internal representation.



> ATSFileParser : Wrong args passed in VersionInfo
> ------------------------------------------------
>
>                 Key: TEZ-3313
>                 URL: https://issues.apache.org/jira/browse/TEZ-3313
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Rajesh Balamohan
>            Priority: Minor
>         Attachments: TEZ-3313.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)